From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933491AbcGKDVN (ORCPT ); Sun, 10 Jul 2016 23:21:13 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:45544 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932250AbcGKDVL (ORCPT ); Sun, 10 Jul 2016 23:21:11 -0400 Subject: Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist To: Jiri Olsa References: <1467869689-214015-1-git-send-email-wangnan0@huawei.com> <1467869689-214015-4-git-send-email-wangnan0@huawei.com> <20160708144845.GF31763@krava> CC: , , , , Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Nilay Vaish , He Kuang From: "Wangnan (F)" Message-ID: <57831063.9020901@huawei.com> Date: Mon, 11 Jul 2016 11:20:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160708144845.GF31763@krava> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.578310A2.0085,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 97146b9c87ed416f9a6e512a60c00614 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/7/8 22:48, Jiri Olsa wrote: > On Thu, Jul 07, 2016 at 05:34:44AM +0000, Wang Nan wrote: > > SNIP > >> ret = TEST_FAIL; >> - err = do_test(evlist, opts.mmap_pages, &sample_count, >> + err = do_test(evlist, aux_evlist, opts.mmap_pages, >> + &enter_sample_count, &exit_sample_count, >> &comm_count); >> if (err != TEST_OK) >> goto out_delete_evlist; >> >> - if ((sample_count != NR_ITERS) || (comm_count != NR_ITERS)) { >> - pr_err("Unexpected counter: sample_count=%d, comm_count=%d\n", >> - sample_count, comm_count); >> + if (enter_sample_count != exit_sample_count) { >> + pr_err("Unexpected counter: enter_sample_count=%d, exit_sample_count=%d\n", >> + enter_sample_count, exit_sample_count); >> + goto out_delete_evlist; >> + } >> + >> + if ((exit_sample_count != NR_ITERS) || (comm_count != NR_ITERS)) { >> + pr_err("Unexpected counter: exit_sample_count=%d, comm_count=%d\n", >> + exit_sample_count, comm_count); >> goto out_delete_evlist; >> } >> >> - err = do_test(evlist, 1, &sample_count, &comm_count); >> + err = do_test(evlist, aux_evlist, 1, &dummy, &dummy, &dummy); > why dont you test numbers for 1 page mmap? seems like the data would fit.. > is the purpose just to check if we can map just 1 page? Data won't fit. 1 page map make sure the buffer is overwritten. Thank you. > thanks, > jirka