From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Randy Li <ayaka@soulik.info>
Cc: alexandre.belloni@free-electrons.com, a.zummo@towertech.it,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work
Date: Mon, 11 Jul 2016 07:46:40 +0200 [thread overview]
Message-ID: <578332C0.4010601@samsung.com> (raw)
In-Reply-To: <1468056226-19128-1-git-send-email-ayaka@soulik.info>
On 07/09/2016 11:23 AM, Randy Li wrote:
> The 8792f7772f4f40ffc68bad5f28311205584b734d would just make those
> platform using rtc core from exynos3250 work but have a huge
> effect on those platforms using the rtc core from s3c6410.
> These patches would fix this problem.
>
Which problem? What huge effect? On which platforms? You didn't describe
it...
Your change breaks the ABI and is not compatible with current bindings
documentation.
Best regards,
Krzysztof
> Randy Li (3):
> Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data"
> rtc: s3c: add device data for samsung,exynos3250-rtc
> ARM: dts: exynos: correct the rtc compatible value for exynos5
>
> arch/arm/boot/dts/exynos3250.dtsi | 2 +-
> arch/arm/boot/dts/exynos5.dtsi | 2 +-
> drivers/rtc/rtc-s3c.c | 15 +++++++++++++--
> 3 files changed, 15 insertions(+), 4 deletions(-)
>
prev parent reply other threads:[~2016-07-11 5:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 9:23 [PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work Randy Li
2016-07-09 9:23 ` [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" Randy Li
2016-07-11 5:48 ` Krzysztof Kozlowski
2016-07-09 9:23 ` [PATCH 2/3] rtc: s3c: add device data for samsung,exynos3250-rtc Randy Li
2016-07-11 5:49 ` Krzysztof Kozlowski
2016-07-09 9:23 ` [PATCH 3/3] ARM: dts: exynos: correct the rtc compatible value for exynos5 Randy Li
2016-07-11 5:52 ` Krzysztof Kozlowski
2016-07-11 5:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578332C0.4010601@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=ayaka@soulik.info \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox