From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757761AbcGKFqy (ORCPT ); Mon, 11 Jul 2016 01:46:54 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:18675 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757693AbcGKFqq (ORCPT ); Mon, 11 Jul 2016 01:46:46 -0400 X-AuditID: cbfec7f5-f792a6d000001302-12-578332c28439 Subject: Re: [PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work To: Randy Li References: <1468056226-19128-1-git-send-email-ayaka@soulik.info> Cc: alexandre.belloni@free-electrons.com, a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <578332C0.4010601@samsung.com> Date: Mon, 11 Jul 2016 07:46:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1468056226-19128-1-git-send-email-ayaka@soulik.info> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsVy+t/xa7qHjJrDDSa+EbJYcvEqu0XHtcVM Fq/u/mK0mH/kHKvF6xeGFpseX2O1uLxrDpvFjPP7mCwOTd3LaLH0+kUmi9a9R9gt9nd2MDrw eKyZt4bR4/K1i8weTzZdZPTYM/Ekm8emVZ1sHpuX1Hv0bVnF6NF8dzqrx/R5P5k8Pm+SC+CK 4rJJSc3JLEst0rdL4Mq4smU6U8EM9oquD0tZGxivs3YxcnJICJhIzF/3hQXCFpO4cG89G4gt JLCUUeLzhpguRi4g+xmjRN/RtWAJYQF/iRfXX4A1iwgoSCxfsJ0JosFRYtvEScwgDcwCS5gk /tzsZAZJsAkYS2xevoQNYoOcRG/3JLBtvAJaEhff3wKrYRFQleg4fxJsqKhAhMSs7T+YIGoE JX5MvgdWzyngJNEz6S9QDQfQAj2J+xe1QMLMAvISm9e8ZZ7AKDgLSccshKpZSKoWMDKvYhRN LU0uKE5KzzXSK07MLS7NS9dLzs/dxAiJra87GJceszrEKMDBqMTDG7C9KVyINbGsuDL3EKME B7OSCO9R+eZwId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rwzd70PERJITyxJzU5NLUgtgskycXBK NTAy/7h7V1vnk5WQ839F93qT+zwbWs8+Dvd+/uyTpCKz87W50u+O/bmjul/Mbb+TldEEuWs5 uzWPedqJMU3+3na1zz3vZMmOp93m+qEvfx/6pGRyviCikP9qXdbL0gsPDFIOdKrkicnxlX1f tmrFytwwx6iCtkaNuE0GO9O5P4qc8Hz8npExfIISS3FGoqEWc1FxIgAdWIjEqQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2016 11:23 AM, Randy Li wrote: > The 8792f7772f4f40ffc68bad5f28311205584b734d would just make those > platform using rtc core from exynos3250 work but have a huge > effect on those platforms using the rtc core from s3c6410. > These patches would fix this problem. > Which problem? What huge effect? On which platforms? You didn't describe it... Your change breaks the ABI and is not compatible with current bindings documentation. Best regards, Krzysztof > Randy Li (3): > Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" > rtc: s3c: add device data for samsung,exynos3250-rtc > ARM: dts: exynos: correct the rtc compatible value for exynos5 > > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > arch/arm/boot/dts/exynos5.dtsi | 2 +- > drivers/rtc/rtc-s3c.c | 15 +++++++++++++-- > 3 files changed, 15 insertions(+), 4 deletions(-) >