From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Randy Li <ayaka@soulik.info>
Cc: alexandre.belloni@free-electrons.com, a.zummo@towertech.it,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data"
Date: Mon, 11 Jul 2016 07:48:29 +0200 [thread overview]
Message-ID: <5783332D.7010809@samsung.com> (raw)
In-Reply-To: <1468056226-19128-2-git-send-email-ayaka@soulik.info>
On 07/09/2016 11:23 AM, Randy Li wrote:
> This reverts commit 8792f7772f4f40ffc68bad5f28311205584b734d.
> The s3c6410 rtc don't use rtc_src property, that property is designed
> for Exynos5250 and Exynos5440. The problem reported in the commit
> I mentioned should be fixed in the other way.
... so you break in this commit all the newer platforms because the
rtc_src clock won't be enabled.
Does not look right.
Best regards,
Krzysztof
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
> drivers/rtc/rtc-s3c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index d01ad7e..5dc18ca 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -801,7 +801,6 @@ static struct s3c_rtc_data const s3c2443_rtc_data = {
>
> static struct s3c_rtc_data const s3c6410_rtc_data = {
> .max_user_freq = 32768,
> - .needs_src_clk = true,
> .irq_handler = s3c6410_rtc_irq,
> .set_freq = s3c6410_rtc_setfreq,
> .enable_tick = s3c6410_rtc_enable_tick,
>
next prev parent reply other threads:[~2016-07-11 5:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 9:23 [PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work Randy Li
2016-07-09 9:23 ` [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" Randy Li
2016-07-11 5:48 ` Krzysztof Kozlowski [this message]
2016-07-09 9:23 ` [PATCH 2/3] rtc: s3c: add device data for samsung,exynos3250-rtc Randy Li
2016-07-11 5:49 ` Krzysztof Kozlowski
2016-07-09 9:23 ` [PATCH 3/3] ARM: dts: exynos: correct the rtc compatible value for exynos5 Randy Li
2016-07-11 5:52 ` Krzysztof Kozlowski
2016-07-11 5:46 ` [PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5783332D.7010809@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=ayaka@soulik.info \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox