From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757797AbcGKFt7 (ORCPT ); Mon, 11 Jul 2016 01:49:59 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:18781 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbcGKFt5 (ORCPT ); Mon, 11 Jul 2016 01:49:57 -0400 X-AuditID: cbfec7f5-f792a6d000001302-a6-578333838b38 Subject: Re: [PATCH 2/3] rtc: s3c: add device data for samsung,exynos3250-rtc To: Randy Li References: <1468056226-19128-1-git-send-email-ayaka@soulik.info> <1468056226-19128-3-git-send-email-ayaka@soulik.info> Cc: alexandre.belloni@free-electrons.com, a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <57833381.7050503@samsung.com> Date: Mon, 11 Jul 2016 07:49:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1468056226-19128-3-git-send-email-ayaka@soulik.info> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e/4Nd1m4+Zwgx/b2S2WXLzKbtFxbTGT xau7vxgt5h85x2rx+oWhxabH11gtLu+aw2Yx4/w+JotDU/cyWiy9fpHJonXvEXaL/Z0djA48 HmvmrWH0uHztIrPHk00XGT32TDzJ5rFpVSebx+Yl9R59W1YxejTfnc7qMX3eTyaPz5vkArii uGxSUnMyy1KL9O0SuDK2bJjLXLCNt+LA1AamBsZHXF2MnBwSAiYSX77fZIWwxSQu3FvP1sXI xSEksJRR4vXBU6wQzjNGidm/9oBVCQv4SszqfcUMYosIKEgsX7CdCcQWEqiU6Ow6D9bALLCE SeLPzU6wIjYBY4nNy5ewgdi8AloS23beZuxi5OBgEVCVOHQiCyQsKhAhMWv7DyaIEkGJH5Pv sYDYnAJOEtO69rCDlDML6Encv6gFEmYWkJfYvOYt8wRGgVlIOmYhVM1CUrWAkXkVo2hqaXJB cVJ6rpFecWJucWleul5yfu4mRkgMfd3BuPSY1SFGAQ5GJR7egO1N4UKsiWXFlbmHGCU4mJVE eI/KN4cL8aYkVlalFuXHF5XmpBYfYpTmYFES5525632IkEB6YklqdmpqQWoRTJaJg1OqgXHJ 3ePTVVyeZnnOTV3AofJ++iqWz08T3CeFbHjF2mg6v5tT7NX5vHvLhWZMmmbHdX1fxM2+y3fW 23g8OrWrr+6Fy9pXhfwT6grmdZlwcYmfFl147FpLYfO+TtaNi9+3nV5ac6jy345pPmWf5UQv Rs15sDm1Nq31z+bjAZfmznuxeKeQaPGux3+blViKMxINtZiLihMBa83xq50CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2016 11:23 AM, Randy Li wrote: > The device data for samsung,exynos3250-rtc and samsung,s3c6410-rtc > are just have a difference, but keeping using the same device data > would cause the platform using the other IP core not work. I cannot understand what you wanted to say here. Please rephrase it. Why not just reverting a42e6eae457837d6a5925f4926f5ba05ccf44f89? Best regards, Krzysztof > > Signed-off-by: Randy Li > --- > drivers/rtc/rtc-s3c.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index 5dc18ca..e9f6151 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -810,6 +810,18 @@ static struct s3c_rtc_data const s3c6410_rtc_data = { > .disable = s3c6410_rtc_disable, > }; > > +static struct s3c_rtc_data const exynos3250_rtc_data = { > + .max_user_freq = 32768, > + .needs_src_clk = true, > + .irq_handler = s3c6410_rtc_irq, > + .set_freq = s3c6410_rtc_setfreq, > + .enable_tick = s3c6410_rtc_enable_tick, > + .save_tick_cnt = s3c6410_rtc_save_tick_cnt, > + .restore_tick_cnt = s3c6410_rtc_restore_tick_cnt, > + .enable = s3c24xx_rtc_enable, > + .disable = s3c6410_rtc_disable, > +}; > + > static const struct of_device_id s3c_rtc_dt_match[] = { > { > .compatible = "samsung,s3c2410-rtc", > @@ -825,7 +837,7 @@ static const struct of_device_id s3c_rtc_dt_match[] = { > .data = (void *)&s3c6410_rtc_data, > }, { > .compatible = "samsung,exynos3250-rtc", > - .data = (void *)&s3c6410_rtc_data, > + .data = (void *)&exynos3250_rtc_data, > }, > { /* sentinel */ }, > }; >