From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Randy Li <ayaka@soulik.info>
Cc: alexandre.belloni@free-electrons.com, a.zummo@towertech.it,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: exynos: correct the rtc compatible value for exynos5
Date: Mon, 11 Jul 2016 07:52:31 +0200 [thread overview]
Message-ID: <5783341F.1030006@samsung.com> (raw)
In-Reply-To: <1468056226-19128-4-git-send-email-ayaka@soulik.info>
On 07/09/2016 11:23 AM, Randy Li wrote:
> Those platforms are reported to use the same rtc IP core
> as exynos3250's.
Insufficient. Exynos4 also has to be updated. Actually all SoC from SoC
family requires rtc src clock. I think S3C6410 also requires it but I
don't have all the data necessary to confirm this.
Best regards,
Krzysztof
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 2 +-
> arch/arm/boot/dts/exynos5.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index 62f3dcd..cdd69a0 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -208,7 +208,7 @@
> };
>
> rtc: rtc@10070000 {
> - compatible = "samsung,s3c6410-rtc";
> + compatible = "samsung,exynos3250-rtc";
> reg = <0x10070000 0x100>;
> interrupts = <0 73 0>, <0 74 0>;
> interrupt-parent = <&pmu_system_controller>;
> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
> index d5c0f18..71a1ad2 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -88,7 +88,7 @@
> };
>
> rtc: rtc@101E0000 {
> - compatible = "samsung,s3c6410-rtc";
> + compatible = "samsung,exynos3250-rtc";
> reg = <0x101E0000 0x100>;
> interrupts = <0 43 0>, <0 44 0>;
> status = "disabled";
>
next prev parent reply other threads:[~2016-07-11 5:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 9:23 [PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work Randy Li
2016-07-09 9:23 ` [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" Randy Li
2016-07-11 5:48 ` Krzysztof Kozlowski
2016-07-09 9:23 ` [PATCH 2/3] rtc: s3c: add device data for samsung,exynos3250-rtc Randy Li
2016-07-11 5:49 ` Krzysztof Kozlowski
2016-07-09 9:23 ` [PATCH 3/3] ARM: dts: exynos: correct the rtc compatible value for exynos5 Randy Li
2016-07-11 5:52 ` Krzysztof Kozlowski [this message]
2016-07-11 5:46 ` [PATCH 0/3] making rtc cores from s3c6410 and exynos3250 both work Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5783341F.1030006@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=ayaka@soulik.info \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox