From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757791AbcGKFwi (ORCPT ); Mon, 11 Jul 2016 01:52:38 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:25707 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbcGKFwg (ORCPT ); Mon, 11 Jul 2016 01:52:36 -0400 X-AuditID: cbfec7f4-f796c6d000001486-93-57833420f0aa Subject: Re: [PATCH 3/3] ARM: dts: exynos: correct the rtc compatible value for exynos5 To: Randy Li References: <1468056226-19128-1-git-send-email-ayaka@soulik.info> <1468056226-19128-4-git-send-email-ayaka@soulik.info> Cc: alexandre.belloni@free-electrons.com, a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5783341F.1030006@samsung.com> Date: Mon, 11 Jul 2016 07:52:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1468056226-19128-4-git-send-email-ayaka@soulik.info> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e/4ZV0Fk+Zwg5WrFS2WXLzKbtFxbTGT xau7vxgt5h85x2rx+oWhxabH11gtLu+aw2Yx4/w+JotDU/cyWiy9fpHJonXvEXaL/Z0djA48 HmvmrWH0uHztIrPHk00XGT32TDzJ5rFpVSebx+Yl9R59W1YxejTfnc7qMX3eTyaPz5vkArii uGxSUnMyy1KL9O0SuDIeXFrBXHCcu+Lyh29sDYzzOLsYOTkkBEwkNt5YywZhi0lcuLceyObi EBJYyijReXwyC4TzjFFi1qq7TCBVwgKREouWz2IGsUUEFCSWL9gOFhcSqJQ49n4uK0gDs8AS Jok/NzvBitgEjCU2L18CtoJXQEvi3c0FYHEWAVWJ4+23GUFsUYEIiVnbfzBB1AhK/Jh8jwXE 5hRwkri88xiQzQE0VE/i/kUtkDCzgLzE5jVvmScwCsxC0jELoWoWkqoFjMyrGEVTS5MLipPS cw31ihNzi0vz0vWS83M3MUKi6MsOxsXHrA4xCnAwKvHwBm5vChdiTSwrrsw9xCjBwawkwltk 1BwuxJuSWFmVWpQfX1Sak1p8iFGag0VJnHfurvchQgLpiSWp2ampBalFMFkmDk6pBkaH9haO nPbkM38us+45+WzezU9dOQZ5DE8+HHVYvlE5b8ukjoSIAuHwfPHdzNGPqno7fsR116ssWD/Z 6oeq/bMVttrL/aebHX9jXzWB8/6sd/Hr7vCVRHNXCZjeKVmhU71HYsuhxPONH9cemiAufFt3 qpnR8hrjY8neNjVKL9hnuHx5zCNz4YASS3FGoqEWc1FxIgAC/LABngIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2016 11:23 AM, Randy Li wrote: > Those platforms are reported to use the same rtc IP core > as exynos3250's. Insufficient. Exynos4 also has to be updated. Actually all SoC from SoC family requires rtc src clock. I think S3C6410 also requires it but I don't have all the data necessary to confirm this. Best regards, Krzysztof > > Signed-off-by: Randy Li > --- > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > arch/arm/boot/dts/exynos5.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 62f3dcd..cdd69a0 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -208,7 +208,7 @@ > }; > > rtc: rtc@10070000 { > - compatible = "samsung,s3c6410-rtc"; > + compatible = "samsung,exynos3250-rtc"; > reg = <0x10070000 0x100>; > interrupts = <0 73 0>, <0 74 0>; > interrupt-parent = <&pmu_system_controller>; > diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi > index d5c0f18..71a1ad2 100644 > --- a/arch/arm/boot/dts/exynos5.dtsi > +++ b/arch/arm/boot/dts/exynos5.dtsi > @@ -88,7 +88,7 @@ > }; > > rtc: rtc@101E0000 { > - compatible = "samsung,s3c6410-rtc"; > + compatible = "samsung,exynos3250-rtc"; > reg = <0x101E0000 0x100>; > interrupts = <0 43 0>, <0 44 0>; > status = "disabled"; >