From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933620AbcGKGUW (ORCPT ); Mon, 11 Jul 2016 02:20:22 -0400 Received: from regular1.263xmail.com ([211.150.99.132]:55016 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757508AbcGKGUS (ORCPT ); Mon, 11 Jul 2016 02:20:18 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: alsa-devel@alsa-project.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v6] ASoC: rockchip: Add machine driver for RK3399 GRU Boards To: Rob Herring References: <1466080858-29565-1-git-send-email-zhengxing@rock-chips.com> <20160620130812.GA24614@rob-hp-laptop> Cc: linux-rockchip@lists.infradead.org, dianders@chromium.org, heiko@sntech.de, smbarber@google.com, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org From: Xing Zheng Message-ID: <57833A91.7090109@rock-chips.com> Date: Mon, 11 Jul 2016 14:20:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160620130812.GA24614@rob-hp-laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, In your opinion, is there anything needs to be optimized in this patch? Thanks. On 2016年06月20日 21:08, Rob Herring wrote: > On Thu, Jun 16, 2016 at 08:40:58PM +0800, Xing Zheng wrote: >> Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219) >> on the RK3399 GRU boards, this patch can help us to support these codecs. >> >> Signed-off-by: Xing Zheng >> --- >> >> Changes in v6: >> - remove enable/disable dapm pins, and to switch codecs via user space >> - fix "Speaker" dapm route for max98357a >> - add SND_JACK_LINEOUT flag for da7219 jack detection >> >> Changes in v5: >> - fix the build warning for missing I2C/CLKDEV_LOOKUP dependency >> >> Changes in v4: >> - the compatible name needs to be based on a single reference design, >> and the name of the board is called "GRU" >> - use one i2sX card "rockchip,cpu = <&i2s0>" instead of array that is >> based on GRU >> - rename DOC to rockchip,rk3399-gru-sound.txt >> - rename compatible to rockchip,rk3399-gru-sound >> - rename source code to rk3399_gru_sound.c >> >> Changes in v3: >> - rename DOC to rockchip,rk3399-max98357a-rt5514-da7219.txt >> - rename compatible to rockchip,rk3399-max98357a-rt5514-da7219 >> - rename source code to rk3399_max98357a_rt5514_da7219.c >> >> Changes in v2: >> - use the FS 256 to set mclks of the max98357a and rt5514 danamically >> - add more sample rate for da7219 >> >> .../bindings/sound/rockchip,rk3399-gru-sound.txt | 15 + > Acked-by: Rob Herring > >> sound/soc/rockchip/Kconfig | 11 + >> sound/soc/rockchip/Makefile | 2 + >> sound/soc/rockchip/rk3399_gru_sound.c | 322 ++++++++++++++++++++ >> 4 files changed, 350 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt >> create mode 100644 sound/soc/rockchip/rk3399_gru_sound.c > > -- - Xing Zheng