From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758565AbcGKLAo (ORCPT ); Mon, 11 Jul 2016 07:00:44 -0400 Received: from mail-co1nam03on0080.outbound.protection.outlook.com ([104.47.40.80]:48086 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758280AbcGKLAl (ORCPT ); Mon, 11 Jul 2016 07:00:41 -0400 X-Greylist: delayed 3656 seconds by postgrey-1.27 at vger.kernel.org; Mon, 11 Jul 2016 07:00:41 EDT Authentication-Results: spf=pass (sender IP is 137.71.25.57) smtp.mailfrom=analog.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=analog.com; Reply-To: Subject: Re: [PATCH] backlight: adp5520: fix error handling in adp5520_bl_probe() References: <1468016392-6061-1-git-send-email-khoroshilov@ispras.ru> To: Alexey Khoroshilov CC: Jingoo Han , Lee Jones , , , From: Michael Hennerich Organization: Analog Devices Inc. Message-ID: <578349F8.2070207@analog.com> Date: Mon, 11 Jul 2016 09:25:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468016392-6061-1-git-send-email-khoroshilov@ispras.ru> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(199003)(24454002)(189002)(305945005)(7846002)(7636002)(87936001)(586003)(59896002)(106466001)(99136001)(4477795004)(65806001)(8936002)(47776003)(76176999)(6806005)(356003)(86362001)(80316001)(19580405001)(19580395003)(65956001)(2950100001)(83506001)(2906002)(3450700001)(2870700001)(189998001)(36756003)(110136002)(11100500001)(4326007)(8676002)(4001350100001)(23746002)(77096005)(65816999)(246002)(50466002)(64126003)(43066003)(33656002)(54356999)(87266999)(53806999)(50986999)(15760500001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR03MB2158;H:nwd2mta2.analog.com;FPR:;SPF:Pass;PTR:nwd2mail11.analog.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD043;1:5hLtQmJV+MJvruF0q6t4rvJ9GukIyMQsCdtifBBVuCj30NuLjz6wlFqw1fcO2+PlfuIcXSLIT4YO54y74zMEpdYY8Uvg0nhmRbBItwUF6leZow0g9CfNmcT8drpDolz41XFouzkOYJyda/fFg7FvZoRx74XPttqbSxpujlkYiiqxc0Yxupcig9ZSk0r9tFc38BPfv48qNvRBhs8ZLJ1+PFKpAgF8dFA4H5mZq+3cKZm/ODpZ+m4ZYu8XpqtjaBM6rhQi5dJQ3NuJSORg6vGfwjCU1QqHqLYO9TOwuvb3dU5IIYeb5h0WsoExT94PnMi5T+MnHJfmjeLe4whzgl2OEpJz+btJ6/eHeU7X19AMHwitmKZgciHbGshCfIbY5N+EhKF2MiZgs7ZcPp/FGHzMdeSrTDveJZZyagOdCZngdSbnPKkuw9kSF9zfPL7pcdokejpJx94xrbg8jncq21Z22nTmW4DY6+/bZr2vKcRjKAwpkaNfdJ0qMd6GKXmZ2GryjyDTcerpCwMT7hcVHYjmuiG6f59Qz6GPf2ih4lckxMuCaMY97IjKsiLJhcwbErkjVr6vFEkOy8Gnp45yCKeRlOetF7C8KHZtCN8/Yztwxec= X-MS-Office365-Filtering-Correlation-Id: eae6a2db-fad8-409d-df4a-08d3a95c9298 X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2158;2:ZqEMtsmsHEWzHLe1XYiQCFqGtFqyAQAMZG0lDZJ6PkJDJb7E3gneoVOFdks24qmQw251H77vmJ3gZ0cVZHyXFPjmo8AgJuwLIyUG6jfr8C98WOt1lFytN4Vxse1Qr+F8/yhnpoy9i9Wj6PbO/ciREkcxHF61cIObwgGSvtiP/co7l9+ZvVT7ivf1x9EKeLqX;3:7Q/eUlpKpYHotIT6AVPsO7NOHfoaEYPMNBkydkfhfd71bNpL+VkIQVATO6fVzcUiOQpHvHcRvpggXwnXmH7vgs1xdvKdXglpH+qvuoU+uCTeELlIPwmZJSb1Doz345Sx1NKLTa+V+B2CaOmgB4Q+ey3H82BdTl48yX8P+ZYTbHzQHQYVcgTp67zjdjHvbZ+kEKfCIB+hMwfu19KVsrzd2nTWzzHiqBwy67FlO3PxehEuikIAcpWtbmw3RTTD77RG7VOXuiHic0vjA3BY4IKeJA==;25:C0E0Wj1Bz2ILOI6a4LQve4nP3fPzV+jyLAYsP8l3JrPp8DTLP9onzGMsTLk9xU7Z+3taByrpJlSwsUkEYFat6/9XuyaK2tOVLOzTk2+RT22kHAnAnOd5275gQv6DoiDuocTu2fUpTp+YJqJfTvzyFB5CA7aCKlUgxRVZyKwGG5iowoCVJBbu6//LNeZP950AxHQauacSnEfM+lni9z84+LMstZLyl6q8vp28o1OaNdW1cA6zh0KMFBACX7nJUfrORLekDl3fDaMh+9rrSAyoprsOh8VC4ZtNR2jLUq4VvCXvLLYxGfMRwubdW7ZWGQDeA3TQmC4Nc/I9NJNE4welrm6xU6HOKmfxhaDXsk3W/W9mRuEloO3ZBv/7ftNe3bNmMHWYlMp8FBwDjl88ojz3l3AYuXe/+ySCQMfduuEVM4E= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN2PR03MB2158; X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2158;31:WK+vKQY00yJYKMRhFrT37Cpa+sYtnafMflFGbFTVrjAP4tFuDVO7JVadKO46DsHr9NYJfGBKeevNJqcownbVL2q+KAk2UKWQWoc532au6P20MV17/oCfc/rN2QmSX1fo3MHGYYpaMz46zeKErE9ZVPtBQR2M5dTPQugfre1ciYPs0/DPalCCEiODV8TePv+gis52oIR5cuFxTbZhMJRXEg==;20:WPittXZ5rS4FfRXsaI6oKYZNeAkN80j4Qo7TElxvxuzR1DFBusPsmqx0n7xS4wkkcKsNZruHD5IS0dIU80FsDqZY/ag+Ziap4+7YadFH1Lhj8lNUhViIWOp/NLBKVKJPXt0vJYT3fhuaqoAza/RXBqmcVs2i5zvbC65B/QeOxKoWsDLarSfJzL5tZr92XI9TE5oRVKMRXfi0ktytmMRVi17GnioXA7tpN2jc5x7W4QLgSKE11J2TsM24Mr1lMllhjES2iS2yg445k6q80pzjKl6Tl/SKMyaEwyit3ygYn+r23HMlCye0vtGs3iaoMKp6vu/SiW5oyAhfoyhzZwLUyk1ibgilEEPXeJEzP4Knq1NA23BG+UMdTmSjfj+NQEgixoVLuetleh57A8l4UF1uNAEWEw4xGkwtbkwva2v0ULK96vDZdzDJknB+XqkoNLncvsiAqr0nsa8TbgNG5hzZ6Mz2C146O9exJ0yq6vhPa0RvpPd4HqqeCnXkExtbCJ6d X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(232431446821674); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13024025)(13023025)(13017025)(13015025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:SN2PR03MB2158;BCL:0;PCL:0;RULEID:;SRVR:SN2PR03MB2158; X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2158;4:be9CVrnvJWZ4dJTbhoBNSL38NlE84/Z+RGA8RR1Q69sWVJPopH45AX5zWse+u/aGUkQs7J1uZN0QK/NydDNVLG9ETwF1cE4+P7PrKGw1lvNynbjD0kPbBLOcIEYNP9T46FtQn7urOdudAe4nRS4peuHFIHLuNU08ZVRkSalnC/dXH7RL8NqBJ+Z37IZED2KuHnoCPXT5etIhlQj5M7KZwSPpA4qb+Xu23LKj/UGE36kMg4x0ROGu8daq5g+LyctnhjPlvepsjejXwHxc6V6Hrp8ZzI1uSojlfRXv4fbgpFro7khWMwEy5h+i8jCJATINB4tdPV+4PzUgC9CjPXpwZn5GNcH7NlUlpbECNUXI3DPt+Sb/odkGBbVf4vkTlYAFjxT5ORCIglN40qnGDWg8WwO+qKqE4YM8qJhcwVM7wERd7ZlS6C0m3l+SFl3TM1mZgZPcaJB2MNxBUQkQMW5i3ADOqawx2rBoqrmVJX1E8nC4fRkIYcidb+ho0lFxkH92CRpQ9W2TRRosaxweSaw62Q== X-Forefront-PRVS: 00003DBFE7 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN2PR03MB2158;23:hqW1hBeZA31T1dIXprwI6/aXw1BQOLnpihriI?= =?Windows-1252?Q?hSViEWNdqXnqr1iYqFJQ/d10ziwqp6s+C7ayZPV7GjvTSONeX5wSkiJ7?= =?Windows-1252?Q?vWTxFaj4fhwU5oRj4B5gykwG3x9F4/Qlu/2U85MXRGikYIVPxb72vIrg?= =?Windows-1252?Q?z3Oymom+V3aKKGJetLmbav0/Fh1kMQoGkp2v/d0QKMQzh9XY2eMoiopx?= =?Windows-1252?Q?BI14p0UUGtqifcG/LWba2wJBAZOSKkynzE3Jg7LqBn8ymD3bC4cYytmZ?= =?Windows-1252?Q?ISK7rnhkjWDUDXIUa/wIcPAmkolBNbFL+PmfWPU7oQqCMaWoP/gAJFQB?= =?Windows-1252?Q?cHOsiDgBVjBnOEYsSyUUcIrHwJXYhkCnMzk1D0Mq9N53WvpGZYx23aEH?= =?Windows-1252?Q?x5xCohzDnQhMkEvA/zD7wXBgYJGuaF6VTrg4Vo7Eh//snFwq0ttkIUU4?= =?Windows-1252?Q?NU0RmN1lzw1W5jLQMNE886pEN5vDoBL6rnNkznDtJaTaSNHjgftXW7j0?= =?Windows-1252?Q?bpM9GhilpJ8lSJKlO0QcoES8sCBu2HRVWUmomKECFeJ+zRf1ij4f92Xw?= =?Windows-1252?Q?HYLc+RkkzEZbk+YL2qupd8cLEMYzODpMOUSBgj+utWPB5GiplIQtU6dA?= =?Windows-1252?Q?2fdwzAqGegWbcQCSR1Qq/96j3k1w+ES1PPtzNvKd+ORWOyxa1SG05d56?= =?Windows-1252?Q?i6FAWcjay2YTM8V6oTIc4NMJ4ig8/s9XZeBFwLKk+WnoAeXbpnK2f843?= =?Windows-1252?Q?Um+r0QwEhCVF6Gc4NLbi9beh/dVuxfye7d+kYVS97u+l9OVA1OhUBAAP?= =?Windows-1252?Q?IwEGa81QSiQUvntJIBFwxXUkGXzzF9dOzi80OnSFiZdnqYf3uPc6t8Ws?= =?Windows-1252?Q?wnbAFWMNB5IoyXol8VMhYchoYUpPzJ/6IvCSqzXACTMhomkVO58yJjTe?= =?Windows-1252?Q?Y8iTAWeULJgCQKPY7jehL75ZamPXgTjB/t7LO7Da3JsgRu/38sDrFwJg?= =?Windows-1252?Q?vBEPaUqtGa7v6e03QdK5ScTcHdA2zeyHD20QizLV9AjRv3aMyiqb2BeM?= =?Windows-1252?Q?XOgeuoiH06eP3PMfpCKlxqtKPEMMwQvd9ugrwIPfHvjL4IMA4KLoKtA+?= =?Windows-1252?Q?eoUh1AwO9fyXXP/NGamqfKT4AzUNVfzMWwigHwpm+AepF5/hErbSKgl/?= =?Windows-1252?Q?m/ebtJzzFJUHL2QtAWGlt8Md5YxDjTw5y2sCV0EjsjZZuhFOdwQL7YO2?= =?Windows-1252?Q?Vnl3OHnzKeg2j86IkyvWfZ30J/2eakBEQ5uWbuHsEOs+6tZhMxvH/dtx?= =?Windows-1252?Q?Oe5pmVIfuujzwTwljEfcsLG/Ru672NQ/GLiD1akP5Pgmfo=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR03MB2158;6:YR9dRtRyk2QCu9+2LnEn6BMgceM6bvi4NLaUttzbkljG2j6LXvfo8jXVHdiBPYgbBGVqGHC1NPsQ2eWZLOpZm0jChwS6AWFHBLFYE73sPQ3Sw9CxzoiPU/DNr5PWBsas3T2xac9Bq6olKbB9vYIGoUqqlgrPnQSulIwXemyYuY+fEaWhzePnetHY+UcXRWVIE3AvzicHtFbCCutC4mSALsaoOHfmMe27Fw3MIAUaSAQh+fAaFdeZgBLcJ54tYojI7xgSiMPrB6NYQKY0etx6LHE8W5pEgVy/HFXuXfkuTym5rYq+vnmM978+o/QTx7v72uNPtPXDtV6d+nq19cVZ7w==;5:AC9eorAl5zW/Ds9urWkuhO9nCrnh5tp5ddrkgSnYyzse6xnSese5ZTlqdYcwnb/PU8vscyLDbC1vAOo92DmUy+X91XbjkJX3sL7CXUolY9pdyOMaApEXE9ThZ/iJvur2nSUJt/tGtPYr30scCM9aQw==;24:otuQlr1kNAwQ4/kugCxZmKK5+ohyZThejbOivdFLZ5q8biRNL7AJRDFNm4JdDaCWEHWjEk95oJlpCKMG8ZkIYKUPLbGvZLaIh3sayQuMk5g=;7:uWa66AaQ5IeaUXRy5zl7qLCYLPXB57PL9eLhpppMrDIkZGWXGCya4/7gS7ujrU8JQV567o/OHbhlAMo/B4CeE+nfUmDB1c8ivxYgWt0QoP8n+KBatyKRMn2HL3VA2o9rM9ujOXSxJbl7QSZ8vburPHycHks63Wxq7ow525d0X+jpBbLMFdpP3VShSOTqsGpyVhqF4xFyvSOhNrlWOZpKFe7BuE+RJgTivxaPm8tQUIXuljhgQPvI0cp2b/kAkckz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2016 07:25:44.9857 (UTC) X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.07.2016 00:19, Alexey Khoroshilov wrote: > If adp5520_bl_setup() fails, sysfs group left unremoved. > > By the way, fix overcomplicated assignement of error code. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Acked-by: Michael Hennerich > --- > drivers/video/backlight/adp5520_bl.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/adp5520_bl.c b/drivers/video/backlight/adp5520_bl.c > index dd88ba1d71ce..35373e2065b2 100644 > --- a/drivers/video/backlight/adp5520_bl.c > +++ b/drivers/video/backlight/adp5520_bl.c > @@ -332,10 +332,18 @@ static int adp5520_bl_probe(struct platform_device *pdev) > } > > platform_set_drvdata(pdev, bl); > - ret |= adp5520_bl_setup(bl); > + ret = adp5520_bl_setup(bl); > + if (ret) { > + dev_err(&pdev->dev, "failed to setup\n"); > + if (data->pdata->en_ambl_sens) > + sysfs_remove_group(&bl->dev.kobj, > + &adp5520_bl_attr_group); > + return ret; > + } > + > backlight_update_status(bl); > > - return ret; > + return 0; > } > > static int adp5520_bl_remove(struct platform_device *pdev) > -- Greetings, Michael -- Analog Devices GmbH Otl-Aicher Strasse 60-64 80807 München Sitz der Gesellschaft München, Registergericht München HRB 40368, Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne