Re: [PATCH] leds: leds-gpio: Set of_node for created LED devices

Jacek Anaszewski
2016-07-11T08:20:23Z

On 07/11/2016 09:52 AM, Rafał Miłecki wrote:
> On 07/11/2016 09:34 AM, Jacek Anaszewski wrote:
>> On 07/08/2016 02:53 PM, Rafał Miłecki wrote:
>>> When working with Device Tree we iterate over children of "gpio-leds"
>>> compatible node and create LED device for each of them. We take care of
>>> all common DT properties (label, default trigger, state, etc.), however
>>> some triggers may want to support more of them.
>>>
>>> It could be useful for timer trigger to support setting delay on/off
>>> values with Device Tree property. Or for transient trigger to support
>>> e.g. duration property.
>>>
>>> We obviously should handle such properties in triggers, not in generic
>>> code. To let trigger drivers read properties from DT node we need to set
>>> of_node to point the relevant node. This change allows using all kind of
>>> of helpers in e.g. "activate" callbacks.
>>>
>>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>>> ---
>>> drivers/leds/leds-gpio.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
>>> index 8229f06..9b991d4 100644
>>> --- a/drivers/leds/leds-gpio.c
>>> +++ b/drivers/leds/leds-gpio.c
>>> @@ -165,6 +165,7 @@ static struct gpio_leds_priv
>>> *gpio_leds_create(struct platform_device *pdev)
>>> return ERR_PTR(-ENOMEM);
>>>
>>> device_for_each_child_node(dev, child) {
>>> + struct gpio_led_data *led_dat = &priv->leds[priv->num_leds];
>>
>> This seems to be an unrelated change.
>
> We already got
> &priv->leds[priv->num_leds]
> and I needed to add
> priv->leds[priv->num_leds].cdev.dev->of_node
>
> I didn't want to duplicate code accessing so deep struct, so I added a
> helper.
>
> Is that a good explanation? Or would you like me to change this code?

Ah, I missed that. Patch applied.

Thanks,
Jacek Anaszewski