From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758088AbcGKHw2 (ORCPT ); Mon, 11 Jul 2016 03:52:28 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36002 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753208AbcGKHw0 (ORCPT ); Mon, 11 Jul 2016 03:52:26 -0400 Subject: Re: [PATCH] leds: leds-gpio: Set of_node for created LED devices To: Jacek Anaszewski References: <1467982420-15718-1-git-send-email-zajec5@gmail.com> <57834C06.4020506@samsung.com> Cc: Richard Purdie , "open list:LED SUBSYSTEM" , open list From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: <57835036.2090902@gmail.com> Date: Mon, 11 Jul 2016 09:52:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <57834C06.4020506@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2016 09:34 AM, Jacek Anaszewski wrote: > On 07/08/2016 02:53 PM, Rafał Miłecki wrote: >> When working with Device Tree we iterate over children of "gpio-leds" >> compatible node and create LED device for each of them. We take care of >> all common DT properties (label, default trigger, state, etc.), however >> some triggers may want to support more of them. >> >> It could be useful for timer trigger to support setting delay on/off >> values with Device Tree property. Or for transient trigger to support >> e.g. duration property. >> >> We obviously should handle such properties in triggers, not in generic >> code. To let trigger drivers read properties from DT node we need to set >> of_node to point the relevant node. This change allows using all kind of >> of helpers in e.g. "activate" callbacks. >> >> Signed-off-by: Rafał Miłecki >> --- >> drivers/leds/leds-gpio.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c >> index 8229f06..9b991d4 100644 >> --- a/drivers/leds/leds-gpio.c >> +++ b/drivers/leds/leds-gpio.c >> @@ -165,6 +165,7 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev) >> return ERR_PTR(-ENOMEM); >> >> device_for_each_child_node(dev, child) { >> + struct gpio_led_data *led_dat = &priv->leds[priv->num_leds]; > > This seems to be an unrelated change. We already got &priv->leds[priv->num_leds] and I needed to add priv->leds[priv->num_leds].cdev.dev->of_node I didn't want to duplicate code accessing so deep struct, so I added a helper. Is that a good explanation? Or would you like me to change this code?