From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030452AbcGKIUX (ORCPT ); Mon, 11 Jul 2016 04:20:23 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:56618 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757892AbcGKIUS (ORCPT ); Mon, 11 Jul 2016 04:20:18 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed X-AuditID: cbfec7f4-f796c6d000001486-ff-578356bec0f3 Content-transfer-encoding: 8BIT Message-id: <578356BD.8000309@samsung.com> Date: Mon, 11 Jul 2016 10:20:13 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Richard Purdie , "open list:LED SUBSYSTEM" , open list Subject: Re: [PATCH] leds: leds-gpio: Set of_node for created LED devices References: <1467982420-15718-1-git-send-email-zajec5@gmail.com> <57834C06.4020506@samsung.com> <57835036.2090902@gmail.com> In-reply-to: <57835036.2090902@gmail.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPLMWRmVeSWpSXmKPExsVy+t/xq7r7wprDDbb/1be4vGsOm8XWN+sY LXbvespqseZkqgOLx85Zd9k99sz/werxeZNcAHMUl01Kak5mWWqRvl0CV8aar/dZC1r4K7Zf W8/YwDiXp4uRk0NCwETi2Y82JghbTOLCvfVsXYxcHEICSxklJq69xwKS4BUQlPgxGcTm4GAW kJc4cikbJMwsYCbxqGUdM0T9M0aJFfMfMEHUa0kc+7+AEcRmEVCV2Hx0EzOIzSZgKPHzxWuw GlGBCIk/p/exgtgiAuYST/oeMUEM7WGU2PSJG8QWFvCUOPz3H9gcIYE6iVd/TjGB3MApoClx d5PXBEaBWUium4Vw3Swk1y1gZF7FKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERKsX3YwLj5m dYhRgINRiYc3cHtTuBBrYllxZe4hRgkOZiUR3oTg5nAh3pTEyqrUovz4otKc1OJDjNIcLEri vHN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MDZyXD3wu1tB5kbntYsnps1PFz9YVVl2ubJ8c8z7 joj5Hx9/9DnYv039uPPMz8XXXO5pf99gssHb9cLqvY9Nn9dXdorJtYnNnsnFF3vS6eS8rErr PoHt/xbKrps0s8NYpFBLY8L6jzOF30wQlbq3Ys+vl4EViXb39vIndrmd0OrpKuBfkHTn9w0l luKMREMt5qLiRADovJM0UgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2016 09:52 AM, Rafał Miłecki wrote: > On 07/11/2016 09:34 AM, Jacek Anaszewski wrote: >> On 07/08/2016 02:53 PM, Rafał Miłecki wrote: >>> When working with Device Tree we iterate over children of "gpio-leds" >>> compatible node and create LED device for each of them. We take care of >>> all common DT properties (label, default trigger, state, etc.), however >>> some triggers may want to support more of them. >>> >>> It could be useful for timer trigger to support setting delay on/off >>> values with Device Tree property. Or for transient trigger to support >>> e.g. duration property. >>> >>> We obviously should handle such properties in triggers, not in generic >>> code. To let trigger drivers read properties from DT node we need to set >>> of_node to point the relevant node. This change allows using all kind of >>> of helpers in e.g. "activate" callbacks. >>> >>> Signed-off-by: Rafał Miłecki >>> --- >>> drivers/leds/leds-gpio.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c >>> index 8229f06..9b991d4 100644 >>> --- a/drivers/leds/leds-gpio.c >>> +++ b/drivers/leds/leds-gpio.c >>> @@ -165,6 +165,7 @@ static struct gpio_leds_priv >>> *gpio_leds_create(struct platform_device *pdev) >>> return ERR_PTR(-ENOMEM); >>> >>> device_for_each_child_node(dev, child) { >>> + struct gpio_led_data *led_dat = &priv->leds[priv->num_leds]; >> >> This seems to be an unrelated change. > > We already got > &priv->leds[priv->num_leds] > and I needed to add > priv->leds[priv->num_leds].cdev.dev->of_node > > I didn't want to duplicate code accessing so deep struct, so I added a > helper. > > Is that a good explanation? Or would you like me to change this code? Ah, I missed that. Patch applied. Thanks, Jacek Anaszewski