From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030671AbcGKLvT (ORCPT ); Mon, 11 Jul 2016 07:51:19 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33702 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932166AbcGKLvS (ORCPT ); Mon, 11 Jul 2016 07:51:18 -0400 Reply-To: alex.popov@linux.com Subject: Re: [PATCH 1/1] irqdomain: Fix irq_domain_alloc_irqs_recursive() error handling References: <1467505448-2850-1-git-send-email-alex.popov@linux.com> To: Marc Zyngier , Thomas Gleixner , linux-kernel@vger.kernel.org, Alexander Popov From: Alexander Popov Message-ID: <578388B7.7080203@linux.com> Date: Mon, 11 Jul 2016 14:53:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1467505448-2850-1-git-send-email-alex.popov@linux.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.07.2016 03:24, Alexander Popov wrote: > If an irq_domain is auto-recursive and irq_domain_alloc_irqs_recursive() > for its parent has returned an error, then do return and avoid calling > irq_domain_free_irqs_recursive() uselessly, because: > - if domain->ops->alloc() had failed for an auto-recursive irq_domain, > then irq_domain_free_irqs_recursive() had already been called; > - if domain->ops->alloc() had failed for a not auto-recursive irq_domain, > then there is nothing to free at all. Hello. Could I have a feedback, please? Best regards, Alexander > Signed-off-by: Alexander Popov > --- > kernel/irq/irqdomain.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c > index 8798b6c..6458e34 100644 > --- a/kernel/irq/irqdomain.c > +++ b/kernel/irq/irqdomain.c > @@ -1144,8 +1144,10 @@ int irq_domain_alloc_irqs_recursive(struct irq_domain *domain, > if (recursive) > ret = irq_domain_alloc_irqs_recursive(parent, irq_base, > nr_irqs, arg); > - if (ret >= 0) > - ret = domain->ops->alloc(domain, irq_base, nr_irqs, arg); > + if (ret < 0) > + return ret; > + > + ret = domain->ops->alloc(domain, irq_base, nr_irqs, arg); > if (ret < 0 && recursive) > irq_domain_free_irqs_recursive(parent, irq_base, nr_irqs); > >