From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030519AbcGKOIO (ORCPT ); Mon, 11 Jul 2016 10:08:14 -0400 Received: from foss.arm.com ([217.140.101.70]:53103 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753610AbcGKOIK (ORCPT ); Mon, 11 Jul 2016 10:08:10 -0400 Subject: Re: [PATCH v2 1/6] iommu: add IOMMU_PRIV attribute To: Mitchel Humpherys , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Will Deacon , Marek Szyprowski References: <20160709020919.6760-1-mitchelh@codeaurora.org> <20160709020919.6760-2-mitchelh@codeaurora.org> Cc: Jordan Crouse , Jeremy Gebben , Patrick Daly , Pratik Patel From: Robin Murphy Message-ID: <5783A846.1050601@arm.com> Date: Mon, 11 Jul 2016 15:08:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160709020919.6760-2-mitchelh@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/16 03:09, Mitchel Humpherys wrote: > Add the IOMMU_PRIV attribute, which is used to indicate privileged > mappings. > > Signed-off-by: Mitchel Humpherys > --- > include/linux/iommu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 664683aedcce..01c9f2667f2b 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -31,6 +31,7 @@ > #define IOMMU_CACHE (1 << 2) /* DMA cache coherency */ > #define IOMMU_NOEXEC (1 << 3) > #define IOMMU_MMIO (1 << 4) /* e.g. things like MSI doorbells */ > +#define IOMMU_PRIV (1 << 5) I agree on the IOMMU_PRIV name, but can't help thinking it might be worth a brief comment to make it abundantly clear at a glance that it isn't "private" or "priority 5" or whatever ;) Robin. > struct iommu_ops; > struct iommu_group; >