From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752885AbcGLHO7 (ORCPT ); Tue, 12 Jul 2016 03:14:59 -0400 Received: from m199-177.yeah.net ([123.58.177.199]:12601 "EHLO m199-177.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbcGLHO5 (ORCPT ); Tue, 12 Jul 2016 03:14:57 -0400 Subject: Re: [PATCH v2 01/10] ARM: NUC900: Add nuc970 machine support To: Arnd Bergmann References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-2-git-send-email-vw@iommu.org> <18260150.aRRy8ybKlm@wuerfel> <57847278.8000408@iommu.org> Cc: devicetree@vger.kernel.org, jason@lakedaemon.net, Wan Zongshun , Daniel Lezcano , Russell King , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Wan Zongshun Message-ID: <578498E7.4080709@iommu.org> Date: Tue, 12 Jul 2016 15:14:47 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <57847278.8000408@iommu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQVZIVU1KSEtLS0pOT09CTklIQkhXWQkOFx4IWU FZKCs9JDU0NT4kMjUkMz46Pz4pQUtVS0A2IyQiPigkMjUkMz46Pz4pQUtVS0ArLykkNTQkMjUkMz 46Pz4pQUtVS0A4NC41LykiJDg1QUtVS0ApPjwyNDUkOigyOkFLVUtAKyk0LTI1OD4kKDM6NTwzOj JBS1VLQD8iNTo2MjgkMiskNTQkMjUkMz46Pz4pQUtVS0A2LjcvMiQpOCsvJD8yPT0#KT41LyQyNS QzPjo*PilBSVVLQDIrJC80PzoiJDg1LyRLJEpLS0FLVUtAMiskSiQ2MjUuLz4kODUvJEskSktBS1 VLQDIrJEhLJDYyNS4vPiQ4NS8kSyROS0FLVUtAMiskTiQ2MjUuLz4kODUvJEskSktBS1VLQDIrJE okMzQuKSQ4NS8kSyRKS0tBS1VLQCguOTE#OC8kLzQ*OiIkODUvJEskSktLQUtVS0AoLjkxPjgvJE okMzQuKSQ4NS8kSyRKS0tBS1VLQCguOTE#OC8kTiQ2MjUuLz4kODUvJEskSktBS1VLQCg5MSQ3Pj UkT0skI0FLVUtLSktALz4jLyQ3PjUkSklDSyQjQUtVS0tKS0A4NS8kMy82NyQ3PjUkSjAkTjBBS1 VLS0pLQCk#OD4yLT4pJDg1LyROJCNBS1VLS0pLQCM2OjI3PikkNS43N0FLVUtLSktAPz43Mi0#KS Q3PjUkS0FLVUtLSktANzo1PCQ4NUFLVUtLSktAPTUkNjoiJE9KQiQzNzEkSiRLQ0tIS09BS1VISE A9KyQpPiQ9LCQzNzEkS0NLSEtNQVZMVU5AKC45JD5BSlVOTlkG X-HM-Sender-Digest: e1kSHx4VD1lBWUc6Kzo6Hxw*ODouGDIzFiJPKzIhIzQaCwhVSlVKT01D SEtMTUNDSUJPVTMWGhIXVQ0MOxIUFhYOVRQJHEVZV1kMHhlZQR0aFwgeV1kIAVlBSEtCQjdXWRIL WUFZSUpLVUpIVUJMVUpNQ1kG X-HM-Tid: 0a55ddf54af8642782809110581b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年07月12日 12:30, Wan Zongshun wrote: > > > On 2016年07月12日 00:04, Arnd Bergmann wrote: >> On Sunday, July 10, 2016 3:27:21 PM CEST Wan Zongshun wrote: >>> +ifeq ($(CONFIG_SOC_NUC970),) >>> obj-y := irq.o time.o mfp.o gpio.o clock.o >>> obj-y += clksel.o dev.o cpu.o >>> +endif >>> # W90X900 CPU support files >> >> When mfp.o is disabled like this, I get a link error in two drivers >> using the exported interface: >> >> ERROR: "mfp_set_groupg" [drivers/spi/spi-nuc900.ko] undefined! >> ERROR: "mfp_set_groupi" [drivers/input/keyboard/w90p910_keypad.ko] >> undefined! > > Why remove mfp modules? this multifunction pin driver should be used for > those two drivers, if no mfp_set_groupX, I don't think driver can work. > > Now mfp has standard driver subsystem? > >> >> Any idea for a better migration strategy? Arnd, If you still think the mfp should be removed, we can send a series patches to instead of using mfp interface quickly, and do mfp set in local driver. Do you think it is ok? >> >> Arnd >> >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel