From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751341AbcGLHdI (ORCPT ); Tue, 12 Jul 2016 03:33:08 -0400 Received: from mr213138.mail.yeah.net ([223.252.213.138]:40058 "EHLO mr213138.mail.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbcGLHdG (ORCPT ); Tue, 12 Jul 2016 03:33:06 -0400 Subject: Re: [PATCH v2 03/10] Clocksource: add nuc970 clocksource driver To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Daniel Lezcano References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-4-git-send-email-vw@iommu.org> <3277576.eNgdG7zPqq@wuerfel> Cc: Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun From: Wan Zongshun Message-ID: <57849D2B.60305@iommu.org> Date: Tue, 12 Jul 2016 15:32:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <3277576.eNgdG7zPqq@wuerfel> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQVZIVU1KSEtLS0pOT09CTklIQkhXWQkOFx4IWU FZKCs9JDU0NT4kMjUkMz46Pz4pQUtVS0A2IyQiPigkMjUkMz46Pz4pQUtVS0ArLykkNTQkMjUkMz 46Pz4pQUtVS0A4NC41LykiJDg1QUtVS0ApPjwyNDUkOigyOkFLVUtAKyk0LTI1OD4kKDM6NTwzOj JBS1VLQD8iNTo2MjgkMiskNTQkMjUkMz46Pz4pQUtVS0A2LjcvMiQpOCsvJD8yPT0#KT41LyQyNS QzPjo*PilBSVVLQDIrJEhLJDYyNS4vPiQ4NS8kSyROS0FLVUtAMiskSiQ2MjUuLz4kODUvJEskSk tBS1VLQDIrJC80PzoiJDg1LyRLJEpLS0FLVUtAMiskTiQ2MjUuLz4kODUvJEskSktBS1VLQDIrJE okMzQuKSQ4NS8kSyRKS0tBS1VLQCguOTE#OC8kLzQ*OiIkODUvJEskSktLQUtVS0AoLjkxPjgvJE 4kNjI1Li8#JDg1LyRLJEpLQUtVS0AoLjkxPjgvJEokMzQuKSQ4NS8kSyRKS0tBS1VLQCg5MSQ3Pj UkT0skI0FLVUtLSktALz4jLyQ3PjUkSklDSyQjQUtVS0tKS0A4NS8kMy82NyQ3PjUkSjAkTjBBS1 VLS0pLQCk#OD4yLT4pJDg1LyROJCNBS1VLS0pLQCM2OjI3PikkNS43N0FLVUtLSktAPz43Mi0#KS Q3PjUkS0FLVUtLSktANzo1PCQ#NUFLVUtLSktAPTUkNjoiJE9KQiQzNzEkSiRLQ0tIS09BS1VISE A9KyQpPiQ9LCQzNzEkS0NLSEtNQVZMVU5AKC45JD5BSlVOTkA9NSQ2OiIkT0pCJDM3MSRJJEtDS0 hLT0FLVUtZBg++ X-HM-Sender-Digest: e1kSHx4VD1lBWUc6P0k6Eyo6ETohEDIVLB9DTx9LTy0aFD9VSlVKT01D SEtDTExCQ0hCVTMWGhIXVQ0MOxIUFhYOVRQJHEVZV1kMHhlZQR0aFwgeV1kIAVlBSE5JQzdXWRIL WUFZSUpLVUpIVUJMVUpNQ1kG X-HM-Tid: 0a55de05f2af7d8a210b3102300 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年07月11日 23:36, Arnd Bergmann wrote: > On Sunday, July 10, 2016 3:27:23 PM CEST Wan Zongshun wrote: >> >> +config NUC900_TIMER >> + bool "Clocksource timer for nuc900 platform" if COMPILE_TEST >> + depends on ARM >> + select CLKSRC_OF if OF >> + select CLKSRC_MMIO >> + help >> + Enables the clocksource for the NUC900 platform. >> > > I have put this patch into my randconfig build system and found that > it lacks a dependency: > > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index e18ef32776a3..59b9251eef37 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -523,7 +523,7 @@ config CLKSRC_ST_LPC > > config NUC900_TIMER > bool "Clocksource timer for nuc900 platform" if COMPILE_TEST > - depends on ARM > + depends on ARM && GENERIC_CLOCKEVENTS > select CLKSRC_OF if OF > select CLKSRC_MMIO > help > So this patch, I still need submit or you have merged it? > > Also the init function has changed its return type in linux-next: > >> +static void __init nuc970_timer_of_init(struct device_node *node) > > This now needs to return an error code or we get: > > ../include/linux/of.h:1004:20: error: comparison of distinct pointer types lacks a cast [-Werror] > .data = (fn == (fn_type)NULL) ? fn : fn } > > Daniel Lezcano seems to have implemented a migration strategy, but I > can't see what you are supposed to do here, since the > CLOCKSOURCE_OF_DECLARE_RET macro is no longer part of linux-next. Wait for Daniel's comments? or what should I do now? > > Arnd > >