From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753073AbcGLJGO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jul 2016 05:06:14 -0400
Received: from foss.arm.com ([217.140.101.70]:57611 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751588AbcGLJGL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jul 2016 05:06:11 -0400
Subject: Re: [PATCH] arm64: Add Broadcom Set Top Box Kconfig entry point
To: Markus Mayer <mmayer@broadcom.com>
References: <1467229774-20738-1-git-send-email-mmayer@broadcom.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Sudeep Holla <sudeep.holla@arm.com>,
        Doug Berger <opendmb@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
        ARM Kernel Mailing List 
	<linux-arm-kernel@lists.infradead.org>
From: Sudeep Holla <sudeep.holla@arm.com>
Organization: ARM
Message-ID: <5784B300.2000308@arm.com>
Date: Tue, 12 Jul 2016 10:06:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1467229774-20738-1-git-send-email-mmayer@broadcom.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 29/06/16 20:49, Markus Mayer wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
>
> Add an ARCH_BRCMSTB Kconfig symbol which allows us not to update the
> dependencies for all STB-related drivers. Select BRCMSTB_L2_IRQ and
> GENERIC_IRQ_CHIP which are required for proper functioning.
>
> Signed-off-by: Doug Berger <opendmb@gmail.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
>
>   arch/arm64/Kconfig.platforms | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 7ef1d05..22b5c7f 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -29,6 +29,13 @@ config ARCH_BERLIN
>   	help
>   	  This enables support for Marvell Berlin SoC Family
>
> +config ARCH_BRCMSTB
> +	bool "Broadcom Set-Top-Box SoCs"
> +	select BRCMSTB_L2_IRQ

I see that BRCMSTB_L2_IRQ selects GENERIC_IRQ_CHIP already so the below
one is redundant, generally irqchip code should select GENERIC_IRQ_CHIP

> +	select GENERIC_IRQ_CHIP
> +	help
> +	  This enables support for Broadcom's ARMv8 Set Top Box SoCs
> +
>   config ARCH_EXYNOS
>   	bool "ARMv8 based Samsung Exynos SoC family"
>   	select COMMON_CLK_SAMSUNG
>

-- 
Regards,
Sudeep