From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753765AbcGLKNU (ORCPT ); Tue, 12 Jul 2016 06:13:20 -0400 Received: from foss.arm.com ([217.140.101.70]:58034 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbcGLKNS (ORCPT ); Tue, 12 Jul 2016 06:13:18 -0400 Subject: Re: [PATCH] iommu: arm-smmu: drop devm_free_irq when driver detach To: Peng Fan , will.deacon@arm.com References: <1468287224-12036-1-git-send-email-van.freenix@gmail.com> Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Robin Murphy Message-ID: <5784C2BB.4000503@arm.com> Date: Tue, 12 Jul 2016 11:13:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468287224-12036-1-git-send-email-van.freenix@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/16 02:33, Peng Fan wrote: > There is no need to call devm_free_irq when driver detach. > devres_release_all which is called after 'drv->remove' will > release all managed resources. > > Signed-off-by: Peng Fan > Cc: Will Deacon > Cc: Robin Murphy drivers/iommu/arm-smmu.c: In function 'arm_smmu_device_remove': drivers/iommu/arm-smmu.c:2021:6: warning: unused variable 'i' [-Wunused-variable] int i; ^ With that addressed: Reviewed-by: Robin Murphy > --- > drivers/iommu/arm-smmu.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 860652e..5837391c 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2045,9 +2045,6 @@ static int arm_smmu_device_remove(struct platform_device *pdev) > if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS)) > dev_err(dev, "removing device with active domains!\n"); > > - for (i = 0; i < smmu->num_global_irqs; ++i) > - devm_free_irq(smmu->dev, smmu->irqs[i], smmu); > - > /* Turn the thing off */ > writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0); > return 0; >