From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933014AbcGLLdx (ORCPT ); Tue, 12 Jul 2016 07:33:53 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:50587 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932935AbcGLLdv (ORCPT ); Tue, 12 Jul 2016 07:33:51 -0400 Subject: Re: [PATCH] ata: hpt366: fix incorrect mask when checking at cmd_high_time To: Bartlomiej Zolnierkiewicz References: <1468322179-9398-1-git-send-email-colin.king@canonical.com> <2928643.x6ZsLjxZ9e@amdc1976> Cc: Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Sergei Shtylyov From: Colin Ian King Message-ID: <5784D578.9000702@canonical.com> Date: Tue, 12 Jul 2016 12:33:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <2928643.x6ZsLjxZ9e@amdc1976> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/16 12:27, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, July 12, 2016 12:16:19 PM Colin King wrote: >> From: Colin Ian King >> >> According to the HPT366 data sheet, PCI config space dword 0x40-0x43 >> bits 11:8 specify the primary drive cmd_high_time, however, >> currently just 3 bits of the 4 are being used because the mask >> is 0x700 and not 0x0f00. Fix the mask, allowing for the 40MHz clock >> to be detected. >> >> Signed-off-by: Colin Ian King > > Acked-by: Bartlomiej Zolnierkiewicz > > Thanks for the patch, could you also fix also the old driver > (drivers/ide/hpt366.c)? Yep, patch already sent. https://lkml.org/lkml/2016/7/12/199 > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > >> --- >> drivers/ata/pata_hpt366.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c >> index e5fb752..a219a50 100644 >> --- a/drivers/ata/pata_hpt366.c >> +++ b/drivers/ata/pata_hpt366.c >> @@ -368,7 +368,7 @@ static int hpt36x_init_one(struct pci_dev *dev, const struct pci_device_id *id) >> >> /* PCI clocking determines the ATA timing values to use */ >> /* info_hpt366 is safe against re-entry so we can scribble on it */ >> - switch ((reg1 & 0x700) >> 8) { >> + switch ((reg1 & 0xf00) >> 8) { >> case 9: >> hpriv = &hpt366_40; >> break; >