From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754682AbcGLO0e (ORCPT ); Tue, 12 Jul 2016 10:26:34 -0400 Received: from mail-db5eur01on0130.outbound.protection.outlook.com ([104.47.2.130]:28704 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754638AbcGLO0b (ORCPT ); Tue, 12 Jul 2016 10:26:31 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH] kasan: use \n with pr_emerg To: Vegard Nossum , Ingo Molnar References: <1468333008-21930-1-git-send-email-vegard.nossum@oracle.com> CC: From: Andrey Ryabinin Message-ID: <5784FE4E.3000404@virtuozzo.com> Date: Tue, 12 Jul 2016 17:27:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468333008-21930-1-git-send-email-vegard.nossum@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR01CA0031.eurprd01.prod.exchangelabs.com (10.164.74.169) To VI1PR0801MB1312.eurprd08.prod.outlook.com (10.167.197.150) X-MS-Office365-Filtering-Correlation-Id: 26ca83dc-c019-47da-d647-08d3aa608019 X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1312;2:jd05w+I2ShKNqqbOUKdUdQ5ItcC+6ixY6WfysrLwA6r53Ecwrj0zXUyHMvYy2yjy6Xfki9jK6LvFgQmf5ePyL7I/n+tGuSc/Vxd09oepK66qC5YI9pXn5r95evHXbbz44jjvo0J65sHjFDxYh6wX4d1obiJk7VEQ9xtZnP6MDSik8hOY3eihu3o6/g4jZUQt;3:LJhAHYiwcplqrTHTbsz3nmBEcJK4tSAzxWLkPEwir4kve29v21gMpZPe+Q6+RUhLC/pobYjbGyhwWqQRHB5MbrFGBVgpitXNKKLdYyNqr7MqqFrpbQcpdS6nRf5y8ihe X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1312; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1312;25:nxrl4p75CymeUnjX22ORRDMiJtlEKwUMQAihDrURMp4C0S2tNN1LRdmLyPAS1PuXeZNhzmo+GaVTFwEjbav0DCmz0muktBPtloWowUrYZIhxJnww/jXSCZfhj/lGnQaFeWAl49cSMFDuKmq0xszqR4SzPe+BcXK3pWKFsJXsJjhDY1NYUA+0hY3GaNOg5ERmH6/6wXFB6e3OK11mA4bQyXlwYfz6hzwwJ2KglVrgaKvSP4I3Iwwzs7MLLOptjdPqBXgiCoXq3l/NA5VRHtRjDfr0aOV6eX3r+uznC3RojR8uaP8Szj+ofhxSCcrNBuELEi3LkWhWBrovCuBDjY9ryOdJjmXWIPGP+hGx89BymfdwMJ0GqU4SZE+vpd3FHwYbYhBb+1Q68X+OsO7GEy8QcmQzqA2TlCZadXT9HW3EDm35PwgqtRNkX6u09zwA+ydXXQWEWsXwKKt1sqJhQfsKopO6t82A0v0DXFbaVLdNtqAhtvJ8OD3emg8bjbKugUvqHcFa45FndCn5+D4WFimk37xH0gLiCkHTykeQpCuTuzZXem7RwFxxPegQjdi6A2afkSURfrfGgNS79rye/aRqtAKXNvw2AQulRQ3Nf+okhrnTmOtd44afLJ29c4ybuAmTv7y2S6Q4elHLF5W/LiRE4cfnIGb5yUvPtvUNdn52er3fxiOLDgQrQ49uysZO9iR9PaeM080bLSb87vFwogd0PlWwYxSb6zMlKffg8MZMKfzS+q3zxOptjhL0EX0XY1j6GFJgx7TyCoq51kZrIoLrxwlME2sEdElNWHMLTxjKZxV8zB/79SsmyUL+sbPckK3VCI+cAlOHhQ1w4jR/VVWRqQ== X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1312;31:TNwEW2t779zijPBVQn5+ay4rywk2B2904Nwq/JY+o13lLTVMxbgjZe76lMhFeD0zaiN2mLTRjTWHpeXCI88T3TPFSkYdF9XTlu/T5IZkekPPR2hW+lKvaws2ixtlLMd3dTLMD9+SH0UG0edQF4fwSUiz2RbAWAw1f4gITO+ozJCvaLSQC+qF5oBzNDli7MkdHZphw7jao+DbLBgCe/Ss8A==;4:ulWecioAnUTX5kxQF+YFuOMuj+l7hlYQ9wNeUWIBNYDkf1k1Vgd01UaJJERv44dAPZ2xWOzUCGgazQotAYN3BbiISBZ6c4myXYdYOCuWxM2o+e1r+BlONTWcMhV4ed4bFjA5lgd5GVmnorP+HeaWPCNWWa1feC/ZlcR76urrnQ8IljukKBertwGTdkjuKZ2BtVTTUD8H0GopqOM8gDp8SKO7FzGJN+QT9pMpSsVTUbeQq9E9ObPzGS9aJS1tyftSKbvd2rUe0k3dF4H1rJarG2MFiAKjbWohrzrXtO7yKk14BZyBEqnpWIcBZjSbbWVyfCu7DJHZCUVvfebbPQBjgn13wVp+IIh8qr+8mQTnOfSQdZJx9KfSPfh8OhRQIdZ72+E4258dTJ4HBpQRIPAJp886Z19wiYpKaKh1Qi4zTY/OFTDdSd8H394RmRM0AEk1G7/twvtsljLInVf2Hf6FfzDb4+qzWsGdgfrJqeHdAeF6j9sddBxbpuXGyjZLTf65cm1w8HbQ4ktJF8jLnnS9EOp56RGRVx0pZ0wSa2EryO4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211936372134217)(42068640409301)(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:VI1PR0801MB1312;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1312; X-Forefront-PRVS: 0001227049 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377454003)(189002)(199003)(24454002)(5001770100001)(106356001)(36756003)(105586002)(230700001)(86362001)(8676002)(80316001)(7736002)(4001350100001)(42186005)(19580395003)(7846002)(305945005)(97736004)(64126003)(19580405001)(65816999)(76176999)(54356999)(87266999)(6116002)(50986999)(3846002)(33656002)(50466002)(68736007)(189998001)(23746002)(83506001)(2906002)(47776003)(59896002)(65806001)(65956001)(66066001)(101416001)(15975445007)(4326007)(81156014)(81166006)(2950100001)(586003)(77096005)(92566002)(460985005);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0801MB1312;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR0801MB1312;23:TlzRyAEJSw6tayqpE+fWtp/Nz7FWHmPzhP9?= =?Windows-1252?Q?8+IHOuWvkGXNc2aMa0vgM/PWKgTEGtqf9ZF5y5gk6sHg0K7h1mNIqTs+?= =?Windows-1252?Q?lK6VpzCYe+9Vj+npDVthUNKEgBYfXK4soGHUOw/1mu7sk/98I1lnlVUd?= =?Windows-1252?Q?24QotjWFWqNK/Z3vb87TTqt7DKKFXU7pRWMzp+cwcrSvyMb5mGRAXUlI?= =?Windows-1252?Q?vzgD3Pgb6hK9qAAsiuKxkTlHVEAXEmpTbKI2V6enXC5bcFtKt7dybMI/?= =?Windows-1252?Q?Ee0zf72uB/IZfS7tzBsQbiNkkLtBgfzGfg6bEYfO0CLQpPtanReQxAta?= =?Windows-1252?Q?NWGqazHI8Ca+3C7R92nsS9zegAqsmFrTk5jxzRoQWq1Dulqh9QSeWDJH?= =?Windows-1252?Q?Zvp/0WRfTh1uFJ4+vZ+cHTd5icdGZs9zB18lGd2Z6a5yoyIzAq7c0Gc5?= =?Windows-1252?Q?/CdEhJjlOcEMkgWJHCf2pY5dXkNGZnKkcm4t67tMSUjSNw94iLycI2Lo?= =?Windows-1252?Q?RDmJS0K2jc+EQkNEv1RTv1+LEJRW4PTPvUt/G5m2S6lqfhWCd/Uk6cnd?= =?Windows-1252?Q?f0uRi/cI1hMhtWTq39H6lDs7NNRPo0FMPSxfFZlNey2VpA19GRCeKoGm?= =?Windows-1252?Q?8XQNepcnz3RBbAO0L6RQTJboxAT9VxXvZrMz2wt/zzuYVJwayqAWFR4V?= =?Windows-1252?Q?n7D3BTosgaJbrW1o+8Ri9JKplaCCflrYeRxhbo27y9OollNKUtnznX3A?= =?Windows-1252?Q?HsNvL6i9+wFgdxzAU1Q09XGdOHA0Zash74buG2nByCa0YUP2/zvjEpHZ?= =?Windows-1252?Q?yFRTUJgMo3ZzWM7DbvxkO2byUWDjyqtqPqpoxh4ZdKIcXeQs5LSwdamZ?= =?Windows-1252?Q?oaZeiEZsfM0nKyZtD8BwwiF8pCRro88XFlJPYPNJXTiuf1bnriUEbtwO?= =?Windows-1252?Q?GHCaHBhP7IyC1JYLgEcmJE2OGSRcr2FeXZ1lhZAih8se+bpCkOOXTrQZ?= =?Windows-1252?Q?GNDuKwqZcIGu8hJy9aCaojWNEcVDAmBC8odCTw45lDb7d/wsWTD4K+jz?= =?Windows-1252?Q?rTLMsMxWr3u6LLoGUezUsBNbzEAIEDQ22linMfqxz6n5Q1ga2IQ/zise?= =?Windows-1252?Q?cgkLKeVJIWiQY+UA3piNIYSDTO7b0TnwFU1M7+LHilDykGQQQ+/vk2tt?= =?Windows-1252?Q?4WRLVJVzIwI5bBxv+i8u7V3wkp6zqTKE7TudXkm8payXwjpJf8U5Gx92?= =?Windows-1252?Q?nup7TdFM94Y79wRW4rcy2/2mu4ESHfCIbUWKhM4nDY63LoglERqAQzPv?= =?Windows-1252?Q?88kPcn6WLjrhb6YEQiLohYztzj7+FTF8MBwv13XNIaeQYsCNLwOkLgux?= =?Windows-1252?Q?DazmlaT+SzCxUMeLL+ibq1Ko1tSUGocc7j2K2QSYCLaQihRGnBBVRCwf?= =?Windows-1252?Q?By/7GD3xyEm+bwoNQc15k+GtyP2R2cqtHKxIM7s20ew=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1312;6:Zs8n0pU/sNybNYSGeJQCYDkBsd4WHiCSKpeEQpSXzQRiHwkrEIIF02zpEAdZvA3EqZBOhOnOffykE+9xL5XhmT39wP6sMPlYfkNyU/mxYwqYNFibTuI1rmup6sSLyDKQIFzfk0qTrgAqzzO1Ui9u/Rh9qOkwdkNbgI3FkY8YyXm7qnt4LGvLIhjqqVDUde2SIhGSF1agdsxX6MVPBid4iAb8SqjtUvOp79KfT5il+SPAXpPbalJV+itmltEvvbDyfqJqdHfKxwUaIECzK+MSFRHnzygj7lOTjbj3hooj/A/uRsPiAAezfYlLvuIJ2PzW;5:5D4QTXUHkERjZNkp9lyJidk8GQ+Ed6TDQuOMehRFYotRALHlMhVyb+oxfXLDpc6TKRe/Imq4Dj6Soy1z//jUFX3xm76dOgsovwdJ34ksEph16ChMwEB67+1YQraUtQZQmQ7E7Wp5Oph6BSqc+TArcg==;24:yNpWmRDMVkdLCwb/C0dgSajctPTqnU32ZFRTbUTBTREq6H6jCSMHqyl2zjLiE+82TG7GRFR9J8RTCXp1AKNMnu1d6gfLWlBLrX8XtwDJE/g=;7:jVtYcw9PlcGYBNnFIUOS4z3r3VULVkHuCd7lFKVC3/lenjEWf1epc26nl0eFf96gQxowFxi/sRtB9glICa9+QtgNHTVa7YrKzPQlR7xsWDuzM1YKa8bcTA7XkSQHCZhV5sUjYtRoXG8/Jnr7PiBzvfzlDjlRWaEosMG533f+NxtbgdS2Eltqz9mu0+XccF2pp5kKL3ogIR2PbYVNZXENbzOHndVAFsjYkKH6EnRAgYyoWI7MA1AhsjIk1MirKy5B SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1312;20:HCMYsUBPkgZDF/kR7mLRbmrTSxY2GI/UXNEecpW6QEFXtfdTWFTX5o1RLBzLKVfJpXEAwwSCwb/ZTRJUOxZ4WwJ8q3HjkuMIvvJK2fv0/zS8NTwKJb2BJXVi0VJVJdERuKQv9cGR1NafMDa6zqAk3+c3gRXMZ8X2EEkDWNOGi9I= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2016 14:26:22.7807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12/2016 05:16 PM, Vegard Nossum wrote: > I'm seeing this in the kernel log: > > kasan: CONFIG_KASAN_INLINE enabled > kasan: GPF could be caused by NULL-ptr deref or user memory accessgeneral protection fault: 0000 [#1] KASAN > CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc6 #1 > > We really ought to be using \n with pr_*() so the 'general protection > fault...' starts on a line of its own. With this patch it looks better: > > kasan: CONFIG_KASAN_INLINE enabled > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault: 0000 [#1] KASAN > CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc7+ #650 > Dmitry fixed that already: http://lkml.kernel.org/g/<1467294357-98002-1-git-send-email-dvyukov@google.com> > Cc: Andrey Ryabinin > Signed-off-by: Vegard Nossum > --- > arch/x86/mm/kasan_init_64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c > index 1b1110f..0493c17 100644 > --- a/arch/x86/mm/kasan_init_64.c > +++ b/arch/x86/mm/kasan_init_64.c > @@ -54,8 +54,8 @@ static int kasan_die_handler(struct notifier_block *self, > void *data) > { > if (val == DIE_GPF) { > - pr_emerg("CONFIG_KASAN_INLINE enabled"); > - pr_emerg("GPF could be caused by NULL-ptr deref or user memory access"); > + pr_emerg("CONFIG_KASAN_INLINE enabled\n"); > + pr_emerg("GPF could be caused by NULL-ptr deref or user memory access\n"); > } > return NOTIFY_OK; > } >