[PATCH] kasan: use \n with pr_emerg

[PATCH] kasan: use \n with pr_emerg

[Vegard Nossum]

I'm seeing this in the kernel log:

    kasan: CONFIG_KASAN_INLINE enabled
    kasan: GPF could be caused by NULL-ptr deref or user memory accessgeneral protection fault: 0000 [#1] KASAN
    CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc6 #1

We really ought to be using \n with pr_*() so the 'general protection
fault...' starts on a line of its own. With this patch it looks better:

    kasan: CONFIG_KASAN_INLINE enabled
    kasan: GPF could be caused by NULL-ptr deref or user memory access
    general protection fault: 0000 [#1] KASAN
    CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc7+ #650

Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
---
 arch/x86/mm/kasan_init_64.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c
index 1b1110f..0493c17 100644
--- a/arch/x86/mm/kasan_init_64.c
+++ b/arch/x86/mm/kasan_init_64.c
@@ -54,8 +54,8 @@ static int kasan_die_handler(struct notifier_block *self,
 			     void *data)
 {
 	if (val == DIE_GPF) {
-		pr_emerg("CONFIG_KASAN_INLINE enabled");
-		pr_emerg("GPF could be caused by NULL-ptr deref or user memory access");
+		pr_emerg("CONFIG_KASAN_INLINE enabled\n");
+		pr_emerg("GPF could be caused by NULL-ptr deref or user memory access\n");
 	}
 	return NOTIFY_OK;
 }
-- 
1.9.1

Re: [PATCH] kasan: use \n with pr_emerg

[Andrey Ryabinin]

On 07/12/2016 05:16 PM, Vegard Nossum wrote:
> I'm seeing this in the kernel log:
> 
>     kasan: CONFIG_KASAN_INLINE enabled
>     kasan: GPF could be caused by NULL-ptr deref or user memory accessgeneral protection fault: 0000 [#1] KASAN
>     CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc6 #1
> 
> We really ought to be using \n with pr_*() so the 'general protection
> fault...' starts on a line of its own. With this patch it looks better:
> 
>     kasan: CONFIG_KASAN_INLINE enabled
>     kasan: GPF could be caused by NULL-ptr deref or user memory access
>     general protection fault: 0000 [#1] KASAN
>     CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc7+ #650
> 

Dmitry fixed that already: http://lkml.kernel.org/g/<1467294357-98002-1-git-send-email-dvyukov@google.com>


> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> ---
>  arch/x86/mm/kasan_init_64.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c
> index 1b1110f..0493c17 100644
> --- a/arch/x86/mm/kasan_init_64.c
> +++ b/arch/x86/mm/kasan_init_64.c
> @@ -54,8 +54,8 @@ static int kasan_die_handler(struct notifier_block *self,
>  			     void *data)
>  {
>  	if (val == DIE_GPF) {
> -		pr_emerg("CONFIG_KASAN_INLINE enabled");
> -		pr_emerg("GPF could be caused by NULL-ptr deref or user memory access");
> +		pr_emerg("CONFIG_KASAN_INLINE enabled\n");
> +		pr_emerg("GPF could be caused by NULL-ptr deref or user memory access\n");
>  	}
>  	return NOTIFY_OK;
>  }
> 

Re: [PATCH] kasan: use \n with pr_emerg

[Vegard Nossum]

On 07/12/2016 04:27 PM, Andrey Ryabinin wrote:
> On 07/12/2016 05:16 PM, Vegard Nossum wrote:
>> We really ought to be using \n with pr_*() so the 'general protection
>> fault...' starts on a line of its own. With this patch it looks better:
>>
>>      kasan: CONFIG_KASAN_INLINE enabled
>>      kasan: GPF could be caused by NULL-ptr deref or user memory access
>>      general protection fault: 0000 [#1] KASAN
>>      CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc7+ #650
>>
>
> Dmitry fixed that already: http://lkml.kernel.org/g/<1467294357-98002-1-git-send-email-dvyukov@google.com>
>

Great, thanks :-)


Vegard