From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933273AbcGLOco (ORCPT ); Tue, 12 Jul 2016 10:32:44 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:51394 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933032AbcGLOcm (ORCPT ); Tue, 12 Jul 2016 10:32:42 -0400 Subject: Re: [PATCH] kasan: use \n with pr_emerg To: Andrey Ryabinin , Ingo Molnar References: <1468333008-21930-1-git-send-email-vegard.nossum@oracle.com> <5784FE4E.3000404@virtuozzo.com> Cc: linux-kernel@vger.kernel.org From: Vegard Nossum Message-ID: <5784FF7A.7050702@oracle.com> Date: Tue, 12 Jul 2016 16:32:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5784FE4E.3000404@virtuozzo.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12/2016 04:27 PM, Andrey Ryabinin wrote: > On 07/12/2016 05:16 PM, Vegard Nossum wrote: >> We really ought to be using \n with pr_*() so the 'general protection >> fault...' starts on a line of its own. With this patch it looks better: >> >> kasan: CONFIG_KASAN_INLINE enabled >> kasan: GPF could be caused by NULL-ptr deref or user memory access >> general protection fault: 0000 [#1] KASAN >> CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc7+ #650 >> > > Dmitry fixed that already: http://lkml.kernel.org/g/<1467294357-98002-1-git-send-email-dvyukov@google.com> > Great, thanks :-) Vegard