From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933321AbcGLOnL (ORCPT ); Tue, 12 Jul 2016 10:43:11 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:46366 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752619AbcGLOnJ (ORCPT ); Tue, 12 Jul 2016 10:43:09 -0400 Subject: Re: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors To: Joe Perches , kyungmin.park@samsung.com, k.debski@samsung.com, jtp.park@samsung.com, mchehab@kernel.org, javier@osg.samsung.com References: <1468276740-1591-1-git-send-email-shuahkh@osg.samsung.com> <1468332418.8745.11.camel@perches.com> Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan From: Shuah Khan Message-ID: <578501E9.6090008@osg.samsung.com> Date: Tue, 12 Jul 2016 08:42:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468332418.8745.11.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12/2016 08:06 AM, Joe Perches wrote: > On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote: >> Fix misspelled error message and existing checkpatch errors in the >> error message conditional. > [] >> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c > [] >> @@ -775,11 +775,11 @@ static int vidioc_g_crop(struct file *file, void *priv, >> u32 left, right, top, bottom; >> >> if (ctx->state != MFCINST_HEAD_PARSED && >> - ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING >> - && ctx->state != MFCINST_FINISHED) { >> - mfc_err("Cannont set crop\n"); >> - return -EINVAL; >> - } >> + ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING >> + && ctx->state != MFCINST_FINISHED) { >> + mfc_err("Can not get crop information\n"); >> + return -EINVAL; >> + } > > is it a set or a get? vidioc_g_crop is a get routine. > > It'd be nicer for humans to read if the alignment was consistent Are you okay with this alignment change or would you like it changed? checkpatch stopped complaining with the code as follows: > > if (ctx->state != MFCINST_HEAD_PARSED && > ctx->state != MFCINST_RUNNING && > ctx->state != MFCINST_FINISHING && > ctx->state != MFCINST_FINISHED) { > mfc_err("Can not get crop information\n"); > return -EINVAL; > } > > thanks, -- Shuah