From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754682AbcGLP0J (ORCPT ); Tue, 12 Jul 2016 11:26:09 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:34650 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbcGLP0H (ORCPT ); Tue, 12 Jul 2016 11:26:07 -0400 Subject: Re: [PATCH] cdrom: support read sub-channel command in LBA format To: "Veeraiyan Chidambaram (RBEI/ECF32)" , Jonathan Corbet , "Channaiah Vanitha (RBEI/ECF31)" , "Mahendran Kuppusamy (RBEI/ECF31)" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: From: Jens Axboe Message-ID: <57850C0B.3050705@kernel.dk> Date: Tue, 12 Jul 2016 08:26:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/10/2016 11:49 PM, Veeraiyan Chidambaram (RBEI/ECF32) wrote: > Hello Jens, > > In CDROM Linux driver code, "Read Sub channel" format is hard coded > with CDROM_MSF format only in the function cdrom_read_subchannel() and > mmc_ioctl_cdrom_subchannel() in cdrom.c. Hence, irrespective of > "Read Sub channel" command with CDROM_LBA/CDROM_MSF format, the > reported Response which is in MSF format was considered as LBA in user > space application. Now the behavior is changed in such way that > IOCTL returns either CDROM_MSF or CDROM_LBA format per user request. > Please find the fix patch attached. Applied for 4.8, thanks. -- Jens Axboe