From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755111AbcGLP3Y (ORCPT ); Tue, 12 Jul 2016 11:29:24 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:36393 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751962AbcGLP3W (ORCPT ); Tue, 12 Jul 2016 11:29:22 -0400 Subject: Re: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit_request() To: , Keith Busch , Christoph Hellwig References: <1468321577-16278-1-git-send-email-weiyj_lk@163.com> CC: Wei Yongjun , , From: Jens Axboe Message-ID: <57850C5A.1050208@fb.com> Date: Tue, 12 Jul 2016 08:27:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468321577-16278-1-git-send-email-weiyj_lk@163.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [166.177.248.207] X-ClientProxiedBy: CY1PR17CA0037.namprd17.prod.outlook.com (10.163.68.47) To CY1PR15MB0458.namprd15.prod.outlook.com (10.163.235.140) X-MS-Office365-Filtering-Correlation-Id: 54beb7bf-6867-410e-a7f9-08d3aa690a04 X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0458;2:8/yUyJ1rlzKu5qw7/cIKN2guuDVrNqANePAwAevK+IIz4HHtwxMbf8MaXAErViZWroXZyjjs2d7v8ciV2ZIue4vg7Pszc4rpwpiuUlkcOXa6tdQXoKk9dx7PT91+5l8MhTavLD8wYb2myFTVrMd8w1lz4IpqtBI5GalItAWLS+A7zoMv4ABNFcShNPn4BY7m;3:RRv0NuRp/RrW2ZKRIYLnTaX4TwYpXodpWWzLh2KigXmnSM/kmouyRMhCw5/gEGcETATBg0HsQuMdN3mJsYhsEN7y2CMNqt1HpJJX5QiGUU3Pil9SaCcsUtGmlLdwt8A3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR15MB0458; X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0458;25:jz2OlqQnK/9jHzuS5f8cNJq5hOK931PS5ytegMfCSQcP90mVRqT/+/BOfdDiK5qRWHWcCF3aFd4AqiseJbnPdGeP1LXZY3iONlKUHs8kuPoNt2Xnm3z6FLFpIkYIexrVj3aicCNUCiDO6DJGh4WfhX7o8r8WWKTxzSDtwtAqhEW/JLMeC6TEAaHhuH84qKgeBPoG0kY9cc/ZBMpySO/oXkFKx76Juemv+6CIFYFZGTsi6Oq/JjOexPuaSQRag6ld+URbDibt0IgAL2wNdBFsmU2A0ABTfLirKicmX7gaGsMdHYV4tW1gBHmZK7R/oxQKyo8Q4m0bD1HwJSRo3Vt/Iqar5LqOcrkvH4xzQMn5sJ5Je1ao3FSnqPzBi5jiFDXhNad4Z2r6rz8akIDcgqAHrGM6GZ7/ZiyWGKcZQm5SAlcAUK4e5DQEt+4tindCK+d5eXg7+bN9gfJafew5k10/vWYytXLXaANGkzDo4zq2oZZbuiCYDgJEj4f4mQvVObxGaQ/CjBgqClNxxIcJ3oRQIWca5+QVdmg9ILhaaFuxaCgwawQsANYJm/mT27+wniTt/2dDvFA2lQvrYRUFuIa/e+xbCfW/Nc+tE12J4t/DsGb4Ln0EQ9ibsuVPCf1uXtgRsrenUTrFZ5hWltACWFML5LkaXBVn8aXbgOTtZG8wUj/HBVdQnNpEhjn9QkHhgBOJ0zqiOt8Ly7JXpfqtCu7sr4DMBnSoX5lxCGKuYcdoZYA=;31:wCVY09ZgYbDZ0RbAQt0sTmHsakhxfWw4V7ECiZNyHNIH8zHkOf/71wU8E/750T1lwyifKAQV0FUVvXIPKJjb5HUGPfRewLh4n4DR3ZDfCsxUlSBxxKI5rDJutSxPuMc3nAloOaakfopgbdoORj1Kvko/etK14Ih/EZKTt7W2bEBTuo0ZmzivbD0t3nCv89bJSSZRL1C4GdIRRrRPLYStlw== X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0458;20:TV9BwFl2uv8Xoy5YbNQkVzHw7JOLqoaZSTz74Pn8lk6IlDo6AX+qDqp914cnCS0oARXVlYfNWKhgwxveGCGHHUiYTMF6+/6XBr9G9UdYQIjggLdJl5P0A+276jL2rbfUkLd5tJTSnHbApy1DDi8Y6rIU5btN93H55c5zCMc20h8=;4:amm6baK++bmwkdhECa9DAQMHu3S0qjTPbRKInoVmnHTLCtFB2a431Nt2uAdBHlB9aCBwjdL1WKd0B8g0XriAdSUUvwNwx0z/PPXPTkjSQDE5hOMSl2En6t5p13ziDQTHuczpRRubRyZ9XPuiVs72ot/2Op9fRA9eoR+rSwf48KHKg9ct9yZngSCk2DH5fmLOWBRRHcHkKB+ZaYkb4+/NmzTfP6T37YNv9uYUxEVTgtAIy1/SlR9gHnwZtv7ifhbnNNsw2j7epH2ebzB1Adj6AmCotvvh40ikiH9pNSUaMolPpZ3BIuI0BcvSL21jcPsJW6xUhlDCPnYJatVeTPSSiuD8DXmiJzoHVVwLfAslw5fnSwkUMeI/4aDzszawcuP/9c/gzXS2QsAaxFgjtQ5RL+mthklODZJMhUu6isYsoac= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(130843839470238); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY1PR15MB0458;BCL:0;PCL:0;RULEID:;SRVR:CY1PR15MB0458; X-Forefront-PRVS: 0001227049 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(24454002)(377454003)(189002)(199003)(50986999)(586003)(6116002)(7736002)(106356001)(7846002)(305945005)(99136001)(36756003)(3846002)(81166006)(47776003)(92566002)(23746002)(76176999)(101416001)(87266999)(54356999)(81156014)(68736007)(42186005)(2906002)(83506001)(4326007)(5001770100001)(4001350100001)(189998001)(8676002)(97736004)(80316001)(19580405001)(19580395003)(50466002)(117156001)(2950100001)(59896002)(77096005)(65816999)(230700001)(558084003)(105586002)(65956001)(64126003)(66066001)(65806001)(33656002)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR15MB0458;H:[192.168.50.63];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR15MB0458;23:krppkqcA1AG8j5tS7fB0gH3NJOkv+crobPC9y?= =?Windows-1252?Q?KTNS6oNjwnStKsJ/VBYsK3B6Sp22FLK1ZTmFYixWMd/ty1ZzONTAfkaI?= =?Windows-1252?Q?b8y7HJsd6u5ZmjdvDK02YJyfs61PKwpf2Ee+YEH9Yp1fcEM/5nYBQsjS?= =?Windows-1252?Q?WyuEv4p81Zw0Bgt/crprXYed30j/q15umLTStHKskSfcRIwvND4F+F7X?= =?Windows-1252?Q?e7VUw0EN+Ryjqj+Yzvj0ee0urgi691t66iFAO2CFRtFMAg2qgwGfpygd?= =?Windows-1252?Q?j4ef1js/CieMKzVE5VuL7aUgUATG5i/9rAPE6DpT3zGlhQhKRmjPTRUo?= =?Windows-1252?Q?pS5QPByGqgOgfAHcL6t4HcEDeCPIKf7hV+VpxAoJfP0CpuxfSJu3roKh?= =?Windows-1252?Q?y0by+H1Tj/W84fEvPBqBu/II4AyP8Gd+Kh45Iv/uK3J3PH7Eqj9Q5teI?= =?Windows-1252?Q?D3qsbbMWJoUpOmIs0nSqNgVH2vYih3KY36ipUQGimSxQD3/UJQjRPwCO?= =?Windows-1252?Q?gpkVZw9lzzgtu1ZFyo92TQODlc0UyBmMNdyqfS8WTh+bvw0mRaDMmqeP?= =?Windows-1252?Q?NQHYA/E52rod5DhBaR07r8boo04CUKR6iKVivSpAQYDAa7xGOx95gAJq?= =?Windows-1252?Q?4FsgmLgZzZsnn87hM2xl5q6fiz1GBxfgkJIF54w9O4o1UmF3S/5Fli+b?= =?Windows-1252?Q?g3EgSPTQtV0H3ImLrhk7jstZ0+0wywLbduvJuWCf7yzw3Stpbrh0JyUD?= =?Windows-1252?Q?bnWqR5wt5j7klyTgAS9fsU6QIPYIAMirHpgeH/IE6kYLtNUoQfsfXTqX?= =?Windows-1252?Q?NIgzQSWI5QXMFX6qAvg4YhXU+jVpSJity1BLU4p3YZ20FYmmcBQvseet?= =?Windows-1252?Q?bNhU/S7J+Kxa18ra01SpPc4mA1xuVDqz0IMchjLxznlML9+Qvkj+R22q?= =?Windows-1252?Q?/9YwQI6EKEbHNFhOgJo9b4yH7ZWmngY1+PIJ0Gk9dRjmONTG29jFh643?= =?Windows-1252?Q?fg1PJEBGldqbQ0/2SnzR+/kduMyrVpybZh7F5DN3NTXNLSd8UPIrhcaC?= =?Windows-1252?Q?tDVKnuUwoiUIH6YyqTe7sDsjT4JQuTuxkepwPmPScBKBBn7vtq+4sF+x?= =?Windows-1252?Q?+lw7gbMYcsKxOqoNCTXr1d6t8rK7XEd7cjlozn9iUe+56qkCMPBiHDxT?= =?Windows-1252?Q?xvjRk1LiI6XhEcns7bylOQC1sTIuveAK2EK14diz+E+O6Ff5fCM9ge9Y?= =?Windows-1252?Q?RanbM5KENS31ppL24vd6kGNmgtQl9SvctLO8gg+5CJkOoTKO+EzXvZxD?= =?Windows-1252?Q?sHA3O8ZcbQuqUHM50oT+IzUxCGvHqeF9YvJn+4yPi8DXNh9puIG+Rw7m?= =?Windows-1252?Q?wZ1sLYRHzHpReDELCE9+f8xIUaCmFwYUazZnLbHGdwsLu2r0IgV2Ipx3?= =?Windows-1252?Q?tr4w7IvnbvNYgvrlrCv5+TngtBRI5VY778yKqN9dw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0458;6:Fr8CfDcg71Eov7ofv8Jz6lFKNzfeO5X2Dba5RVXFwJpLuBQBIF31lfwoZxMJfq0IkKUF0OrkyCnnKVPu66iVaBboKCHTwGdwS7b2cZjBatbg7tGBOf4Dr+oTnxpsMGHW5/BICB+otzeF76jHz7BtSl+0BdPoXcEPnB5StoULP17kXtiVxXGp4d1a9oLZ1tyfixKoK5ea5/c+erjsXZsCCZZ/Tcvzo8DPS+mF4RTxWlbH7AJuQB1D68AyQvDLhh6rtZM5qEGb7ftOeNVEWfhtFgDZOdjIGKmhTym39Gpw1Q0=;5:ZZ2iSUrjN6reIqRAodd6DEfjxGkClmrS0NOUaOC8QGVkbYRA4p2XHWNieVgkCYhbFn2KTFZcLaSMIn+yWHXZgrcWk50OBRnQte7Mr1zelCCNndn1sj+to2TBcAbb0DL3d4SuVqxwSC5iknLdQBUh1w==;24:BD+qKy9UPCcFC31HAfFschQp3nHhrpj78r2R5TtfsOu7gfRCbsrw62UYfFV4taYGhx0jVM4J3hSofReXQpOlJjn53xC/A1ZPQofI3/lDl0I=;7:OH9W2In618l3ri2yuW6AVH8Hi7pXK2uwJvRPw1ttFcxbPCeXy4l6qoq9ti+K5V7u5xQqIZwKf7dgP76a9KYX0tAp14EFc9vs7LC5MvuxPoPzxplzWfehtWn2nCEPPyIaDkxv0DvGSJfUuwLXU/FHr29ScBU221YAEjLx6MGnClb3c2idXii1jMsWtpVub9Q/x7ghERQa/jBoAuaxxdfJ7cH7+HomLFlCvvQiMToHQs7kEwH1RR2ITIwWP7KBsa+R SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0458;20:UmD9H9pll3j5OEK0cFTypklU1jctMmWpFNQboYX1fbMj7cGgs256bIZlm7fUEiUJXB/jhfP4cNYoWSmP7Shjof/lXIXxAKgIDHnPSICgzy47+f+f/CzxT82iyVBt4ZQpc8D880q+I+JcbSwt3/n7CfOpiy52fedftPTvlYsNOdU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2016 15:27:27.9642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR15MB0458 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-12_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12/2016 04:06 AM, weiyj_lk@163.com wrote: > From: Wei Yongjun > > PTR_ERR should be applied before its argument is reassigned, otherwise the > return value will be set to 0, not error code. Applied, thanks. -- Jens Axboe