From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933195AbcGLPhq (ORCPT ); Tue, 12 Jul 2016 11:37:46 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:33679 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932533AbcGLPhm (ORCPT ); Tue, 12 Jul 2016 11:37:42 -0400 Subject: Re: [PATCH] nvme-loop: add configfs dependency To: Arnd Bergmann , Christoph Hellwig References: <20160707090144.3061799-1-arnd@arndb.de> <577E68A5.8080709@kernel.dk> <20160710121417.GA21551@lst.de> <12070715.hig6uZ5icx@wuerfel> CC: Jens Axboe , Sagi Grimberg , , From: Jens Axboe Message-ID: <57850E99.1080901@fb.com> Date: Tue, 12 Jul 2016 08:36:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <12070715.hig6uZ5icx@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [166.170.41.56] X-ClientProxiedBy: CO2PR05CA032.namprd05.prod.outlook.com (10.141.241.160) To CY1PR15MB0457.namprd15.prod.outlook.com (10.163.235.14) X-MS-Office365-Filtering-Correlation-Id: 37a2da55-6ce0-4187-e62b-08d3aa6a60d7 X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0457;2:qk2P8XN3CDjhJKDGNyVqwM43/CUf7aQzeKBQOy4HNj2f7uhQgY9+vMGASRlwIocdweMz1rI/vcJi+HfRHoFq/Y+uyw/nnP7D2VfrXt27hIDoZqOhT0JGZJM6f3uVEbym3ZsHBor4U056khuNm2Ic2ECLPW6T07eTBtRp0R4auUStwhXbw0oEztLohIXu/TfW;3:7f44hPD0UZjgVAecq8iWeSHBsYayzScCNfAoHi9vkeEuWisrVs3X8R1tL2dDi6Bssn6L/qXsSt6CyvkLl6ax2DF1kalfZOQSOSOPIBPjfAaIb/5yNMHrrgq2xjenNEaf;25:fU724cUVqgXwBfyeNMmFYj11zEFO7/GatyjCuavMxMDwS1xeQZwCbfF63+57QHGGrGrryqF9y3K4vEvh499MfJ2nZMAE7dSsPkvgC4w1M1DeRPnI7WOfBPHu1PwJNow1KejIt062I08J6Lw30r2o28NoQLbWrTu8uY91/ZduICq6T/L63ow6ndnXJzCXYQFHymssuUsq8xnOrfeKtwYvpm48Ocio0pZNbOoFcwwGpJjbYwff/w1StQ7RMdVLNhTx+MYz9q/8pv/DjLx54q0hEl/WtXPA0jEpne4h/8imoSawUz9K/pkGtkRb6aNeK4JLmwjjVInVxJ8CTIgkTEdEItEWXONyucPOxSYMaj0Hu6A4Y8Hm37njpEPXs8AuEwOF5LAK2XPAFr2Om+nwf0Y08QzANfU9THHJBWKMvBe+q/U=;31:mdDlEjmmj8J5C9dVrTrr7KWDvkzQ7O1axprw1k6ZMdk1i049itEfmdFoJlS6mRadl9Jq3+g/Co0kiZ9Mod6b/eM0p2DEdDPD1tll3pGfu9C/R2rqhSkDwVf0+pb9t4P3+IhoGdxDGCtPI6ZdIIwJQ9z2kFnaibd41uRPbvjLCd3rlvCkFXz83RptwS2+YbMBU4xcSap+yuZR4vdz8fEq+w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR15MB0457; X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0457;20:YXzCcRBpX3lE5WPyQkT74qebC5/r3ZWKKKv/MgLRpYoLW52GIk/9COiOkgBzll0CTttZrOkEijuxvy9RvGstOefDRGi1H/XTqhvd6r/sisHQLxEoxTHSWHTLIauB4IfuCUamicQVie2ND2q1zA1TXLXEaZdauAkPF97/pQwgbLA=;4:0HLClGkXIaRdZDQyz0dop2mk/GciQVDOyMOcPwoj2RevKhsEQ1hofbbsNhLxF31Rv1E927ShPf6GGu06TnYpQvT3vRO+kQX3Ohkjlltfs1+7I2OLY4pyziFyY59891msS2nHaZyD491awfKW+qh2ifQlRS0tVh5ZpvQEur7Dt4cqkUmI/jU4uyOMgb7nSJdvWrj9E2A2WqGDAuZOcHcF3XLjEG9tYLMD3/5sDSq/Iq6ntx78vmAR8VEaqFLkfPZ09hPPJ1gRfJNIB7hPdwWDOqcTIPmvhUTDKDioDAzXtE+J4Jr1n8M9teczyYI6lqTAeC9i8RcZhuk52EoZP7p4GjldE5dovA+IlfGdTT2ehip1fmfAcnInWJ9V/HlNu501FnGZ4BLmNqDvXTKuxhAf2N8ml+nacKEYqHMlo7yaYTI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY1PR15MB0457;BCL:0;PCL:0;RULEID:;SRVR:CY1PR15MB0457; X-Forefront-PRVS: 0001227049 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(377454003)(199003)(24454002)(189002)(64126003)(106356001)(230700001)(189998001)(7736002)(7846002)(4001350100001)(97736004)(2906002)(4326007)(93886004)(59896002)(65806001)(65956001)(66066001)(6116002)(105586002)(99136001)(3846002)(68736007)(47776003)(50466002)(117156001)(23746002)(50986999)(65816999)(54356999)(76176999)(83506001)(33656002)(92566002)(42186005)(2950100001)(101416001)(87266999)(36756003)(586003)(81156014)(81166006)(86362001)(8676002)(5001770100001)(305945005)(80316001)(77096005);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR15MB0457;H:[192.168.50.63];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR15MB0457;23:xUNQZYfpLW9Y/AXoppBOVhXKHYTQprSDNkjoj?= =?Windows-1252?Q?Qk6VgNiJg9dH8duywLMGrc9hSonjq0m5ADDPzjJpVvSgdlvuZ0OjbB/B?= =?Windows-1252?Q?7kZBVho2XHtjLClOF5QgXG/9ntKEG3eK35BCIfZy3GHFrAAZ8vwNxMyi?= =?Windows-1252?Q?/tjJMt28utfd3tEaoNRWW1B+l7nYI5eb9XFTI3GHyH5qk20I5peM4dES?= =?Windows-1252?Q?aoEtiQfjQNnYaVJOwxl0zszKZikHaBli8Frb3eqMGdXq+pERZ0mH3QCI?= =?Windows-1252?Q?Ny3E+hvOLYodRkEz+Wl0V0WRmr13cTlNBO92Ywsez/Ur7Oo+JIScGKYh?= =?Windows-1252?Q?c0uTme6eJepOqEuNiZ+x2YexDRwT+KnSzGMwIwQTMdrX9iK2+HVUQUDk?= =?Windows-1252?Q?1ihBv4XsTn52fIkwQeenZDwdS/UJHu+f5jA/Qmg8oqnh9/U0V+vOQJxt?= =?Windows-1252?Q?sWFha7odB4yGw9woYV/D5XRa1gFy924XsvLIZ3s1U/+FTUgRmGlwGGE3?= =?Windows-1252?Q?dYTn5fa62lKQTmmA00u2Q0v4bBs2j8Dz0me454Lb9L8bNjfpPYa8Rgaa?= =?Windows-1252?Q?8kSivT3w8hM3jinFkd21xPJWPiUULxl6a67JiBjFPLBrPFa0v33LOuuO?= =?Windows-1252?Q?zwxrwixJq6M26teGwjfS767LOj/c7yOuCwndDd3FEpDYMhlDDJ2Q9M9j?= =?Windows-1252?Q?XrMtBnmOQfSuM1gCCYY7WZrDkZmDtBKK1ZOkx2gu2R8mgzuBW98W2pn0?= =?Windows-1252?Q?OCb2UnGxHYkryO+zbPPjSIamfoEe2EkdNGSpA745OoSYINxt+c/MqjUK?= =?Windows-1252?Q?4NbLC4N+GlqGVI2AaIDGiosShGUnI632uJyeGkHESl9ec0QnfyBE969Z?= =?Windows-1252?Q?6VXxBcEofP+L7v+U+R+qzL0p4F82YQ8dfH5W6+AFfn4PeTE0RobDTLzF?= =?Windows-1252?Q?7lrS6gk64bcPOKqHjhOne50qGzHgbbc/oKeRj1Ks1DPIiFaJVwY05ENp?= =?Windows-1252?Q?5ZLnhjEVBubZS9DwlkZszhoT/8ShjzfspUm8PXReqhZBvQn09UpplPbp?= =?Windows-1252?Q?WrN0/1jh+kGpXe/DlZRekRdvqGDW3PHSQ91BovEHcY9nYhDaA8ofie+d?= =?Windows-1252?Q?+dUQAFzJJh6zS/4ttDh++8koFfc5zTHUwM3S/46XCe7Ureu3QvCPVkp2?= =?Windows-1252?Q?hVXiECI2Cq97E3RxTw6XIQApTo+wrl5kpmM/K3jczYhbOomESJD4sL1g?= =?Windows-1252?Q?v3Pg0sh64UwF3u7cfyAxwBPoTz9weVSaTzjymUMva9bTLtvTpNQnh9KE?= =?Windows-1252?Q?CIsV5tQPExJah1ZRIiG7zJ+9oV/R9ggC6qEAQl9yjhrYXHBQ/Pt18fy3?= =?Windows-1252?Q?zLWaMPdJk/GmufDqSS04iT07FvlwlkvQF73sg9dK9GmGgSSSfm/BLY?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0457;6:9QbyY7sklMaSY7Ib4ADQi2HQqIHU4L07IL11Cd4PA85ypBrdsKDzqGozj/mEfBomIEfEIVy0tiSO5g1qZth1PYPS5yOC5OSxxF3Ezg2HYj1MUPhHvD7DVPaY2S4Icj/0KmZv/8LI0y9gn3yQjB1lh4zKwmavKDxID7STJlQpF8+l+sy/Q//COYSXn2yYvikc1ILGssT1HC6niJkFJErUW0HFOEz80HsO3aBKrcbAI6dgvMjyZ6eKrcoZVEeVOzmECEkfjH8DjQFaciY9GOMVSNM6pqh/a0MgbDHBXPa8dj8=;5:T2GAkScT+JwDOcplqVKZ8jodIrfytBEfV4uOSg6bSRvsSjUrFKYrH1GnSPuihsyBk5ynhlrqDW+MVacAzjCltNDMoFuYnddOIeXMaImk2v8A0dkuREjNqyE1tHdLlvZwO85a8gWP5fO1Q2iyCANhrA==;24:OEP8Ndowj7lyRk88VtU+OwekcOkExQ4LQ2Rs/ZZjhul7I4HoyUa0iqry61QNrdfR/YnOYhMKA+2AsN1jTZc8PJG56MdhxTqcel0tKAGDUw8=;7:nt6HIzN/9t5EtAqaXANQY5oUdGcvQOZTXHxmAVLTvihAcwm4cgi2NZkUgbCPWxXkS4jhnukW4bvLx9BTGvrvqE5E/YTiUZn0ZCJWBxxtgFT3Aqwa51Gr8AuC2hTIwdlrf6pkMENMzwGPr7oH02m0UsgKivhVGXCgS0vZNQQ9hBjnND8/DBp5MfImpcTUPIvuxa+Po/hb5T2BqvQ8zG/vp/W4ULCG2BqxisIg+J7guDE+F1VE1dWNVfIj8sunMlKt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR15MB0457;20:JuQULKZXzIJqx/Ix2/RxKqhJV5QMtBaFcQVY2FhrClMoQV1SYvndHuhCG/1/YXxEcJLLH84nzfGqAiQE2Xk5VYHXY7F5irCY1xCEaRCoIcWaXTAvsSY8yItx31dZO1j7DQnyCuW6VNlEqLsHE5vKebHLdP35Voyr301/BqxCik8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2016 15:37:04.8081 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR15MB0457 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-12_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2016 01:29 PM, Arnd Bergmann wrote: > On Sunday, July 10, 2016 2:14:17 PM CEST Christoph Hellwig wrote: >> On Thu, Jul 07, 2016 at 08:35:17AM -0600, Jens Axboe wrote: >>> Thanks Arnd, applied. >> >> Actually I think we should replace the select with the depends. In >> fact I though I had done that a while ago, but I must have messed it up. > > Makes sense. I ran into the same problem on NVME_TARGET_RDMA now, > which otherwise needs dependencies on both CONFIG_BLOCK and > CONFIGFS_FS: > > warning: (NVME_TARGET_LOOP && NVME_TARGET_RDMA) selects NVME_TARGET which has unmet direct dependencies (BLOCK && CONFIGFS_FS) > 0xA002B368 Mon Jul 11 18:00:45 CEST 2016 failed > In file included from ../drivers/nvme/target/core.c:16:0: > drivers/nvme/target/nvmet.h:222:14: error: field 'inline_bio' has incomplete type > struct bio inline_bio; > ^~~~~~~~~~ > drivers/nvme/target/core.c: In function 'nvmet_async_event_work': > drivers/nvme/target/core.c:98:3: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration] > kfree(aen); > ^~~~~ > ../drivers/nvme/target/core.c: In function 'nvmet_ns_enable': > ../drivers/nvme/target/core.c:269:13: error: implicit declaration of function 'blkdev_get_by_path' [-Werror=implicit-function-declaration] > ns->bdev = blkdev_get_by_path(ns->device_path, FMODE_READ | FMODE_WRITE, > > Folding in my patch below should address that too. I folded this in. -- Jens Axboe