From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbcGLT51 (ORCPT ); Tue, 12 Jul 2016 15:57:27 -0400 Received: from mail-bl2nam02on0118.outbound.protection.outlook.com ([104.47.38.118]:29301 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751486AbcGLT5Y (ORCPT ); Tue, 12 Jul 2016 15:57:24 -0400 X-Greylist: delayed 860 seconds by postgrey-1.27 at vger.kernel.org; Tue, 12 Jul 2016 15:57:23 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <57854829.3030505@hpe.com> Date: Tue, 12 Jul 2016 15:42:33 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Tejun Heo CC: Alexander Viro , Jan Kara , Jeff Layton , "J. Bruce Fields" , Christoph Lameter , , , Ingo Molnar , Peter Zijlstra , Andi Kleen , Dave Chinner , Boqun Feng , Scott J Norton , Douglas Hatch Subject: Re: [RFC PATCH v2 6/7] lib/persubnode: Introducing a simple per-subnode APIs References: <1468258332-61537-1-git-send-email-Waiman.Long@hpe.com> <1468258332-61537-7-git-send-email-Waiman.Long@hpe.com> <20160712142727.GA3190@htj.duckdns.org> <57853C33.8000705@hpe.com> <20160712185718.GH3190@htj.duckdns.org> In-Reply-To: <20160712185718.GH3190@htj.duckdns.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.165] X-ClientProxiedBy: SN1PR0701CA0024.namprd07.prod.outlook.com (10.162.96.34) To CS1PR84MB0311.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.29) X-MS-Office365-Filtering-Correlation-Id: 1ef05f10-9a67-43a2-43a6-08d3aa8cb8c2 X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0311;2:oZJBUwKrwRdUMYsVMFc24Gd5lHEtimHiQX11ZrVX37IB4GPAnaOdV3f5bL3+4a9smHwuA8smU2VGdrom2t2wfO4Yh+oeGb6YLoR4R+PpzrifSUX1E1oa3fn346ZIw3lz+ZqOdithDUBJ3PhN+rYT1FtEWBWsBq8VcZDt27KmLLScqXYKJsRxafUiu9tDJkMK;3:s4maSeoTnR8v7c1zIebTf/QeBeESKX77cvDKdUYsvsMKHGhpyFvW7Z219D8ysLsar03ewmtSq+BY+bso0ZHSDz9HZJirshaisBfJ+fXhi6j5MbGVOCiUFOn1XO9r+x3o X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0311; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0311;25:JjD/CTeWkVDv9G6sjQkQsvqnjYBEPpPMD6N/Dwpx/JYyJGThe+ssBkaZhmopXjavLLX5pjqshByiKSabefaT2ApV92y8sFYTjVhUaK3cTKQQ0Q4r5OPLRmjMxjDzSsy8k5ZRS5hm2wjf38xqL/UMmKTLfbceaODrFKJBN/5wHry9WM0y6gAnrBOA8euUpp7HBvvGxn8suD/uhjlvxoiFnh9D9v4z25EHFd44Lg+VQWToplq2E/P13sDomFdK9CrvhSqTX0Z5gCNR4RHMcrneSQA3fzhzsn5ndwzzCM/9s+gpQFtr6qAmI/eQOpdLh4HA5ZLS6WrjpWR4Yj7eXnqyRaLQQElbEJBe0L++Zi7S5itWm8UzNVE9v9o+r3Lr86HvwFMUBu0PUa1l8oMK5ZxVeoFEYmP7MyhhSYzrzSW5JLHhKncHNBCVQkB+Q6O7Nu39YRZ15Q01zH69okP7DHbKAcBQb7JovZGNJd3HDT5v4Jl7lHR9JoNxBTRoxX+nccsaAcgH/hQjsnk77CVTKQpYhHZ51AyHFvi1MbilcKDQ64+izwoOUqLZiHTNc/Z1ZgM6KIHcC4y5da+fiqWRs+u/rIVAhaN0xB67VEblzEaA4JJAA82C6EeErZenqwzvgwABaffOZjEROAiu3/Fw152EJ1mGLtVUfAwXFg+90gUY9VDk87dOYRarwdFwVpA3fVbdNz7bT8zVo1z0m+KEAT/iHQ==;31:9gEYrAYR63v2DhlRKbkin68VWTf25sDw5+CZQ1+bT7oXmFwjIZwIAkKWDIhYNmZw3LYJYjAphEcVQQeZVOWxrmGpu1055oAwYm3pkTr4sjmtM+wVbOdI1IGABtMWRBDs6CrpJPVwe6jxG1kG4yA4SLwte6x8r7l3EECVei5X3VfqnS9U1XmCHAIkdeFKt1i4xGHD+sg8wbsh45MWtTJQjw== X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0311;20:99GDtOdXPDBDUD/S1VYfrPSA00XMMprBANxKdZRf4hZ3h5c3O08GlryC+FPlvmItV3Xk8iy94lTGue4qRlgrpb9QgctwhKYayWwVfwJ6LjjhSUSo6iQ9xg87LDAejKrNGhk1aZNprIh4Kk+jlcgWdMGoaeQAKMS9cY/zv+MTW5D5WIt3MLqfb5k8rClQ4B/pXNM0kCfmKHty6KpLCyWdvlBIqdzetDckZdb8sJUbbIJiv5wCCvN9hTIOtyiFdezSu61Z9zeoG+2Z0tUuO5lCrDaIRgYJ0z+lcWJmqbJePGiquYUpgk88lM+zk/OrINA9MO71ZnI8iiE3yk6Wmb9KcTxX3E3Lz0CerGx8ClF7ss3UHR/cQmoZW6dTpKds9J6nsY2qzRRrnUEngOfL5dL0SdazgryIeRhPYXRCoxueTqueTT73o755VKK03HMyxzt05slaIKYntYxh8kxyFCnHj3ODKStHIHGgbJ9CY62x7g4oGfLMVYgAzIHEnszON2vD;4:JeLdFrpiR27o+kOeJKJEZvM9aPyuBKjeTmqbu30bny0yv9F2PeuwoR6tCTqGVVrHw7HZxmQfKQHUX6iVlGEoWgn95xWXBDYEqBrefgD6Hg/JG3ygAvp79A+aym8kX2dM/EBcuVmNF+cvoKusJX6+1ajDUKF4nLb8ad1jSfH4BYZsvfXFPcGyN6qXWRMCCpjQd/rf2Ap4knrN+r9zjPdOPN9AhuOddGKMHkwUsIS0shZBNe8DwKq9mTAPJd7TR8lo6CDLpwCW0QuBnHaMXKeaPhnsF0I5YIQ7hqzVvRUOwlLXetfwxQ626XMaNx4h26zODP4dZqs8sm949XgJxqRqj1wv65ysBYmMUfqDsDwfCmBiJ44La4wkBHIbmtoJe+Fk X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CS1PR84MB0311;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0311; X-Forefront-PRVS: 0001227049 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(24454002)(189002)(377454003)(199003)(6116002)(8676002)(4001350100001)(68736007)(230700001)(189998001)(50466002)(99136001)(92566002)(105586002)(83506001)(3846002)(42186005)(586003)(122286003)(117636001)(2906002)(65956001)(65806001)(66066001)(117156001)(59896002)(50986999)(76176999)(65816999)(87266999)(54356999)(97736004)(93886004)(36756003)(86362001)(101416001)(47776003)(77096005)(305945005)(64126003)(110136002)(23756003)(2950100001)(4326007)(7736002)(7846002)(106356001)(81156014)(81166006)(217873001)(62816006);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0311;H:[192.168.142.166];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CS1PR84MB0311;23:6vhyLxQWZ2xZF+RLFwSeRmxDcAgPTXnr1xVn4XV?= =?iso-8859-1?Q?wpEwlaT9pUqGr9HFR8BPPVBwla0Gi9oglixlJCjw/5QOHkp/hqPU4TLrqj?= =?iso-8859-1?Q?yClIo1Ui5VU+lPPrqqmz31adbbrShXGAv0HepviSd9wk4NDnxoOHA8pjHL?= =?iso-8859-1?Q?O7taqY9oDEyalRbtp19maG68MvP+1CPjt6XLlN7fL09/pbKmIIR/HGm5Ld?= =?iso-8859-1?Q?xwyDcsejTfevXexfHYuvu12Gt6W+4sbXFc+jcayUA4+I5Erz6VHiQRjJyE?= =?iso-8859-1?Q?VzTVWQb7FgCKTlJLEd93slC8Upfa7dK1SLn8jin4DbQNtALZToQwp3CHiR?= =?iso-8859-1?Q?Xsk1Gaq5hsZFGzWiZBUyF9EtWLYQDm850XmUodxrFjBBRdQJl9ivY+iPQ/?= =?iso-8859-1?Q?qp2zVBfbw55jeicheF7TY+N6ssyGQyMv2rN9PqlJbzQFZUaZz3zSaKikGb?= =?iso-8859-1?Q?++MULXQUpjnF6Z8fH61rfaFZG7yG0KvD/8za3l1R+aQUFY3X+XRc8TvT/S?= =?iso-8859-1?Q?IERkicz+bXVlJ1R+DyjKq/jhucQCJLBvXyNIzxTKMfz1gEVQ5uUkY0ewuO?= =?iso-8859-1?Q?MOU8bdXu80rRO5BL4b7NLEbwKUWXAzPJtjc1k2uCzlPRVHIn5GveAEmUqb?= =?iso-8859-1?Q?lDmsOTglg4SGXvetOkUHOn3WK261JaASI1+6tJTA1hbaGSnK8m4uF8iY/C?= =?iso-8859-1?Q?vLc5x4s3ysN/JZL3ibxRHzpt6PMetzn1zQxgrM2Mf8Vpp6AKHX9Htr+PY7?= =?iso-8859-1?Q?sYZKuIwJ6fUxUkoy1DvS8dnqSrdF5I413dylMbMF2bDBIZjtoGZLZ9zeXL?= =?iso-8859-1?Q?UA4qT0wke3ayt2CjHNUohX3GoQtJ1fuSMN9gCo+u6e3vHSMaXJbG2yFPKY?= =?iso-8859-1?Q?ZH5kgE3Wf0nIIkMG2enuyLOPsfz+UU2tHJvIxvisekx7sVkXBiqqzN0Whk?= =?iso-8859-1?Q?uV4tWnIpXEcKo/1y1x+D83Z7Y7BYUuI18JidGXKxVsROhmLHNj+wcfCMs8?= =?iso-8859-1?Q?dVIkpyrergrO0koXkfsRRtAZnBLX9mOm7g3Tvc9ssR0ro0/1K/mYM9Kons?= =?iso-8859-1?Q?FvdImNedNE30r3B9OlPdph+faJ6+f1/WoSJn5Lp1VY4QuzG4XU7whqpRgS?= =?iso-8859-1?Q?tPsKI8TrbzaSGfbmTCZKc6MfimXndIe5e3E8EoU2UmsL9sEqTzjAvbCtG9?= =?iso-8859-1?Q?nJB/wTvYF0G/MCifrCWr/zH7huhlsAMHRdW3X09WOmX9JjY/Pj7+Oxm9nM?= =?iso-8859-1?Q?71zytc6qCX0XytPZuXQQXqgI/l9TGK7i+aUw+pfpHzeXpfv9lLybhNXCj+?= =?iso-8859-1?Q?spLvYKzTFDhYSGDS2ZsprKiTHkYNJLqIvyK8HJKdGb/RYIRJkuGCNBAgTz?= =?iso-8859-1?Q?A82n7rOVXq7rii33UuHDipby4ejKE?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0311;6:Fc3QFYZvoR+jVThmH+scIr8TwMP8ww6daR7RuSP9Hu7Q5C5WGs706h74t40r+VFCZ8B6ZykfYullKC8szmHy5MDIJU9r56cAxAQmXdbKXh/0R3l1MsB8hv0dt4qMi0JPP49xj6lq5tzw4Nz0K7X+4RGo/Rx3R87sRh1Z1rnr22YJ4Sa2slvquPuvAtkp7WuCNnZz0zlgFPG+v8tr7I0L8j6yP3Zv9X9B3zLzrGkyVstsOVxmU9WMjM6LxzNc3sBPvRqVo2s5n2thH1PODhlajrOH3h8ebyiXrCi9cDy2c/c=;5:DfxbtVjCx6bQAQYBmdFrj9gWuGuEsXDDPipEZColnmiFBV3QyF/dCU65yCX6ytBd10mTE9Ryn0jDaZfNBUUYoPw/RiqPvU4pFID+X9xrIta3D72DB9TwGuqBfJaMRo0YFs1eACKubA3s81RhHAntgA==;24:u/hyutz7FY4YPBvJM50CVUR4Iud2cP7AKNzIhmOZkWzxC9MHwh0D4VaSh5HAmuzy2A1I4eTJI/yM/aKRksEhYe0Vyzom7Q9bWqKZ3LvUVUU=;7:6FwDr8y40y/YUxJfd7yhoU81Waq6yoTr2vHSkmYiTR4Yde5QsYAzL3YWWsIT9ssGCxdCW50wjux3UUzDWnIm6ECOTceLGPQjmN26bOWhGkPIyRObqFnEejaPPTi0aRRp+bZ/m78o8IKu54JgFrRtDVPXPmuALyDRzHsnYZ9diAOy2219BNLVna85r3u0lsErsiMVCZw+/ahCLrYLnssqJekvKyHYPB1E9LbSdw0mn2qsouUjjHc4QW2IGMyzD/WI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2016 19:42:54.5681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0311 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12/2016 02:57 PM, Tejun Heo wrote: > Hello, > > On Tue, Jul 12, 2016 at 02:51:31PM -0400, Waiman Long wrote: >> The last 2 RFC patches were created in response to Andi's comment to have >> coarser granularity than per-cpu. In this particular use case, I don't think >> global list traversals are frequent enough to really have any noticeable >> performance impact. So I don't have any benchmark number to support this >> change. However, it may not be true for other future use cases. >> >> These 2 patches were created to gauge if using a per-subnode API for this >> use case is a good idea or not. I am perfectly happy to keep it as per-cpu >> and scrap the last 2 RFC patches. My main goal is to make this patchset more >> acceptable to be moved forward instead of staying in limbo. > I see. I don't think it makes sense to add a whole new API for a use > case which doesn't really need it without any backing data. It > probably would be best to revisit this when we're dealing with an > actually problematic case. > > Thanks. > I am fine with that. BTW, do you think patches 1-5 are good enough to be merged in a future release or is there further improvement that needs to be made? Thanks, Longman