From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbcGMBgF (ORCPT ); Tue, 12 Jul 2016 21:36:05 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:50031 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbcGMBf5 (ORCPT ); Tue, 12 Jul 2016 21:35:57 -0400 X-AuditID: cbfee68d-f79876d000001436-9a-57859af412aa Message-id: <57859AF4.1020204@samsung.com> Date: Wed, 13 Jul 2016 10:35:48 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error References: <1468332502-28016-1-git-send-email-k.kozlowski@samsung.com> <1468332502-28016-2-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1468332502-28016-2-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42JZI2JSqPtlVmu4QdsBa4uNM9azWrx+YWhx edccNosj//sZLY6vDXdg9bhzbQ+bR9+WVYwenzfJBTBHcdmkpOZklqUW6dslcGVsXryTseA3 V0XLnetsDYx3OLoYOTgkBEwkDp1j7GLkBDLFJC7cW88GYgsJrGCUWL1JFSJuIvH5UBt7FyMX UHwpo8SJax8ZIYoeMEp0nK4HsXkFtCQ6pn0Ca2YRUJU4vbIRzGYT0JHY/u04E4gtKhAm8WDd XlaIekGJH5PvsYAMFRGYwigxZ8FWsKHMAhYSW7euZgexhQWcJa7cm80Isfkmo8S79d0sIAlO AQ+JS5/esIJ8wCygJ3H/ohZEr7zE5jVvmUHqJQS2sUtsP3ODGeIiAYlvkw+xQHwsK7HpADPE Z5ISB1fcYJnAKDYLyU2zEKbOQjJ1ASPzKkbR1ILkguKk9CJDveLE3OLSvHS95PzcTYzAODr9 71nvDsbbB6wPMQpwMCrx8M7waw0XYk0sK67MPcRoCnTERGYp0eR8YLTmlcQbGpsZWZiamBob mVuaKYnzKkr9DBYSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAuF/z4krD0yuS7t9+IbH/aZxU jsyS709cHvAKr9KVWuxkeqK86iKH7jyfK7ukORtrZocxuT+z5Px/SvaV53a1XxVPGmIfrYnO cteS9NpblBJlfk2UudZdb6rU/YcWZzQWhJ49Iia1ehrTrCtdz8PecLJ/2NJz4dzdE2vjWjqq f4jNMzikEBu6VYmlOCPRUIu5qDgRAHVTSNmeAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFIsWRmVeSWpSXmKPExsVy+t9jAd0vs1rDDU7fMLPYOGM9q8XrF4YW l3fNYbM48r+f0eL42nAHVo871/awefRtWcXo8XmTXABzVAOjTUZqYkpqkUJqXnJ+SmZeuq2S d3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QRiWFssScUqBQQGJxsZK+HaYJoSFuuhYw jRG6viFBcD1GBmggYQ1jxubFOxkLfnNVtNy5ztbAeIeji5GTQ0LAROLzoTZ2CFtM4sK99Wxd jFwcQgJLGSVOXPvICJIQEnjAKNFxuh7E5hXQkuiY9okNxGYRUJU4vbIRzGYT0JHY/u04E4gt KhAm8WDdXlaIekGJH5PvsYAMFRGYwigxZ8FWsKHMAhYSW7euBtssLOAsceXebEaIzTcZJd6t 72YBSXAKeEhc+vQGaBIHUIOexP2LWhC98hKb17xlnsAoMAvJjlkIVbOQVC1gZF7FKJFakFxQ nJSea5iXWq5XnJhbXJqXrpecn7uJERyvz6R2MB7c5X6IUYCDUYmH18CuNVyINbGsuDL3EKME B7OSCG/ZNKAQb0piZVVqUX58UWlOavEhRlNgIExklhJNzgemkrySeENjEzMjSyNzQwsjY3Ml cd7H/9eFCQmkJ5akZqemFqQWwfQxcXBKNTBaLX56mSecq46P9Z96Q+nv2HN7586/x2Mmu36D dbL4pfqmFysig/ln6jm/y52bs2RZeOVlO805k1zWhx456nl9huZJHb3dRRt6Su0//sj1/6ma vpD/zMa/Pps+H1Q5/nGmjPDVxSoXavfr7Hy679/krvf7nrUszXaVv1ZZ86hk6zU/odj0mWtZ lFiKMxINtZiLihMBelrLqe0CAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 07/12/2016 11:08 PM, Krzysztof Kozlowski wrote: > The commit 97f659a2e972 ("mmc: dw_mmc: prevent to set the wrong > value") reordered the code so the 'uhs' variable used in > mmc_regulator_set_vqmmc() error message is always 0 at that time thus > always printing 3.3 voltage. Instead use value obtained from ios in > printed error message. The commit 97f659a2e972 was dropped because some board didn't work fine. Some boards didn't use the vqmmc suppy and not defined into device-tree. It's short time to fix. I will re-send the patch on next. At that time, i will check this patch. Best Regards, Jaehoon Chung > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mmc/host/dw_mmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index c2a128628b31..7de561065003 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1416,8 +1416,8 @@ static int dw_mci_switch_voltage(struct mmc_host *mmc, struct mmc_ios *ios) > ret = mmc_regulator_set_vqmmc(mmc, ios); > if (ret) { > dev_err(&mmc->class_dev, > - "Regulator set error %d - %s V\n", > - ret, uhs & v18 ? "1.8" : "3.3"); > + "Regulator set error %d - %s\n", > + ret, mmc_voltage_to_str(ios)); > return ret; > } > >