From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752563AbcGMHzz (ORCPT ); Wed, 13 Jul 2016 03:55:55 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:42434 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbcGMHzp (ORCPT ); Wed, 13 Jul 2016 03:55:45 -0400 X-AuditID: cbfec7f5-f792a6d000001302-1c-5785f3f9de8f Subject: Re: [PATCH 2/2] mmc: dw_mmc: Print proper voltage on error To: Jaehoon Chung , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1468332502-28016-1-git-send-email-k.kozlowski@samsung.com> <1468332502-28016-2-git-send-email-k.kozlowski@samsung.com> <57859AF4.1020204@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <5785F3F7.6060708@samsung.com> Date: Wed, 13 Jul 2016 09:55:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <57859AF4.1020204@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsVy+t/xK7o/P7eGG5z6LmmxccZ6Vosbv9pY LV6/MLS4vGsOm8WR//2MFsfXhjuwedy5tofNo2/LKkaPz5vkApijuGxSUnMyy1KL9O0SuDJ6 dq5hKZjBVvF8z3fWBsafLF2MnBwSAiYSO85NYYOwxSQu3FsPZHNxCAksZZQ40NbJDuE8Y5R4 dmE+I0iVsICzxJV7s8FsEYFeRokXd0Ihin4xSuz+OpkdJMEsYCGxdetqMJtNwFhi8/IlYCt4 BbQkTje0ATVzcLAIqEpseuwBEhYViJCYtf0HE0SJoMSPyfdYQEo4BbQlFtzWAzGZBfQk7l/U ghguL7F5zVvmCYwCs5A0zEKomoWkagEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkPD9 uoNx6TGrQ4wCHIxKPLwrBFvDhVgTy4orcw8xSnAwK4nwnnsPFOJNSaysSi3Kjy8qzUktPsQo zcGiJM47c9f7ECGB9MSS1OzU1ILUIpgsEwenVAPjef73L32kznq5rf5+eMl6pj9sN/20J8Rz vpo5Uev2IuEDao2f7uyRms7MPVHiA6/z+oeR1fL8p/dvaP/nxHBaoXDqzUNr9y18Gte5p3bC wrCVF08sapmw/gVvx28J6WXdPU3PL7CpOpQlF04u3lVUOuvE3z8f/xbef+xxpfDHz5kmDhVX Ns6MUldiKc5INNRiLipOBAA/PWlvWwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13/2016 03:35 AM, Jaehoon Chung wrote: > Hi Krzysztof, > > On 07/12/2016 11:08 PM, Krzysztof Kozlowski wrote: >> The commit 97f659a2e972 ("mmc: dw_mmc: prevent to set the wrong >> value") reordered the code so the 'uhs' variable used in >> mmc_regulator_set_vqmmc() error message is always 0 at that time thus >> always printing 3.3 voltage. Instead use value obtained from ios in >> printed error message. > > The commit 97f659a2e972 was dropped because some board didn't work fine. > Some boards didn't use the vqmmc suppy and not defined into device-tree. > > It's short time to fix. I will re-send the patch on next. > At that time, i will check this patch. Ah, okay. If 97f659a2e972 is dropped, there is no need for this patchset. Best regards, Krzysztof