From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752912AbcGMKdA (ORCPT ); Wed, 13 Jul 2016 06:33:00 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:52964 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752582AbcGMKc4 (ORCPT ); Wed, 13 Jul 2016 06:32:56 -0400 X-AuditID: cbfec7f5-f792a6d000001302-e0-578618d08736 Subject: Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular To: Michael Turquette , Stephen Boyd References: <20160704211220.5685-1-paul.gortmaker@windriver.com> <20160704211220.5685-8-paul.gortmaker@windriver.com> Cc: Paul Gortmaker , linux-kernel@vger.kernel.org, Tomasz Figa , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org From: Sylwester Nawrocki Message-id: <578618CA.8090808@samsung.com> Date: Wed, 13 Jul 2016 12:32:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <20160704211220.5685-8-paul.gortmaker@windriver.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsVy+t/xK7oXJNrCDSYtVLX42HOP1eLyrjls FjPO72OyuHjK1eLa3uPMFj/OdLNYrNr1h9GB3eP9jVZ2j8t9vUweO2fdZff4vEnOY/2WrUwB rFFcNimpOZllqUX6dglcGb8v7GYsuMJV8fTOO5YGxuccXYycHBICJhL7Fr9hg7DFJC7cWw9k c3EICSxllJjWtwjKec4oceXJY+YuRg4OYYEIiSf9diANIgJhEs0L14M1CwmUS6yevY0ZpJ5Z YBujxILrd5hAEmwChhK9R/sYQWxeAS2JeQfbWEBsFgFVia83boI1i4LMnHsSqkZQ4sfke2A1 nAKOEvt/fmEE2cssoCdx/6IWSJhZQF5i85q3zBMYBWYh6ZiFUDULSdUCRuZVjKKppckFxUnp uUZ6xYm5xaV56XrJ+bmbGCEB/nUH49JjVocYBTgYlXh4Vwi2hguxJpYVV+YeYpTgYFYS4bUX bwsX4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjtz1/sQIYH0xJLU7NTUgtQimCwTB6dUA+POnyf1 rxzztE8XDVohsZbD4Gt5a751xrUah1XfP7HJem4PePxw8x/vVMPeyhL9oKcTT389tVL1zeU5 76IOTeNUmTJl+hXBJUtEmpqc5rJzXZV2UP32ke/jzGTni5sfC/oHfOs2yyrZYqH0debtO//N llj+k0nceer6gxVb3Cy+6/5lrijcmHdciaU4I9FQi7moOBEAMYxwQ2wCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/04/2016 11:12 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > arch/arm/mach-s5pv210/Kconfig:config ARCH_S5PV210 > arch/arm/mach-s5pv210/Kconfig: bool "Samsung S5PV210/S5PC110" if ARCH_MULTI_V7 > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since this code is already not using module_init, case, the init > ordering remains unchanged with this commit. > > We also delete the MODULE_LICENSE tags etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-clk@vger.kernel.org > Signed-off-by: Paul Gortmaker In case this is going to be applied directly to current clk-next: Acked-by: Sylwester Nawrocki