From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbcGMNwI (ORCPT ); Wed, 13 Jul 2016 09:52:08 -0400 Received: from mail-co1nam03on0096.outbound.protection.outlook.com ([104.47.40.96]:56928 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750959AbcGMNv5 (ORCPT ); Wed, 13 Jul 2016 09:51:57 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <57864732.4080901@hpe.com> Date: Wed, 13 Jul 2016 09:50:42 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Pan Xinhui CC: , , Subject: Re: [PATCH] locking/pvqspinlock: Fix a bug in qstat_read() References: <1468405414-3700-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> In-Reply-To: <1468405414-3700-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.165] X-ClientProxiedBy: CY1PR14CA0030.namprd14.prod.outlook.com (10.163.13.168) To CS1PR84MB0310.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.28) X-MS-Office365-Filtering-Correlation-Id: 82cdc76d-23fa-477c-3187-08d3ab24b2b7 X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0310;2:ujD36oCGDRjNdt7FuFmo17FRrxVpPZbNwnVKKomXDsKXX6lfhTJ6Zw9KGaDyUYzoT2vYV3kYA50XqzBCySeWOaF8IDs6aO/Ow/km0qzfU1xTYC5q64Ctyy19QlRUPseqwhB8uFRvuu0VcVIrBBXEY6GcnPh6Ltx9y3x46d1bC7Gn7YqwfSFyf5wJdX0Zi0ND;3:EdH7Px2J9SA6OKgg3QFVlvrzI5W6+ewQMMg+dMY/nlwzQ5XRSXOQ77128Djgf6bl920KnraXK91RxXXQcxEAFywI7oysmE0T54HMUq8D0uipb0fHaHM5gNQyE29BB+Ka X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0310; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0310;25:xCqe3H0cTcgnelSDMmVi84IsuALFQiOS4NGKmbN8bk0xJO7Qcytc4O55jEj6uCKxxaWEzn+87sXIDQUawzNjpq+7+LOe3pcmJWf4jTtNqfzItIK64TC4EXgKfXJc8IWfIP73/O92aEZKOMdDElCKc9makC3SUkG+ODalqWxK8sSLMF1qYQpYdEcgEZNmBf31COg9Rx1ydQzAfDJy9TXE1zAPYRX/9rayIifAI8OS1/6F4fK97Txrj7BywSLPENzMXznrf+q08p6M449EzMYJB45HQ5lHMPiR6b7UGQIxiPkwed0HdLcW2wNyyk81EWgLChwiPw2gn6xy7qWXqZeK/lx+GDF0NldYhMWMJ4zvRI2yb9YzRjPZr1rDfObR1qFPfMdJvUICDFKVtB040cl2kTxAclxBWz5eYfoRZCcj+cPq29l97VgYVu+P3oWv9Vk0504xL+NtCbZyk8+Xm9jMKKt+O3pL0tWzOOn52SCGswzW0EezS+J3w/1PrKmjgmQ/aGUIUnHbqlmZBbbnrmAR8k+fCCS6n3isD66OFi3rwHghyKyafLIcIx4gvREpxGmkR3mKRrhu4yCBvHk/Ub6hAZ47rmaRnQ1E35ej40fewCCzqU02ws5x1ZCKXBvwWtrM8e9tYa5b00G/hJXAYergf7hIFRQodWrCvm+2rf4gMedG5mC85UnbRCcEghpYVq9SDSb9NxfbBPmhy0dkbWt3Rg==;31:nMsOHXwv1ptcvVjwOzc1AEHRq9dZ+NOsfJ+qIjfFe9tJRhaSLNxvt3nt8YIssNpgIih5TDKF8H6ukloRMF6WUGFKnm6I9cjSj2lBu72czoOugY2s+2if2+oUsYSYClQbpN2zEZwXqvPt+zyY0hsx5NMt7jZ6WDEslRbWo1OVrUi/x7lCs34umfr7/LgEFzL/hW7HiVXZGA5IgjLL/NpDnw== X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0310;20:EPzV3Fw8sWpaZAbFKaD/go5jjzp6rMmm8p0vS9RtE/Ta8GvT8KDXvWT50VU/+ARYFligRSq67mgJqcUrQo6PzDAYuxM1ICILDclxJ9CZjreaOZd/LrW2W4rOGXQMDb0WmfSr1YIj43LxyqAcudQ95NNfNVFzzXj9v3cY/5+j7Eyllhgdb2tR3nbtpTNZIGLxC/aLeGQlpJ3URs/phOPZEtpvyoXJJKWyvc/I4g0pLdPbir4lnt25Zgxo3wngRVbaE1ATyfFxdhiu76ZduW+N7peOmh77BDlL8stnQjIZCvWCuZphU+MyHdkboqQqzMKZ1na0bh4QcwDrB750ERJg6FpAKlzMzXBioBtnLkYe4U+ViFOA9NE9QULUxn+/XZjky9KljMJu0IOBreBsEV9x2ndP16SqigwV8i4Y1FWQnbCxdC0i59i8UWJJ9gBy467/Chkt6N92jn4BBxjS940ePOAeyh5bRG8TGcVAHK2Cc7U5Q+SNjJhsicY6HXgUGUUr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(227479698468861)(104084551191319); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:CS1PR84MB0310;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0310; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0310;4:C/QC3zTndBRYEtqOMcx57592YYJofITCTevbbQbvaWW0kDtr4vdEcacvl4dvlQD2eqC1ksS77N9tfaVifLBnO6uxePS07nIvZ35gCt7eZG3WbZ8rUWSH1X+cSXMuR/culHkIVu2QnLC7CJGq1wUEzovq7ii76m0f3lslOlVx/XgKkh3k1yM1Joullp5z3p3EcKrIA1eAk6t4q6UqPxy01yoXiABhfEE2wPdL3r7HpoOHYYR6ZGnzj9Kvf+j4SP+z629RwC+WnV9Ph1Y9hj1UpNK6BcPk/US8asIeQcZVSFudn7RlKh/kMdrroPM1kysV+Cybq4Quf816nwHtikcrYqMEXg+BXRTU2jfMejdNs4MUCMMcGJ+WwCOdh/PaOEsygioWlY8vYeboJlPnOSLwAZvtk4SKtEHYt2Dt8mQIgSNajJlzBFhaQRq60DUxdI5ivxAJ1w6Lz1xLn+77A5sdJw== X-Forefront-PRVS: 000227DA0C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(377454003)(189002)(24454002)(199003)(50466002)(2906002)(3846002)(4001350100001)(2950100001)(106356001)(65806001)(68736007)(76176999)(54356999)(66066001)(65816999)(50986999)(65956001)(36756003)(117636001)(87266999)(8676002)(6116002)(105586002)(99136001)(7846002)(110136002)(7736002)(101416001)(305945005)(92566002)(117156001)(189998001)(97736004)(83506001)(81166006)(86362001)(81156014)(575784001)(230700001)(19580395003)(19580405001)(64126003)(23756003)(122286003)(47776003)(4326007)(586003)(59896002)(42186005)(77096005)(62816006);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0310;H:[192.168.142.166];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CS1PR84MB0310;23:mzZvUwuK7T2C6fSdS3ObVO8szDJp/+OqoS2wfqZ?= =?iso-8859-1?Q?+EoHj95u4jxxy77ZgWN0vhZEClf2MtZT9NILr/CuUa2sUM/15p4Gr1vBXe?= =?iso-8859-1?Q?RsHaAVi1O6G6oKTpHjlftMm29OoJhL47wfTdty5X0MtraBTNpq3/XT4i0Y?= =?iso-8859-1?Q?Ez0DHjuvaNOJkePGMIXJyrGX3Ooxb7eReK+G5Bj2eUrS3L4tWH4E9lA6GL?= =?iso-8859-1?Q?4Nyw1EvCrt5X7Q3h8CWzFjob+O8xnCrMVAKm0SHdXA4dwcTZpkbOBBbyZS?= =?iso-8859-1?Q?AjWUg44PnAoxxCZDOnzAB9mTQDE5/6v9XKdC//dQvw7GOByF0/ywSarl1v?= =?iso-8859-1?Q?0tevLKh8xrzuls1CYRu5tCQV5QiVkEUqJVHeKqrGmYhHjhqqnXylPLm8R0?= =?iso-8859-1?Q?MwlE0XUXwU7A1lwNql/jmQyUkEBPp8b/EZgksPkK9vdL6bdYS2ein3I3It?= =?iso-8859-1?Q?+O+px8Gz6hNgDq1q5Dp7ZjRGwPQY/k8bVddaixje75m8WQeWlO+1Ly+YK2?= =?iso-8859-1?Q?HJ7lkNuiwVPN5HrM+deAm0/ENjByrwXujB7LjpM/UIKtiRbc7tkHKewGBV?= =?iso-8859-1?Q?oEZfMGfRZuP5548PjHINAeOfIzLfH5YWaE/uzbl/Q2k6YX7h9VjrPS9R8+?= =?iso-8859-1?Q?RmHMrmZCip1rwWr8oPp0wgVQnzr1d5aqiKX8Z0/6tyye35p19TJ3E5okVe?= =?iso-8859-1?Q?mnjRoknJeJUoULLbUBbncwyX0lhzWo6hgbyrIQm8kXZMOp7FxRLixpvvEu?= =?iso-8859-1?Q?Pfc3hqplUZLGotcRrvFQez/dkJb3J3szY+wY7CxNz+pLca/XR76VXBEw2z?= =?iso-8859-1?Q?+1gg9XE4i4GiBin0+NZQUrZ84FkRzvPB9ps8peDoF7EM/4MHpf5meHykup?= =?iso-8859-1?Q?q5g1a0ynB+dlG5C8uDYsBWJXllPa57SbPSLzY2k+pa2/cC0w9eR/cLbfy+?= =?iso-8859-1?Q?d8MusxGkmQiTLrVkZM139+1bWLZp/GsKIFQ1YhMz0mHDXBGsz0yktAi3Kv?= =?iso-8859-1?Q?uSjenEUCTeYAXJr6TYilwjwY4x7C/eKGKIdkfojjy4y+IrUvfajIIRtiJ1?= =?iso-8859-1?Q?T4Hy4qAT/LJd5ubw5y1EvuYwd80NZmoUy51BT/OEjz5uuB4XtgINMQBR1F?= =?iso-8859-1?Q?8bzbN7C7U2TyzG6XNiNsj7HUUARmNm3vNqf3U+kixjBuaP8B1gDvjnk55r?= =?iso-8859-1?Q?2X1cdi4+es7629xv1FiSpy7JqUyGsyftgjmF4VPFyDFRqi3SMTpnb0fGpZ?= =?iso-8859-1?Q?6ZEeSOhm1ZfOPlWpBvMhJJdCvx9OsJy4X56R+9v+6O6AKhy2zJBLnalDH6?= =?iso-8859-1?Q?RlVa8+rqM60K6etJdZnUxaUcRkSuVf8Yosira40cPoXBV1Qz8g6iCfhsnv?= =?iso-8859-1?Q?olZqAwfXbHv1fZTZdxGfMjOq33QOOcZW3IwQLwMMx2qrhuxYHoGR7j4VEy?= =?iso-8859-1?Q?uxy5UKJNIjPBAY=3D?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0310;6:yw3rtaGXgVGDdtIoicQIwNEaKgFBHY2e9/KQS3u26i7M8IKPY06IExxLhRGgVcPFV8PZbjjahAg2hwZkCl9yxdcjWBLRdnoRwRQ2XjDZ1jmr1ytfhoFcRWpXjsckV8tTrNj93TUykpunNiC05RIW8YKSOe9sx8KPLW8TJwtpMOV1eHbg1smvGQCUrsqDAh9AHmvIR2T0+GBj7MfN57JoEQAZDFA9yb2XVeao+ez2bijq5+CchmLZxK9TZSNY7h38O/I9bs+1K0BntRUTW6xFG0rglLQt6S4ZoS1DueopKHNlSVF9DreaSXu+mcuntRt4pgQ5/RuvFaE7ha86a/Sflg==;5:zJod5xc5ln7aM1CDI4HNK50BN5VZaxvzrM2speK9OozoNwJW3Xw6qoY7JZw9SrprMQX/JVhAzBLWWf7UJppqShoTV1czPm/OLZ43KAlkvYmHq4hQCxavBuCii4rP+V+8xAT/AjK31pYR2MxPuUp/VA==;24:GoPXpdxT1LVzrDbOBrAXE+DhFqyS54LM1Uc/PuTK/UMzWd6P/3w6kW2kGQ1vjFZF+Jmu4KLKD327/WfUlo7PnPUwMIttayRrsZd5n6WfvUs=;7:AjpdwoKYeom4pKB0ngQU1RK1U3i0+a6WGW8YQeNOrzL+KoryXt8nsSmkEKNBZ1T4z32J13ngiWxapPhEqkNWU1uxRtbUm7BZ/4+HCN1z8jkyYLj1WihqgWVWL5Em/GSC1JgkmmL792LOQUuO+JDwgCRnky+2NSiYr7vnFQtkxOj+OABYhtWVwiLImy5qWftn5pjHBKmDfXOodWKtinoAm7vtszahPAO5g2FyqVx7oC3JvwQyt+q0f+DaITMgQnqD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2016 13:50:48.9539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0310 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13/2016 06:23 AM, Pan Xinhui wrote: > It's obviously wrong to set stat to NULL. So lets remove it. > Otherwise it is always zero when we check the latency of kick/wake > > Signed-off-by: Pan Xinhui > --- > kernel/locking/qspinlock_stat.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/locking/qspinlock_stat.h b/kernel/locking/qspinlock_stat.h > index 7b0f1b9..8fa1165 100644 > --- a/kernel/locking/qspinlock_stat.h > +++ b/kernel/locking/qspinlock_stat.h > @@ -157,7 +157,6 @@ static ssize_t qstat_read(struct file *file, char __user *user_buf, > */ > if ((counter == qstat_pv_latency_kick) || > (counter == qstat_pv_latency_wake)) { > - stat = 0; > if (kicks) > stat = DIV_ROUND_CLOSEST_ULL(stat, kicks); > } Thanks for catching that. The statement shouldn't be there. Reviewed-by: Waiman Long