From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917AbcGNV7M (ORCPT ); Thu, 14 Jul 2016 17:59:12 -0400 Received: from mail-by2nam01on0077.outbound.protection.outlook.com ([104.47.34.77]:55264 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751210AbcGNV7J (ORCPT ); Thu, 14 Jul 2016 17:59:09 -0400 X-Greylist: delayed 10810 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Jul 2016 17:59:09 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Message-ID: <5787CB5C.80508@caviumnetworks.com> Date: Thu, 14 Jul 2016 10:26:52 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Javier Martinez Canillas CC: , , "Aaro Koskinen" , Aybuke Ozdemir , "Greg Kroah-Hartman" , Cristina Moraru , Laura Garcia Liebana , Bhaktipriya Shridhar , David Daney Subject: Re: [PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module References: <1468515969-14805-1-git-send-email-javier@osg.samsung.com> In-Reply-To: <1468515969-14805-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: SN2PR07CA003.namprd07.prod.outlook.com (10.255.174.20) To DM3PR07MB2139.namprd07.prod.outlook.com (10.164.4.145) X-MS-Office365-Filtering-Correlation-Id: 4c90c621-b811-46a5-fd0f-08d3ac0c0d41 X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2139;2:JEMTLLy7KRKIZFDGhYFJPq4+jPdif7XH8YQUVXTwewarc9YnX21OtziCo+zW1I1b513oCIc4dKGg28sDaWHDA8baBJcvzwLmO57mNPX8fOLlFgi5KrLr3OF2jcMB1oLWe+QTedAercxqRXI6Er2fT4wuFc48PDbu2O9Y5Qg+iH3NQEeM1cY2X03G0FbxGjV0;3:DG7osWrXLinm6rdtSFJQNlMniFwqm0WR2fJAkpN1Kb77o4iGBeZO0b7x5OYoBFaKyJ5plkACjp/i2WgT73ifqwl0K9vwpGPYS/claLkpSr9EWrUqcspmzf7jKoGaKcqj X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2139; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2139;25:NOqIlS8YGH+bqQq2ahj75wnYi+9qO++VM9ABKC8zuFIAar29lnhhsubFMQNBSBWLyrxJQZbvDGgC3FC1M+rSlXo/zLDPh5JofuqSGm0DxACLRPxQsp8euBUrv3h00ZNqOl6WTzCLZREsLPyeF0io29r463nWOIl2Y2unEVVm2HqmdM8TJLQj0sbC8AXQITPVaGg5zR5VZozBIyuMdYPwvJ9KCHU6BApHSfbbGGHlulgPVJUXs7wmbZ1Rcv9XxP/2AKXzDMHJedGlvdrMgjCg5M5Jxoqch4VPF5S//3Ah+LqeNClEzyYiCqnmvaw/hxClkzfeIWpANSjjpS67MUtzB/gDl+h9/vccB1TDLDh2mzLl6JSLAPr/Umx7lrn0FQBYe3PuzlkOm9Fc2/nLDGhYVg/AwrE/78ApH4DJ9YjT5/SgpNTaHG2oKVBpvX/ezr9MiwEd60BdcFPU5ymhsYVB4Ii5YsmZQP1loXpkbzLKhwltlQx/7gc6H1nYBOsmHanusgA+kAfq17B7mqd9YiYeTvqrCIUA89n0e27EA0o2uxLoUZqIvT8ONqVxp9oBdrhGCpI370tOrw/Q4JHtHGiFe0fWtNFnoMX6f/W7g7che1g9ESHq/StKX0SAnePjYR+MfxpiqnPPDfRPRkienM2CqgJ1Ueq5FjE+TD9U/AaRl1oWGKPYlia+kpN676+qB1rRW+tq/hdvUF7R5suAv9C/Q2cl4TH/HS/ex6SPo5WS82mvsSyqRqreOKZAlSqK6wBK X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2139;31:YRaf8AwSNQdDeR9+bUT6yy9xNFLDzdgovq/aTVj6b2n+he20BeKn64Q4YY7kIYbEDHiA0xyg2not26JWg7TUPj54edCWTKh7h+eftrdZepoBTERgGpZCltW3mBu+qAgm+NNxZQT/CUDeaj+dxUwMZgFtOu0yEq+wyw2hkIh9QG5ISt+NslnjRmGeHJFRN3deQ6QyDbvcKjDyjpgrRvCqNQ==;20:9s53+IjDi+r7jVQa1ViI7gFlCctV1JT+4TeeI33msZg1da3K+amMaGavm2WQwz5Wh22KA5n5xWPqhoqUjhoQepENaGxj2EBrRhZmS9RRHpEXJKCo6NeletoGICmse1AJFe6SXu/MMFMn12AP9AIk09eDzLJZvwFZ2H6yJisb6pmokL6pRYWkUrh1Yal4lWzJv53QSv6qkV21auxPCKEoWHyB+6P/uX9KxeYeVcB6CmJeeejh5CwoDYlY7SeMmJ5nUv/V/U+5fsqOjrLfWtkSH8LrezYRlwWZGPOS5PGTMwO86ND1QYEsi7xMJnrypXdsgiqqCDIjHwI4LcFtBkOT5jThZn2ozDagS0z0ABoYhYZzUjdBLCxf1nP3t12nQnCVsrIKvxuuHn2tx5+4LwUYsjxuYne2UEAo0RsN9PHGoxV0lC+GP1cU/5h13TbkosufJpLB4zlvX9uYNGPe8IMFvUAR8k5n+fI7hT8lwr0l/rrcYF0HkHvDUZQwUgro4HiWFAmmNSm4tcSiIPZzQ5ntK9oHXgZ5KvSDkgji3lmMHoPWIUxAnVlzO0FkkImnGvGAb0bu4KJjaztWE3eDoXSllFJPQOTYmzFqmD6c16UzF1Y= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(7411616537696); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DM3PR07MB2139;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2139; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2139;4:9Dru3LV8Qtppg7o8V8Zk2x5DqVyMh/aHxtshbM6Jy0yQgeouzG665alQpsLAf7nomrPFRnzJ0jkj72GrlR1WVAresdtpimoVwhzAqzfzUlUNIK8UTNCPhQAqqsl0fu3AeLlJPGTr3eT2CGdnsSqtHn7wIFzRrvWs0qqF4l2cqruX8MI366cBKg5of8TkToZYNmU3DldcX8rPrk2kv5L3B0YS8I2WfcVkseLjn89sq6ZomLiNujVmw0VMFGuiLSjaeqwJ70WyAEACxa7Ipad170G+CwRdLwADf9IpXTpwwoz7YEgmBsFR5oAGS1iFTR+R3fMMxMmYITqr3M2Jxue/8gLv/UKTtKfmHVIlrKjHVSrfxO1hf50Jn6sTxGYmPX/ny81P1SVCPC+213vi0rvLHtd3ZBJEDjIRWoFBRye72ho= X-Forefront-PRVS: 00032065B2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(377454003)(199003)(189002)(24454002)(66066001)(23756003)(110136002)(69596002)(64126003)(36756003)(2950100001)(4001430100002)(65956001)(83506001)(47776003)(65806001)(107886002)(101416001)(81156014)(8676002)(54356999)(76176999)(230700001)(3846002)(106356001)(50986999)(575784001)(97736004)(586003)(81166006)(42186005)(77096005)(65816999)(4326007)(4001350100001)(68736007)(50466002)(2906002)(105586002)(189998001)(53416004)(33656002)(7846002)(7736002)(305945005)(92566002)(19580395003)(19580405001)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2139;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DM3PR07MB2139;23:xH9Kc5B4fp323hYbem8OUJSRXWCIxieG8v/of7K?= =?iso-8859-1?Q?RWBlbCZd8VGa2ropLXSLgeCZCYdXRbFuTAl1lA0L09ZFkfi0naupFML24o?= =?iso-8859-1?Q?uN0vXc6SGe5C4eC3ZlE1YxPEAxU3q3IDA5bl93aQOTjppt1+x0lz6duVWF?= =?iso-8859-1?Q?vZ0FIjBb5g2Wk65H2BOksNx9/jwt7PAK+QHVy+wDIV58VBsKlXPE6Azcgx?= =?iso-8859-1?Q?5JB9N5ZxGj/UEZ8ifFx3q2EbASc907mTBLh2OXWcjh1QhcWl3kiDIPOi9g?= =?iso-8859-1?Q?zhRxYOYgK3DZGU3YRX6LQ+y6pJbV41I0SF8CYs9MgbxscV1MNCC1wJ1tDY?= =?iso-8859-1?Q?pBvz5m8mpmoRLeo8s0S1wCaDKZt5mRG0uf2v9dP4LaW9NbY5PesYoi83qZ?= =?iso-8859-1?Q?ZB0k8qKpAwb3b6dEjir2odYcLvOPPgX6wVRNK+qytYBDNKesLTWjpUMyOT?= =?iso-8859-1?Q?/SkIftOt7pawEMp+sSOWx7o8aL2QqkenXB4dDCZZB4+bt1w6bzHhE4uX13?= =?iso-8859-1?Q?pibFiUXTUkQPR87s6Ib4mWsz261f7DLKYxMX7dbIRq4DgF4v19gdb5dslp?= =?iso-8859-1?Q?XnRiQ0hIfd4T5GLP1x6OHHBEQZbEQAE7gnsrf6KwFJmxhEh4SMBkrrCWC5?= =?iso-8859-1?Q?M4JIViNte0iw8HJn7bhq1KAvl583eH9yZB17SOdAPf7UTKTwkcNZ/5nNAx?= =?iso-8859-1?Q?cDA+cEiaAEDw1B/Rra5UytfEkBYBNGFnp0fzp2ZuKEHtCTOedXwRA5HquD?= =?iso-8859-1?Q?yjNOQ/6dDP+xSpr131rneiVipmekFogMqN6vCOT2nXXv9xHO37SbyXcIEy?= =?iso-8859-1?Q?IgWn5UH1HaDMiGa9IL/P83Fsj6jnlE5gqbO8ZCvNeMEGAdxYJf4nMCU7MW?= =?iso-8859-1?Q?ChWFDC55ONghNqdWA5HCU5EDDSUKA/XunrnEr9caAPG6AH8B/1v9wTX2tP?= =?iso-8859-1?Q?pGRK9nA/ilddDic7XfBShHD90hBe1OsDBfyru7ohOQkKzuJ2tISPB+UHyv?= =?iso-8859-1?Q?cMi6htL/zVFNLRZ3iYP0MFJXSuss3Qtz+KqwDLNLPwhGmeGqt+DpYL5213?= =?iso-8859-1?Q?yR5qsxyJfwXhAH69TidZ7SH9mULA17A/vcrv5NgnstO9n2XmDRx+m8Yt1n?= =?iso-8859-1?Q?PhlRta5/cAsfR85kv1eQIqg/p1TY6SiVtLk2SRjrq1sXD6488Wnwx3wS31?= =?iso-8859-1?Q?fQgf6in605LtX5t/pW7CRn8QgMHDB7lrCxp313+t5YHQ9ysNnr+0mXU00U?= =?iso-8859-1?Q?6qiYzrvCaRsFgG/WjZVYj1wHfoihzGwJgBMH8pYulY9Me1d7zpULV1NwGf?= =?iso-8859-1?Q?jROrRZLlKFwcLvCCPXjBhFqwoUvU0JOPbuR3ky8x8qzRB3pRiRwMDrFo+d?= =?iso-8859-1?Q?+2CYJq6U=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2139;6:qZa2MPrrlkMKim+JWaHKcyR6784j4cUZ/Knnxm6TpN4GnRqqd5v0Ed24WvOzrAEanVyF0OUpumsjzTxGnk9o7CJeZKSg4LKi1+gJVx57gYjc3tu05hA8+Y+F2h7ud+HeCbB06Q+bUtOHrSjBAoLcahhaZ31JuHWnaC1f/gDOD93nzU5Dc6Rfx04P9JzFCRXqql7gyX68hBDg/4WdMNgWKgQyoXrTXu4ZKriOHcaXW0FZn317ZTx8gp2cE2TVoubNOo0vO4jI4YM1tLpVCDwyn0mA+UuAWengwZWfHMefOT0=;5:pTgducBTTyVaKE8UlfRzI7M7SPY0iMXOeR0uwd6DGyfRRVp8n/b8JSInkHgomCgwnQ83WyIWWprv/Y0rys6H0Feppw+wuj7n9RWG0x8of4Xj0sUVXtWW3OtU89pxmx0hYvavp7TbwthcR2p5EqHbMQ==;24:aZ0HsHRWWW1tvY0GZWraRB5FN5IHhVF4CqXhz54szG5QxqpWqLkCA8iyfK7va+ok+jDE3ty6UmMvg/JKN86+ybkjdYF4kymMQ4P1jqGbWYM=;7:aZS0nDiB+nKhzA5GuwDXzzUsntnO3v9aImglNQJRmzzjvhR2vEKN8ScdH+S3ZkT3Mq/tk/P2lOO50PbhYeOq8cXU6Ye0xCiJg+xgqMYNZFxba/RNpF73MnOn2RfFkU+wMgWBBqdKJX1NaPNx0a7NJGCDi97h+uPzEJc8V9aLx2RWTdMp+/Dy2UFthNp2m3G/MGRJCTZeT1uSXkyd/3mUWq2kjRdD4DGncGdGoTS2LAOK2gUM7dIgI31KX37XMT0O SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2016 17:26:54.3178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2139 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/14/2016 10:06 AM, Javier Martinez Canillas wrote: > The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either > built-in or as a module, use that macro instead of open coding the same. > > Signed-off-by: Javier Martinez Canillas Acked-by: David Daney > --- > > drivers/staging/octeon/ethernet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c > index e9cd5f242921..c0c62143ffc8 100644 > --- a/drivers/staging/octeon/ethernet.c > +++ b/drivers/staging/octeon/ethernet.c > @@ -238,7 +238,7 @@ static int cvm_oct_common_change_mtu(struct net_device *dev, int new_mtu) > struct octeon_ethernet *priv = netdev_priv(dev); > int interface = INTERFACE(priv->port); > int index = INDEX(priv->port); > -#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE) > +#if IS_ENABLED(CONFIG_VLAN_8021Q) > int vlan_bytes = 4; > #else > int vlan_bytes = 0; >