From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751641AbcGOBTy (ORCPT ); Thu, 14 Jul 2016 21:19:54 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:14335 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbcGOBTw (ORCPT ); Thu, 14 Jul 2016 21:19:52 -0400 Message-ID: <57883A1F.8070600@huawei.com> Date: Fri, 15 Jul 2016 09:19:27 +0800 From: Xishi Qiu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: David Rientjes CC: Andrew Morton , Vlastimil Babka , Joonsoo Kim , Naoya Horiguchi , Linux MM , LKML Subject: Re: [PATCH] mem-hotplug: use GFP_HIGHUSER_MOVABLE and alloc from next node in alloc_migrate_target() References: <5786F81B.1070502@huawei.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.25.179] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.57883A2C.01FA,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: f91cd2658fee3bd547f0d37350dd22ae Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/7/15 6:17, David Rientjes wrote: > On Thu, 14 Jul 2016, Xishi Qiu wrote: > >> alloc_migrate_target() is called from migrate_pages(), and the page >> is always from user space, so we can add __GFP_HIGHMEM directly. >> >> Second, when we offline a node, the new page should alloced from other >> nodes instead of the current node, because re-migrate is a waste of >> time. >> > > alloc_migrate_target() is not only used from memory hotplug, it is also > used for CMA: we won't be isolating PageHuge() pages in > isolate_migratepages_range(), so this would cause a regression where we'd > be migrating memory to a remote NUMA node rather than preferring to > allocate locally. > > You may find it useful to use the 'private' field of the migrate_pages() > callback to specify the node the page should preferably be migrated to. > OK, I know, I'll rewrite v2. >> Signed-off-by: Xishi Qiu >> --- >> mm/page_isolation.c | 16 ++++++---------- >> 1 file changed, 6 insertions(+), 10 deletions(-) >> >> diff --git a/mm/page_isolation.c b/mm/page_isolation.c >> index 612122b..83848dc 100644 >> --- a/mm/page_isolation.c >> +++ b/mm/page_isolation.c >> @@ -282,20 +282,16 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, >> struct page *alloc_migrate_target(struct page *page, unsigned long private, >> int **resultp) >> { >> - gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE; >> - >> /* >> - * TODO: allocate a destination hugepage from a nearest neighbor node, >> + * TODO: allocate a destination page from a nearest neighbor node, >> * accordance with memory policy of the user process if possible. For >> * now as a simple work-around, we use the next node for destination. >> */ >> + int nid = next_node_in(page_to_nid(page), node_online_map); >> + >> if (PageHuge(page)) >> return alloc_huge_page_node(page_hstate(compound_head(page)), >> - next_node_in(page_to_nid(page), >> - node_online_map)); >> - >> - if (PageHighMem(page)) >> - gfp_mask |= __GFP_HIGHMEM; >> - >> - return alloc_page(gfp_mask); >> + nid); >> + else >> + return __alloc_pages_node(nid, GFP_HIGHUSER_MOVABLE, 0); > > I don't think this __alloc_pages_node() does what you think it does, it > only prefers nid here and will readily fallback to other nodes if > necessary. That is different than alloc_huge_page_node() which does no > fallback. So there's two issues with this change: (1) inconsistency > between PageHuge() and !PageHuge() behavior, and (2) the use of > __alloc_pages_node() does not match the commit description which states > "re-migrate is a waste of time." > Yes, you are right, how about change the changelog, one is membind, the other is prefer? Thanks, Xishi Qiu > . >