From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752405AbcGOD1Y (ORCPT ); Thu, 14 Jul 2016 23:27:24 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:47612 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbcGOD1V (ORCPT ); Thu, 14 Jul 2016 23:27:21 -0400 X-AuditID: cbfee68f-f79476d000001429-67-57885816fe75 Message-id: <578857FD.7030601@samsung.com> Date: Fri, 15 Jul 2016 08:56:53 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Jaehoon Chung , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz Subject: Re: ARM: dts: exynos: Properly select eMMC HighSpeed mode References: <1468500458-7142-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1468500458-7142-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsVy+t8zI12xiI5wg0WntS02zljPajH/yDlW ixu/2lgtXr8wtOh//JrZYtPja6wWl3fNYbOYcX4fkwOHx6ZVnWwem5fUe/RtWcXo8XmTXABL FJdNSmpOZllqkb5dAlfGkkPXmQoW81XcmveDuYHxGncXIyeHhICJxIVFzUwQtpjEhXvr2boY uTiEBFYySkyZdRgowQFWdHINC0R8KaPEyb/tTBDOA0aJ0+cbGEG6eQW0JF6972cHsVkEVCWO f9vCBmKzCWhL3J2+BWyQqECExOMLQhDlghI/Jt8DGyoi0Mgk8X3zZrA5zAIWElu3rgabIyzg JPHi7w2wOUICbhLLNjaB2ZwC7hJb+qaxQtTbSix4v44FwpaX2LzmLTPIUAmBS+wSW34+hDpI QOLb5EMsEN/ISmw6wAzxsaTEwRU3WCYwis1CctMsJGNnIRm7gJF5FaNoakFyQXFSepGxXnFi bnFpXrpecn7uJkZIzPXvYLx7wPoQowAHoxIPb8XV9nAh1sSy4srcQ4ymQFdMZJYSTc4HRnZe SbyhsZmRhamJqbGRuaWZkjjvQqmfwUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoY969/Wfdw xrSMbofHmbd0rx2yyD10JTXFUXhl5ze7QMWOXfuX8qbln9lWGnZ0qaX53R+FyyWWyWbmcGyd ttdr7txtgXd4pWffMCno87gvzfCTvfMe8/VTmTnuKg4se/1UdURUbZ68Ff+x+M0GcYeF/+75 yczZtP6S55naxK8cZy//fr3s2AGLx0osxRmJhlrMRcWJANCqkma0AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsVy+t9jAV2xiI5wg/avahYbZ6xntZh/5Byr xY1fbawWr18YWvQ/fs1ssenxNVaLy7vmsFnMOL+PyYHDY9OqTjaPzUvqPfq2rGL0+LxJLoAl qoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwfoCiWF ssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmggYR1jxpJD15kKFvNV3Jr3g7mB8Rp3 FyMHh4SAicTJNSxdjJxAppjEhXvr2boYuTiEBJYySpz8284E4TxglDh9voERpIpXQEvi1ft+ dhCbRUBV4vi3LWwgNpuAtsTd6VuYQIaKCkRIPL4gBFEuKPFj8j0WkDkiAo1MEt83bwabwyxg IbF162qwOcICThIv/t4AmyMk4CaxbGMTmM0p4C6xpW8aK0S9rcSC9+tYIGx5ic1r3jJPYBSY hWTHLCRls5CULWBkXsUokVqQXFCclJ5rmJdarlecmFtcmpeul5yfu4kRHNfPpHYwHtzlfohR gINRiYe343F7uBBrYllxZe4hRgkOZiURXqXwjnAh3pTEyqrUovz4otKc1OJDjKbAQJjILCWa nA9MOXkl8YbGJmZGlkZmFkYm5uZK4ryP/68LExJITyxJzU5NLUgtgulj4uCUamAsjlO9vzLj 6SPjPc9/d9+Y9kD05/qt4rOmTqzeGnk87cBqiy8G53bFd0bEOXe4H+nnf/Kbc/Med/l/CdKZ gSVWbPt/nO/oe722J/Zkas7MXsHF/w+z6U3nn3N5q+I+PTXlr1oH98pd3SSTfqr8QU6/zvPl UTZS7fFqh3f4f/FIvnvUfre6S2uMEktxRqKhFnNRcSIAWwNWpgEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 07/14/2016 06:17 PM, Krzysztof Kozlowski wrote: > Exynos5410 supports eMMC version 4.41 so HS200 is the top mode which > should be configured. This is reflected in usage of > "samsung,exynos5250-dw-mshc" compatible. However DTS contained also > property "mmc-hs400-1_8v" which is parsed by MMC core therefore > resulting in mixed configuration. MMC core set HS400 but dwmmc_exynos > driver did not configure the data strobe for HS400 DDR mode. > > Removal of HS400 properties fixes semi-random mmc errors during boot: > mmc_host mmc0: Bus speed (slot 0) = 400000000Hz (slot req 200000000Hz, actual 200000000HZ div = 1) > mmc0: mmc_select_hs400 failed, error -84 > mmc0: error -84 whilst initialising MMC card > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts > index d9499310a301..7536164438ca 100644 > --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts > +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts > @@ -447,14 +447,12 @@ > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <0 4>; > samsung,dw-mshc-ddr-timing = <0 2>; > - samsung,dw-mshc-hs400-timing = <0 2>; not sure but can we use /delete-property/ option for this removable? > samsung,read-strobe-delay = <90>; this also need to be removed. > pinctrl-names = "default"; > pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd>; > bus-width = <8>; > cap-mmc-highspeed; > mmc-hs200-1_8v; > - mmc-hs400-1_8v; same as above if possible use /delete-property/ > vmmc-supply = <&ldo20_reg>; > vqmmc-supply = <&ldo11_reg>; > }; >