From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbcGOEQ3 (ORCPT ); Fri, 15 Jul 2016 00:16:29 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:43441 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbcGOEQ1 (ORCPT ); Fri, 15 Jul 2016 00:16:27 -0400 X-AuditID: cbfee68d-f79876d000001436-36-57886398b0f8 Message-id: <5788637F.2070908@samsung.com> Date: Fri, 15 Jul 2016 09:45:59 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Jaehoon Chung , Ulf Hansson , Kukjin Kim , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz Subject: Re: mmc: dwmmc: exynos: Warn if HS400 is being used on non-Exynos5420 chipset References: <1468502547-18571-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1468502547-18571-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsVy+t8zY92ZyR3hBocuM1psnLGe1eLGrzZW i9cvDC36H79mttj0+BqrxeVdc9gsjvzvZ7SYcX4fk8XxteEOnB6bVnWyedy5tofNY/OSeo++ LasYPT5vkgtgjeKySUnNySxLLdK3S+DKuPetg63gL2fF0fXPmBoY+zi6GDk5JARMJG68/sQI YYtJXLi3nq2LkYtDSGAlo8TivZ/Zuxg5wIoWfk6AiM9ilJj4dxNU0QNGie/b5rCBdPMKaEl8 P3sObBKLgKrE2/Yl7CA2m4C2xN3pW5hABokKREg8viAEUS4o8WPyPRYQW0RgBZNExz9tEJtZ wEJi69bVYK3CQOXHtkOMFBJwl5jTcxNsFaeAh8TB7deZIOptJRa8X8cCYctLbF7zlhnimVvs Evd70yDOEZD4NvkQC8QvshKbDkCVSEocXHGDZQKj2CwkF81CMnUWkqkLGJlXMYqmFiQXFCel FxnqFSfmFpfmpesl5+duYoREYO8OxtsHrA8xCnAwKvHwWhh3hAuxJpYVV+YeYjQFumIis5Ro cj4wzvNK4g2NzYwsTE1MjY3MLc2UxHkVpX4GCwmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamDk 7LAP5fJXnB28IH2RsfSbHT/llFgmGGebXQp3Ekk6GFAcnZ8Y9dD+1oZJ/+Tv+D6oOHx9+hOR POElRWzSeW8+Tvp96dbDuU7qtx+npwvffpJZZ2G6Pk1E6fzDq1tEF7/fxJ+fenmKIFedvcr+ d7H/D0xa8d5a+HFapOrs5suyb29nK35LveWgxFKckWioxVxUnAgAoyzRZrsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsVy+t9jQd0ZyR3hBidmWFlsnLGe1eLGrzZW i9cvDC36H79mttj0+BqrxeVdc9gsjvzvZ7SYcX4fk8XxteEOnB6bVnWyedy5tofNY/OSeo++ LasYPT5vkgtgjWpgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLx CdB1y8wBOkdJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjHmHHvWwdbwV/O iqPrnzE1MPZxdDFycEgImEgs/JzQxcgJZIpJXLi3nq2LkYtDSGAWo8TEv5ugnAeMEt+3zWED qeIV0JL4fvYcI4jNIqAq8bZ9CTuIzSagLXF3+hYmkKGiAhESjy8IQZQLSvyYfI8FxBYRWMEk 0fFPG8RmFrCQ2Lp1NVirMFD5se0QI4UE3CXm9NwEW8Up4CFxcPt1Joh6W4kF79exQNjyEpvX vGWewAh0JcKKWUjKZiEpW8DIvIpRIrUguaA4KT3XMC+1XK84Mbe4NC9dLzk/dxMjOM6fSe1g PLjL/RCjAAejEg9vx+P2cCHWxLLiytxDjBIczEoivPaxHeFCvCmJlVWpRfnxRaU5qcWHGE2B YTCRWUo0OR+YgvJK4g2NTcyMLI3MLIxMzM2VxHkf/18XJiSQnliSmp2aWpBaBNPHxMEp1cCo wuX0+93aeRvvuWf7ncgMPyGlsKgrpzMs+BP7+fnei5QsHv5a/iyX1Y9PRph7v7xPW+2haTt2 ZTJwvb5fteLjFjUGjqLe2LMM+Sa1WWdDJ31ITJHc89Jo5vWOhRMkIiPOZ0/+fLvx7QL/GRs0 wrYe5e9X4tHQnfgk+EN+1C7p/+cK/mTvab2kxFKckWioxVxUnAgAfRFy5QkDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 07/14/2016 06:52 PM, Krzysztof Kozlowski wrote: > Chipsets before Exynos5420 did not support HS400 so if MMC core tries to > configure HS400 timing, this might or might not work. Warn in such > cases because this is DTB misconfiguration. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Alim Akhtar > drivers/mmc/host/dw_mmc-exynos.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index da0ef1765735..7ab3d749b5ae 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -225,8 +225,12 @@ static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing) > * Not supported to configure register > * related to HS400 > */ > - if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) > + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) { > + if (timing == MMC_TIMING_MMC_HS400) > + dev_warn(host->dev, > + "cannot configure HS400, unsupported chipset\n"); > return; > + } > It is good to have extra bit of debug information handy. > dqs = priv->saved_dqs_en; > strobe = priv->saved_strobe_ctrl; >