From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752773AbcGOIRu (ORCPT ); Fri, 15 Jul 2016 04:17:50 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:61025 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbcGOIRp (ORCPT ); Fri, 15 Jul 2016 04:17:45 -0400 X-AuditID: cbfec7f5-f792a6d000001302-54-57889c25cb84 Subject: Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg To: Jacek Anaszewski References: <1468526499-8840-1-git-send-email-shuahkh@osg.samsung.com> <578890BA.8040101@samsung.com> <57889B73.4090607@samsung.com> Cc: Shuah Khan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, kgene@kernel.org, mchehab@osg.samsung.com, andrzej.p@samsung.com, hans.verkuil@cisco.com, javier@osg.samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <57889C23.3050106@samsung.com> Date: Fri, 15 Jul 2016 10:17:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <57889B73.4090607@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsVy+t/xy7qqczrCDQ4uFLCY9bKdxWL+kXOs Fv1vFrJaLPm5i8ni3KuVjBa9V58zWrx5u4bJ4vULQ4v+x6+ZLTY9vsZqcXnXHDaLGef3MVks vX6RyWL1swqLCdPXsli07j3CbjH1ywcWB0GPNfPWMHpM+b2R1eNyXy+Tx8rlX9g8Nq3qZPPY vKTeY0v/XXaPvi2rGD0+b5IL4IzisklJzcksSy3St0vgyli7fRZzwW3Wis2zZRoYt7B0MXJy SAiYSHRtW8IEYYtJXLi3nq2LkYtDSGApo8Sk+f9YIZxnjBLnuo6zgVQJC4RLTDz/G6xbREBf oqGhjxGiqI1RorXtKlgHs8AsZomj7/aCdbAJGEtsXr4EzOYV0JKYf3gXK4jNIqAqMfVhNzOI LSoQITFr+w8miBpBiR+T74Ft4BTQllh87hpQLwfQUD2J+xe1QMLMAvISm9e8ZZ7AKDALSccs hKpZSKoWMDKvYhRNLU0uKE5KzzXSK07MLS7NS9dLzs/dxAiJta87GJceszrEKMDBqMTDu+NQ e7gQa2JZcWXuIUYJDmYlEd7cWR3hQrwpiZVVqUX58UWlOanFhxilOViUxHln7nofIiSQnliS mp2aWpBaBJNl4uCUamA8b5YgMpWh5uOkmbKvl+z41rpQY/adiWbpXv2PY7vtLVbErKkzWm0r XbP8QNM796tW79M52CM3LeiPdui+MV3lBFPMCmH7sOTa7dtzs3T2HG4PPnD444x0xxvdf1WY SxO7J7r9+/COeX3Ciz/dm98qd3B8l61Jsbgqey+8zK/hl8Cd4tIP97uVWIozEg21mIuKEwG3 QFD5sQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 10:14 AM, Jacek Anaszewski wrote: >> However if these compatibles are exactly equal then >> only one should be preferred. It makes everything easier. Second can be >> still documented e.g. as deprecated. > > Still, both of them are present in the driver. Shouldn't it be reflected > in the documentation? Right, it is a good practice, so how about: - compatible : should be one of: "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg", "samsung,exynos4210-jpeg", "samsung,exynos5420-jpeg", "samsung,exynos5433-jpeg"; Deprecated: "samsung,exynos4212-jpeg" (or any other formatting) plus update to DTS changing it to 4210? Best regards, Krzysztof