From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbcGOI2f (ORCPT ); Fri, 15 Jul 2016 04:28:35 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:12060 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbcGOI2c (ORCPT ); Fri, 15 Jul 2016 04:28:32 -0400 X-AuditID: cbfec7f4-f796c6d000001486-6a-57889eacab78 Message-id: <57889EAB.30502@samsung.com> Date: Fri, 15 Jul 2016 10:28:27 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Shuah Khan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, kgene@kernel.org, mchehab@osg.samsung.com, andrzej.p@samsung.com, hans.verkuil@cisco.com, javier@osg.samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg References: <1468526499-8840-1-git-send-email-shuahkh@osg.samsung.com> <578890BA.8040101@samsung.com> <57889B73.4090607@samsung.com> <57889C23.3050106@samsung.com> In-reply-to: <57889C23.3050106@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsVy+t/xq7pr5nWEGxyYJmMx62U7i8X8I+dY LfrfLGS1WPJzF5PFuVcrGS3evF3DZPH6haFF/+PXzBabHl9jtbi8aw6bxYzz+5gsll6/yGSx +lmFxYTpa1ksWvceYbeY+uUDi4OAx5p5axg9pvzeyOpxua+XyWPl8i9sHptWdbJ5bF5S77Gl /y67R9+WVYwenzfJBXBGcdmkpOZklqUW6dslcGW82PiFveAdW8W5tQoNjEtZuxg5OSQETCSe LnnPAmGLSVy4t56ti5GLQ0hgKaPEnyn3mCGcZ4wSr9bfYwSp4hXQkDh19yx7FyMHB4uAqsSn q8IgYTYBQ4mfL14zgdiiAhESf07vY4UoF5T4Mfke2AIRoJqDu7czgcxkFpjFLHH03V42kISw QLjExPO/WSCWLWeU2PZnIVgHp4C2RMOXVWBTmQVsJRa8X8cCYctLbF7zlnkCo8AsJEtmISmb haRsASPzKkbR1NLkguKk9FxDveLE3OLSvHS95PzcTYyQGPuyg3HxMatDjAIcjEo8vAJH28OF WBPLiitzDzFKcDArifDmzuoIF+JNSaysSi3Kjy8qzUktPsQozcGiJM47d9f7ECGB9MSS1OzU 1ILUIpgsEwenVAOjoazr5UeMXFXLrM+1nLXcaMokwTb51Rm3b8eqrl80f39250qZsKC4KymM R5PY4i7dNBIWm7XrzqnwuJhiPvuHGSJOc7Lzeyz/fnq3ZPfzai2W33PeSa1Zwhu221fbOKT+ 35b6c+UF3cmlOux5xdvUb55/w7xYJHXCX74jqwTb5gSWMU/sPF2ixFKckWioxVxUnAgA007V ba0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 10:17 AM, Krzysztof Kozlowski wrote: > On 07/15/2016 10:14 AM, Jacek Anaszewski wrote: >>> However if these compatibles are exactly equal then >>> only one should be preferred. It makes everything easier. Second can be >>> still documented e.g. as deprecated. >> >> Still, both of them are present in the driver. Shouldn't it be reflected >> in the documentation? > > Right, it is a good practice, so how about: > > - compatible : should be one of: > "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg", > "samsung,exynos4210-jpeg", "samsung,exynos5420-jpeg", > "samsung,exynos5433-jpeg"; > > Deprecated: "samsung,exynos4212-jpeg" > > (or any other formatting) > plus update to DTS changing it to 4210? Why newer 4212 version should be made deprecated? -- Best regards, Jacek Anaszewski