From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909AbcGOIdf (ORCPT ); Fri, 15 Jul 2016 04:33:35 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:35861 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbcGOIdb (ORCPT ); Fri, 15 Jul 2016 04:33:31 -0400 X-AuditID: cbfec7f5-f792a6d000001302-f4-57889fd7025e Subject: Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg To: Jacek Anaszewski References: <1468526499-8840-1-git-send-email-shuahkh@osg.samsung.com> <578890BA.8040101@samsung.com> <57889B73.4090607@samsung.com> <57889C23.3050106@samsung.com> <57889EAB.30502@samsung.com> Cc: Shuah Khan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, kgene@kernel.org, mchehab@osg.samsung.com, andrzej.p@samsung.com, hans.verkuil@cisco.com, javier@osg.samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <57889FD5.9070302@samsung.com> Date: Fri, 15 Jul 2016 10:33:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <57889EAB.30502@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t/xq7o35neEG0xJsJj1sp3FYv6Rc6wW /W8Wslos+bmLyeLcq5WMFr1XnzNavHm7hsni9QtDi/7Hr5ktNj2+xmpxedccNosZ5/cxWSy9 fpHJYvWzCosJ09eyWLTuPcJuMfXLBxYHQY8189Ywekz5vZHV43JfL5PHyuVf2Dw2repk89i8 pN5jS/9ddo++LasYPT5vkgvgjOKySUnNySxLLdK3S+DKmPFZoOAIZ8WuX8uZGhh3sncxcnJI CJhINPw7zwJhi0lcuLeerYuRi0NIYCmjxN3135ghnGeMEg9/fWADqRIWCJeYeP43WIeIgL5E Q0MfI0TREUaJUz/fg3UwC8xiljj6bi9YB5uAscTm5UvAbF4BLYmeqX/BulkEVCXaJ75iBbFF BSIkZm3/wQRRIyjxY/I9sBpOAU2JKZ8XAQ3lABqqJ3H/ohZImFlAXmLzmrfMExgFZiHpmIVQ NQtJ1QJG5lWMoqmlyQXFSem5RnrFibnFpXnpesn5uZsYIZH2dQfj0mNWhxgFOBiVeHh3HGoP F2JNLCuuzD3EKMHBrCTCmzurI1yINyWxsiq1KD++qDQntfgQozQHi5I478xd70OEBNITS1Kz U1MLUotgskwcnFINjIu3RXuvdQtLetvrfN4xd8Odrb+ef7F0CXg7xWr90t9tW1hu7/HUrbu8 yzVrzaZYHb86pW+hsns5w/5E+TxYtWbe5P89ml4SEn+8Tn5aZVl/r8R4UtvVxqdrgszSn8tt WXhW/MLkePFWAbu81qOvbfuv1NbJrXE7c+tn1dbAwlDzi84ucy6teKvEUpyRaKjFXFScCAAj jFq8sAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 10:28 AM, Jacek Anaszewski wrote: > On 07/15/2016 10:17 AM, Krzysztof Kozlowski wrote: >> On 07/15/2016 10:14 AM, Jacek Anaszewski wrote: >>>> However if these compatibles are exactly equal then >>>> only one should be preferred. It makes everything easier. Second can be >>>> still documented e.g. as deprecated. >>> >>> Still, both of them are present in the driver. Shouldn't it be reflected >>> in the documentation? >> >> Right, it is a good practice, so how about: >> >> - compatible : should be one of: >> "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg", >> "samsung,exynos4210-jpeg", "samsung,exynos5420-jpeg", >> "samsung,exynos5433-jpeg"; >> >> Deprecated: "samsung,exynos4212-jpeg" >> >> (or any other formatting) >> plus update to DTS changing it to 4210? > > Why newer 4212 version should be made deprecated? I don't mind the other way. However it seems logical to me that newer chip is compatible with existing one so the existing one (older) is used. When adding support for new devices, for most of re-usable drivers we use old compatibles. But as I said, it doesn't really matter to me. BR, Krzysztof