From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932342AbcGOJDZ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jul 2016 05:03:25 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:24820 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752718AbcGOJDW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jul 2016 05:03:22 -0400
Subject: Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver
To: Arnd Bergmann <arnd@arndb.de>
References: <1468571195-59763-1-git-send-email-lidongpo@hisilicon.com>
 <20917223.X0KrqBAbxT@wuerfel>
CC: <f.fainelli@gmail.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <frowand.list@gmail.com>, <davem@davemloft.net>, <andrew@lunn.ch>,
        <xuejiancheng@hisilicon.com>, <benjamin.chenhao@hisilicon.com>,
        <howell.yang@hisilicon.com>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Dongpo Li <lidongpo@hisilicon.com>
Message-ID: <5788A6BC.5020603@hisilicon.com>
Date: Fri, 15 Jul 2016 17:02:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20917223.X0KrqBAbxT@wuerfel>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.66.52.107]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090206.5788A6C8.0144,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: f629e5e55b1f64833f64237bf5c0b7a5
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

On 2016/7/15 16:41, Arnd Bergmann wrote:
> On Friday, July 15, 2016 4:26:32 PM CEST Dongpo Li wrote:
>> This patch set adds a Hisilicon MDIO bus driver and
>> a Fast Ethernet MAC(FEMAC) driver.
>> We also abstract a general interface "of_phy_get_and_connect"
>> for PHY connect. User will have no bother with getting
>> "phy-mode" and "phy-handle" any more.
>>
>> Changes in v1:
>> - Pass private data structure instead of struct mii_bus
>>   in MDIO read and write operation.
>> - Return the error which devm_clk_get() gives when MDIO probe.
>> - Leave the clock unprepared and disabled on error when MDIO probe.
>> - Abstract a general interface "of_phy_get_and_connect" for PHY connect.
>> - Remove the "_reset" suffixes in "reset-names" property.
>> - Enable tx per-packet interrupt when tx fifo full.
>> - Remove pointless compatible and add SoC specific compatible.
>> - Declare only one clock in MAC dts documentation.
>> - Add standard unit suffixes for "phy-reset-delays".
>> - Use a smaller NAPI poll weight 16 for our Fast Ethernet MAC.
>> - Use phy_ethtool_{get|set}_link_ksettings for ethtool ops.
>> - Use phydev from struct net_device in MAC driver.
>>
> 
> Looks all good to me now,
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> One comment on the submission format: we normally count the initial
> submission as "v1", so after [PATCH 0/3], the following version is
> [PATCH v2 0/3], not [PATCH v1 0/3].
> 
> No need to re-send for this now, and if you end up having to make
> other changes, just continue with "v2" for this driver, just follow
> the normal scheme if you send another driver.
> 
Okay, many thanks for your friendly reminder.   :)

> 	Arnd
> 
> .
> 

    Regards,
    Dongpo

.