From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932408AbcGOJSb (ORCPT ); Fri, 15 Jul 2016 05:18:31 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:38544 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbcGOJS1 (ORCPT ); Fri, 15 Jul 2016 05:18:27 -0400 X-AuditID: cbfec7f4-f796c6d000001486-65-5788aa60e111 Message-id: <5788AA5E.3070301@samsung.com> Date: Fri, 15 Jul 2016 11:18:22 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Krzysztof Kozlowski Cc: Shuah Khan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, kgene@kernel.org, mchehab@osg.samsung.com, andrzej.p@samsung.com, hans.verkuil@cisco.com, javier@osg.samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg References: <1468526499-8840-1-git-send-email-shuahkh@osg.samsung.com> <578890BA.8040101@samsung.com> <57889B73.4090607@samsung.com> <57889C23.3050106@samsung.com> <57889EAB.30502@samsung.com> <57889FD5.9070302@samsung.com> In-reply-to: <57889FD5.9070302@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsVy+t/xy7oJqzrCDW5tZbeY9bKdxWL+kXOs Fv1vFrJaLPm5i8ni3KuVjBZv3q5hsnj9wtCi//FrZotNj6+xWlzeNYfNYsb5fUwWS69fZLJY /azCYsL0tSwWrXuPsFtM/fKBxUHAY828NYweU35vZPW43NfL5LFy+Rc2j02rOtk8Ni+p99jS f5fdo2/LKkaPz5vkAjijuGxSUnMyy1KL9O0SuDJ+PvjJXNDHU7FoxjH2BsbDnF2MnBwSAiYS ///fZ4OwxSQu3FsPZHNxCAksZZSYeqqTGcJ5xijx7eZ2JpAqXgEtiYvXJ4HZLAKqEs9XPWQF sdkEDCV+vngNFhcViJD4c3ofK0S9oMSPyfdYQGwRoJqDu0HmcHEwC8xiljj6bi/YamGBcImJ 53+zQGx7yijR/uUrWIJTQFtiyZ/d7CA2s4CtxIL361ggbHmJzWveMk9gFJiFZMksJGWzkJQt YGRexSiaWppcUJyUnmuoV5yYW1yal66XnJ+7iRESZ192MC4+ZnWIUYCDUYmHV+Boe7gQa2JZ cWXuIUYJDmYlEd7JKzrChXhTEiurUovy44tKc1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1 CCbLxMEp1cDYeCS7UOC3ZeWBM6HWl9ptP6b5//+8QjGV5wXXridMBxl1/Dzv3Ngsoyhneffd QscZ/JbLlm0pbUi/s1FfOj+eOZlToTRqZufuX59DzR6pza36aPA3qiNV/ruP5wWb323M70zD rjK9UF675uy3os+Wy9IjMrn0nrjsUHfcy8ikf4nrkIbbyblKLMUZiYZazEXFiQAJKi89rwIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2016 10:33 AM, Krzysztof Kozlowski wrote: > On 07/15/2016 10:28 AM, Jacek Anaszewski wrote: >> On 07/15/2016 10:17 AM, Krzysztof Kozlowski wrote: >>> On 07/15/2016 10:14 AM, Jacek Anaszewski wrote: >>>>> However if these compatibles are exactly equal then >>>>> only one should be preferred. It makes everything easier. Second can be >>>>> still documented e.g. as deprecated. >>>> >>>> Still, both of them are present in the driver. Shouldn't it be reflected >>>> in the documentation? >>> >>> Right, it is a good practice, so how about: >>> >>> - compatible : should be one of: >>> "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg", >>> "samsung,exynos4210-jpeg", "samsung,exynos5420-jpeg", >>> "samsung,exynos5433-jpeg"; >>> >>> Deprecated: "samsung,exynos4212-jpeg" >>> >>> (or any other formatting) >>> plus update to DTS changing it to 4210? >> >> Why newer 4212 version should be made deprecated? > > I don't mind the other way. However it seems logical to me that newer > chip is compatible with existing one so the existing one (older) is > used. When adding support for new devices, for most of re-usable drivers > we use old compatibles. But as I said, it doesn't really matter to me. Frankly speaking marking a compatible deprecated looks weird to me. It can be interpreted in the way that the device itself is deprecated or it is not fully reliable. I'd just accept the patch in the original form. -- Best regards, Jacek Anaszewski