From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751576AbcGRGkv (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jul 2016 02:40:51 -0400
Received: from mail-pa0-f54.google.com ([209.85.220.54]:34334 "EHLO
	mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750857AbcGRGkq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jul 2016 02:40:46 -0400
Message-ID: <578C79D7.6090800@linaro.org>
Date: Mon, 18 Jul 2016 14:40:23 +0800
From: zhangfei <zhangfei.gao@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: John Stultz <john.stultz@linaro.org>, lkml <linux-kernel@vger.kernel.org>
CC: Andy Green <andy.green@linaro.org>, Jingoo Han <jg1.han@samsung.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Vinod Koul <vinod.koul@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
        Andy Green <andy@warmcat.com>, Dave Long <dave.long@linaro.org>,
        Guodong Xu <guodong.xu@linaro.org>
Subject: Re: [RFC][PATCH 3/7] k3dma: Fix "nobody cared" message seen on any
 error
References: <1468635207-20065-1-git-send-email-john.stultz@linaro.org> <1468635207-20065-4-git-send-email-john.stultz@linaro.org>
In-Reply-To: <1468635207-20065-4-git-send-email-john.stultz@linaro.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 07/16/2016 10:13 AM, John Stultz wrote:
> From: Andy Green <andy.green@linaro.org>
>
> As it was before, as soon as the DMAC IP felt there was an error
> he would return IRQ_NONE since no actual transfer had completed.
>
> After spinning on that for 100K interrupts, Linux yanks the IRQ with
> a "nobody cared" error.
>
> This patch lets it handle the interrupt and keep the IRQ alive.
>
> Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Andy Green <andy@warmcat.com>
> Cc: Dave Long <dave.long@linaro.org>
> Cc: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Andy Green <andy.green@linaro.org>
> [jstultz: Forward ported to mainline]
> Signed-off-by: John Stultz <john.stultz@linaro.org>

Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>

> ---
>   drivers/dma/k3dma.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
> index 8dd050c..c2906a82 100644
> --- a/drivers/dma/k3dma.c
> +++ b/drivers/dma/k3dma.c
> @@ -220,11 +220,13 @@ static irqreturn_t k3_dma_int_handler(int irq, void *dev_id)
>   	writel_relaxed(err1, d->base + INT_ERR1_RAW);
>   	writel_relaxed(err2, d->base + INT_ERR2_RAW);
>
> -	if (irq_chan) {
> +	if (irq_chan)
>   		tasklet_schedule(&d->task);
> +
> +	if (irq_chan || err1 || err2)
>   		return IRQ_HANDLED;
> -	} else
> -		return IRQ_NONE;
> +
> +	return IRQ_NONE;
>   }
>
>   static int k3_dma_start_txd(struct k3_dma_chan *c)
>