From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751640AbcGRKlz (ORCPT ); Mon, 18 Jul 2016 06:41:55 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:13941 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbcGRKlx (ORCPT ); Mon, 18 Jul 2016 06:41:53 -0400 X-AuditID: cbfec7f4-f796c6d000001486-8d-578cb26c024d Subject: Re: [PATCH v4 4/4] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board To: Chanwoo Choi References: <1467738877-31555-1-git-send-email-s.nawrocki@samsung.com> <5788721B.7010602@samsung.com> Cc: broonie@kernel.org, robh@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, ideal.song@samsung.com, inki.dae@samsung.com, b.zolnierkie@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski From: Sylwester Nawrocki Message-id: <578CB261.60507@samsung.com> Date: Mon, 18 Jul 2016 12:41:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <5788721B.7010602@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRmVeSWpSXmKPExsVy+t/xa7o5m3rCDWbOtbK4cvEQk8XGGetZ LaY+fMJmcf3Lc1aL+UfOsVrs+nuf0WLS/QksFq9fGFpc3jWHzWLG+X1MFv/37GB34PbY8LmJ zWPTqk42j74tqxg9Pm+SC2CJ4rJJSc3JLEst0rdL4Mp4OXE7W8FEjoqufxNYGxhPs3UxcnJI CJhI7G54ywJhi0lcuLceKM7FISSwlFFiyrXZTBDOc0aJqZvfgHUIC8RJ3Nv1kR3EFhHQkJj5 9wojRNFeRolLK2eygzjMAvOYJLb/PwzWwSZgKNF7tI8RxOYF6lj6r4sVxGYRUJW4ff84mC0q ECHxZO5JqBpBiR+T74HdxCmgLXFt73agGg6goXoS9y9qgYSZBeQlNq95yzyBUWAWko5ZCFWz kFQtYGRexSiaWppcUJyUnmuoV5yYW1yal66XnJ+7iRESA192MC4+ZnWIUYCDUYmH98ba7nAh 1sSy4srcQ4wSHMxKIryRa3vChXhTEiurUovy44tKc1KLDzFKc7AoifPO3fU+REggPbEkNTs1 tSC1CCbLxMEp1cA4qTl3m365+6LJKUnspyU4lx+M9u3eusl+64v1RzvX/ZjZYtghVWgtcFNn pvr3V8EcZf8rnh17ZNm0zWhiVnanyqLr80ufbDWYb/NO6k2fTpYN6/sL12a0lE552Rryw19s 4envFluKL3xVaFywKDFwx6RGi6Kcj/NNYwJumhxqPpSik/vw5t9bSizFGYmGWsxFxYkAjglX w30CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, On 07/15/2016 07:18 AM, Chanwoo Choi wrote: >> +static int tm2_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + codec_dai_node = of_parse_phandle(dev->of_node, "audio-codec", 0); >> + if (!codec_dai_node) { >> + dev_err(dev, "audio-codec property invalid or missing\n"); >> + ret = -EINVAL; >> + goto err_put_cpu_dai; >> + } >> + priv->codec_mclk1 = of_clk_get_by_name(codec_dai_node, "mclk1"); >> + if (IS_ERR(priv->codec_mclk1)) { >> + dev_err(dev, "Failed to get mclk1 clock\n"); >> + ret = PTR_ERR(priv->codec_mclk1); >> + goto err_put_codec_dai; >> + } > > I think that you better to use the devm_clk_get() instead of of_clk_get_by_name() > because you don't need to handle the clk_put() when error happen and remove the > this driver. > > priv->codec_mclk1 = devm_clk_get(dev, "mclk1"); The clocks are from the CODEC DT node, for which we don't have struct device pointer here, that's why I used of_clk_get_by_name(). -- Thanks, Sylwester