From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbcGRNgl (ORCPT ); Mon, 18 Jul 2016 09:36:41 -0400 Received: from mail-sn1nam02on0058.outbound.protection.outlook.com ([104.47.36.58]:51391 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751251AbcGRNgj (ORCPT ); Mon, 18 Jul 2016 09:36:39 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH v2] drm/radeon: Remove deprecated create_singlethread_workqueue To: Bhaktipriya Shridhar , Alex Deucher , David Airlie References: <20160716113044.GA18061@Karyakshetra> CC: , , "Tejun Heo" From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <578CD7D1.8000308@amd.com> Date: Mon, 18 Jul 2016 15:21:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160716113044.GA18061@Karyakshetra> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:b59d:82b6:5d65:c82d] X-ClientProxiedBy: VI1PR07CA0092.eurprd07.prod.outlook.com (10.165.229.146) To DM5PR12MB1307.namprd12.prod.outlook.com (10.168.237.150) X-MS-Office365-Filtering-Correlation-Id: 702d3742-6186-4498-9399-08d3af0e7150 X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;2:0vTMtHqoTtg+plVtqkYBj2g0R7H+JzABRHvaVYRB+zUbuJRTfi8J5/Rn+njGVYyKsdDWjQuy6b/QjfHJNQYiHSrkU3ozU/l9yq3lm/nKficBq2VxFVSAdrhPOLRVsymiB/jX6mMH20KmaUXobN4TMOsI+mJoVD+97H09SrnkPU70hdl50rBa0k0BvmkYxQ80;3:yhsHPQljl4JWnEoVW/qhndcLTz66Qc3khJCLGpXlQYpf9rCCjh3NOto4pslXAtX7hbfsha3VzBlDjEWA9mAkCWNCx4j3C1t/TiKy9lvoIK5n/67m7R8mg1tiTrw4qAQ7;25:HsDPQq36nlw+MqFc6t2wsd7QYTilQqOtW28sxw6DqmyOD0UXWYdJSn7lknxVasRXBmjXXIZGb9Hf/WOXRZoivQSgf7k5qWzSuzGKzTmwiJMCcwAY1aWkd2Hs3su5cXra+KFcFOelgxg1zr1V8FNlUbp6flXuFFa+uv1xxpIZu1PrjGDLZSxYmFiGl+qL+FeWJ5xUuWvvboKdTCPZ/W/8eulVq2/6Q3xHnyn68C87x4EkkJGuHaQRFn6jHAP1sITEGtd5l2WPHUCjxX4iw+dD/6k/OdLs6l8AmyxEfVHgUVZNW9jbBDije4I9qjW+fr8gGGYa/AJLNI/ohlb8MmVyIbKjVLw1xNat6ORvdyWpkDbFbmLBl1b75evpdDwkTQbEmZUrkY4LujwxDBQcbKszhQ==;31:fgKr8Ae+m95Z3jOrR0mFuvpIdmz5HFXrboFM1wObqhcKvxoDvWRHHDOKlRot6poW4f22wuFaMRhNVefVOJpKvwIrg26t6oBsGJBqK4Xq9AypG292XKZiO8HWnUAD9nICfT+ESuw9UvfSnCeSUY8/Zly0Krj2tL+ZnpK95djEOk3SZZx2SO7VanuMWEng0sLMTivCJUicYw22fBnhe4Li/g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1307; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;20:mvEnfmw9KtfnPezXVspIMpk0JosVLxbTLTyHBjZDl7Ngpav1md1W8tI7D5L8qsuCMq8H6PCJRm7ChIV+SmW3kih2iA85F9zJS+ndv5EC0zywQ2CA2/gJ1n42VC2vgYRnJ3i6QoUiLFKkT6Np0y89+++OTgh/qcNmfO722rWHHXPnkzF2ePlAOEz6k1NlCEZMvnvJHCnUyFszRkuZeJtRV12HGU4xcmsF6hZ5ZPH4wIaNf7yMsefzCV6M/V+0udcLPMlwIksh1vx6DjsX8ZOZ9a434bW8EuOwZe6eqa1MSEoMILN6VVR+81uLsRVrkNjYyJ5f1qZ7MsgCBHbZwahtMyw3/Lj1ZKJMpADdS/Z2DJRsiBvgw1Os3bOt1R+iwhsxM+JLNN5Xcw61Gry+5lxyqzj/TYOeETH/zB+OjRUmqNp9QVY+stHzOqOfYk5xu6yv2sDMfNzXnvKTzjWi+yWJ/pthCoWUm+zG87plg7WfZBuNmsVXRdAEiLLEggMItPJ5;4:7XtIRjJznji90wClU3r/ZJtlQD06ZwsLH2Iclq7t4au+yu0S7ZBwAZVY8Vy/FQHpjDKemO+AkxSeMHqBpqrsLiFacVF8kmrcqF6Xf4dtQ9ZI40eWhCz2ov+CSKRg1Pi+yfuuTZG1zztiFT4nLqOJBjmhNcjQ0JGA1lTHkdP4/M2o3NZ4AqJK0b34ZOaHys+AdZR/6QvY49JZDry2UqiUAsrSKH1Q978nrOqrvQHJECZwJI6Mq0kYMwjodkTA3vfx6AMe0n4p4B1I5xY0FJsDNoGDqTLX5Giyt+y7rgz4qiPh8nthwdFxKDbK71I8K68DlJ20+FGfY/UpWwxOBEDcCJ3np3GqpfEWZO5WTkEXa51mYLvLEw9xZnndKIxgJQI2n1YIxWzUuUsuIgzOYP/uAeLyZcQfI+T175D3QKdGFKs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:DM5PR12MB1307;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1307; X-Forefront-PRVS: 00073DB75F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(36756003)(83506001)(105586002)(81166006)(64126003)(81156014)(50466002)(8676002)(23746002)(86362001)(92566002)(68736007)(305945005)(42186005)(7846002)(33656002)(59896002)(7736002)(6116002)(4001350100001)(65956001)(65806001)(47776003)(97736004)(5001770100001)(77096005)(2950100001)(1706002)(106356001)(4326007)(189998001)(101416001)(80316001)(19580405001)(19580395003)(586003)(76176999)(50986999)(87266999)(2906002)(54356999)(2870700001)(65816999)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1307;H:[IPv6:2a02:908:1251:7981:b59d:82b6:5d65:c82d];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR12MB1307;23:OhgNoZ0+uUbg5C4uudUIdVKOU6amaNlcY02Xh?= =?Windows-1252?Q?JdxcdHCXB7VoHE1XPmu/27p5pu5qVYDBInizhhAAhuUavxlH1NsOj2fC?= =?Windows-1252?Q?ZH4hh43AAI/XMNvjsokr56QczNwkoZAHYNADB8I60kNI0C0tEBlte1Sq?= =?Windows-1252?Q?GDZP90KrKqqp9opKxq46l5J72ZTgFgItNfPcC11ckJO70i9wC5wLPith?= =?Windows-1252?Q?+jQG4zoHRP3ZzZvHzZExYbTJOA9IYRiDukAiWWYVMREoX5ewbfH3iHw3?= =?Windows-1252?Q?rJpe0lTJO76kWNgROXsxyCb287Rt8VH4JHT/JuSwZpZOdvh8g5J/J2EB?= =?Windows-1252?Q?02aCFJYWFhd20NQlY1cDzwXI8DBqo1NvkrsdprY8Z8qSG+17IpgcEKI2?= =?Windows-1252?Q?7mdX0FYWU32JxkcCATtib0UpmKuF4Ko6JmpIxF9VWJG3l/OmorcspK/0?= =?Windows-1252?Q?VEFl1KdTN4mggC2uk2lCh9MVIksUzsojykZSyKUxWZo/3sbRBXbkNK/A?= =?Windows-1252?Q?+POO48sL1S2v42Xvg/HxoFvUMrQjtMfrBCsRqrX2lMFGbZQi3ZFqoF0i?= =?Windows-1252?Q?xaoY/JRen5F9tx8No54cXNOPhOUWnZOR+N+/lasslYbrF164qOsoi/WU?= =?Windows-1252?Q?JYm48PJdXRrrt23NExtCvfrdfOcLA6NKzm5oTM58236PwJqGmp/ydAwp?= =?Windows-1252?Q?ecKOzIIWn7beTCdLlg3wqFgoWYr9oC+73kvRagpGflQSbrYrls59UXts?= =?Windows-1252?Q?ot9WhAd/gSodbTsFeQYtHF+tLjA6HL4yta30Ai0I0f4ZWjQD7axvKc9L?= =?Windows-1252?Q?9Gs/14Xfe7LCEld20z3rhlBDKkp4iGqAmh+MSqp9/QAUTZiDHKJ5OrzL?= =?Windows-1252?Q?mLLYHkCiqS5WabvnPyxXaCf7zc/mEojHZJbJ6TKJgGCHn8P6ASUH8qGt?= =?Windows-1252?Q?IDHUcvKLYDOGYK+2N6Li0dnocQmLhXQ8vrDL53xb8p7no7VgV74ypbkj?= =?Windows-1252?Q?RecKT5AkRa/Sd5Vz02RKI0zxNdMa0+JntyNyjFm8EBQ+m8V+nGssKvAU?= =?Windows-1252?Q?3KcOnaUkPNC9xiBO6K9PFoGKC6BiBuJClWCbRXE4K+hQBPoc2nAi1jXS?= =?Windows-1252?Q?UOG1V6QmXzkMrrDey4Q5eZQLyxaQkCtGbGNE33Ag+tfntmAa+YJpEDBN?= =?Windows-1252?Q?cq4s2zBM8wPZuG+3LQMI76U88YZasJ7JxGNYfPp2tifRe0XZjbW0faC4?= =?Windows-1252?Q?Qt8h75XwRKy7j1PCCBWVvqmQyDWmN01SxtoLzHzyG8xoeBtfT9yTHMJj?= =?Windows-1252?Q?KXSvd9vfeRWuYybcehZfC/NWA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;6:Ar7+JvfVXn45o/S4gptqm8ZPcP8/MDZtVbgZyNcJbhYXUiEfZsD/QAJRCqxJOUnhYxn7lRqe4dGbxzpJNtH2ybvRtJSKHFHDNr1kRSKJ5eF76O6HxZb1Vyzz7jdXU8WLKZMZfAtMbrf+xYBeqI7Kcmd1Ct65h6RRXxhonz07G68yRosX3iAdziDxImhYBroVz9rA+xqI8AF5dVHLN4FY3uG7pKNzYRARWAJQxxi/S3O9VBQ/kM0djuLSiv53fX0uLzD52L3gBKvS5aMR4jHeKRG+ChxABuaw2Dvt+EFkdsJHQDxx40xGZg4NyX6A4kLWQWA16w7RSg0eH/eSSqbhIg==;5:DGxD2F9WW6Ft9FnJjYBZnLagsw6e580UuKfg3Msfiyzym86wI64ujR5ObyRQXXjpkE0mkPzElK9BPhk5rRLKcJisLrKweFf2/rB9xyqdq7/2BqkBdv8Vem0QglpeDypVArhdWMdd1P1AcV0R3sC9JQ==;24:M0EcJZfLmnHaW/r30+kXseSbiup7r2bm5sTOSYH0faQ3S9YkXbWH9VaZBplAX5nHo8QGP6EI3b2sDRkc48OoZouw3KaZftsxbcC6m2phKJE=;7:OilurhEfmk0hy5Z6poAVCVIXYbSjWPz6x9E0Vfixmqj5ANhaqnMg1AffKSWgZoTOHAtrk1UCQuPuxXOgxLcm2UYAbQTTMx5X2051+K/NeGV6NayQ8bumZ74coJuexp6D4k/xssbASNrfpYGjrbDeuAmTX41pWUJ85nCzCwEe8RT/f7Phb5MIe3UzkMchsxBKI0w9N7eZLpdCYAcs7VDKhlPAffRmOKUz+f4xPZLNiZRLUyMU56SbXAJZ82Z2Rvnl SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1307;20:FJqJmuYDqBnq9LZHNyUoJyDQuUyhpriJbqvnQj/Fdi+OXJ8ZXwp4Mky5bTFDM2N6Xd553gwKb+IqOI+InaJbr7Wq5Nn5t9sFK2AV3ly6zVXROJHa9AFVLegTRQmTnEy+pSK904bsU/vXH6r42Dee10ttz+v+cgWSSL+6r0VSUlK9C4faVsiWN53a0554OGMD2u8Wn5wrn5vAVBMK+SnWq5nH1uGEzGOq1CgzaHOYP19zMnT9ueQcIeqFFX7Lnnef X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2016 13:21:34.1509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1307 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 16.07.2016 um 13:30 schrieb Bhaktipriya Shridhar: > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > Each hardware CRTC has a single flip work queue. > When a radeon_flip_work_func item is queued, it needs to be executed > ASAP because even a slight delay may cause the flip to be delayed by > one refresh cycle. > > Hence, a dedicated workqueue with WQ_HIGHPRI set, has been used here > since a delay can cause the outcome to miss the refresh cycle. > > Since there are only a fixed number of work items, explicit concurrency > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar Reviewed-by: Christian König > --- > Changes in v2: > -Used a dedicated work queue with WQ_HIGHPRI > > drivers/gpu/drm/radeon/radeon_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c > index 6a41b49..64b246e 100644 > --- a/drivers/gpu/drm/radeon/radeon_display.c > +++ b/drivers/gpu/drm/radeon/radeon_display.c > @@ -711,7 +711,7 @@ static void radeon_crtc_init(struct drm_device *dev, int index) > > drm_mode_crtc_set_gamma_size(&radeon_crtc->base, 256); > radeon_crtc->crtc_id = index; > - radeon_crtc->flip_queue = create_singlethread_workqueue("radeon-crtc"); > + radeon_crtc->flip_queue = alloc_workqueue("radeon-crtc", WQ_HIGHPRI, 0); > rdev->mode_info.crtcs[index] = radeon_crtc; > > if (rdev->family >= CHIP_BONAIRE) { > -- > 2.1.4 >