Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

Michel Dänzer
2016-07-04T03:58:54Z

On 02.07.2016 22:46, Tejun Heo wrote:
> On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote:
>> alloc_workqueue replaces deprecated create_singlethread_workqueue().
>>
>> A dedicated workqueue has been used since work items need to be flushed
>> as a group rather than individually.
>>
>> Since the flip_queue workqueue is involved in page-flipping and is not
>> being used on a memory reclaim path, WQ_MEM_RECLAIM has not been set.
>>
>> Since there are only a fixed number of work items, explicit concurrency
>> limit is unnecessary here.
>
> What are the involved work items?

drivers/gpu/drm/radeon/radeon_display.c:radeon_flip_work_func()

> Is it safe to run them concurrently?

Concurrently with what exactly?

--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer