linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xunlei Pang <xpang@redhat.com>
To: Juri Lelli <juri.lelli@arm.com>, xlpang@redhat.com
Cc: peterz@infradead.org, rostedt@goodmis.org,
	linux-kernel@vger.kernel.org, mingo@redhat.com,
	luca.abeni@unitn.it
Subject: Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity
Date: Mon, 18 Jul 2016 21:37:07 +0800	[thread overview]
Message-ID: <578CDB83.1030702@redhat.com> (raw)
In-Reply-To: <20160718130441.GH30141@e106622-lin>

On 2016/07/18 at 21:04, Juri Lelli wrote:
> On 15/07/16 18:39, Xunlei Pang wrote:
>> On 2016/07/13 at 18:58, Juri Lelli wrote:
> [...]
>
>> Since this is only called for queued cases now, there is no need to
>> check boosted stuff here. As enqueue_task(ENQUEUE_REPLENISH)
>> is called before check_class_changed() in rt_mutex_setprio().
>>
> But we don't do the same in setscheduler, right?

If p is deadline PI-boosted, setscheduler() won't call change its sched_class.
If p isn't deadline PI-boosted, then pi_task is NULL.

So, I think the added code won't hit. Did I miss something?

Regards,
Xunlei

  reply	other threads:[~2016-07-18 13:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13 10:58 [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity Juri Lelli
2016-07-15 10:39 ` Xunlei Pang
2016-07-18 13:04   ` Juri Lelli
2016-07-18 13:37     ` Xunlei Pang [this message]
2016-07-21 14:21       ` Juri Lelli
2016-07-21 14:36         ` Juri Lelli
2016-07-21 14:46           ` Juri Lelli
2016-07-22  2:58             ` Xunlei Pang
2016-08-05 10:13               ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=578CDB83.1030702@redhat.com \
    --to=xpang@redhat.com \
    --cc=juri.lelli@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.abeni@unitn.it \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=xlpang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).