From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751703AbcGRNhJ (ORCPT ); Mon, 18 Jul 2016 09:37:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54129 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbcGRNhF (ORCPT ); Mon, 18 Jul 2016 09:37:05 -0400 Reply-To: xlpang@redhat.com Subject: Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity References: <1468407489-30476-1-git-send-email-juri.lelli@arm.com> <5788BD67.5050509@redhat.com> <20160718130441.GH30141@e106622-lin> To: Juri Lelli , xlpang@redhat.com Cc: peterz@infradead.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, mingo@redhat.com, luca.abeni@unitn.it From: Xunlei Pang Message-ID: <578CDB83.1030702@redhat.com> Date: Mon, 18 Jul 2016 21:37:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160718130441.GH30141@e106622-lin> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 18 Jul 2016 13:37:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/07/18 at 21:04, Juri Lelli wrote: > On 15/07/16 18:39, Xunlei Pang wrote: >> On 2016/07/13 at 18:58, Juri Lelli wrote: > [...] > >> Since this is only called for queued cases now, there is no need to >> check boosted stuff here. As enqueue_task(ENQUEUE_REPLENISH) >> is called before check_class_changed() in rt_mutex_setprio(). >> > But we don't do the same in setscheduler, right? If p is deadline PI-boosted, setscheduler() won't call change its sched_class. If p isn't deadline PI-boosted, then pi_task is NULL. So, I think the added code won't hit. Did I miss something? Regards, Xunlei