From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752176AbcGSAxx (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jul 2016 20:53:53 -0400
Received: from mail-qk0-f178.google.com ([209.85.220.178]:36099 "EHLO
	mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751492AbcGSAxu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jul 2016 20:53:50 -0400
Subject: Re: [PATCH v15 06/10] arm64: Treat all entry code as non-kprobe-able
To: Catalin Marinas <catalin.marinas@arm.com>
References: <1467995754-32508-1-git-send-email-dave.long@linaro.org>
 <1467995754-32508-7-git-send-email-dave.long@linaro.org>
 <20160715164720.GC14792@e104818-lin.cambridge.arm.com>
Cc: Huang Shijie <shijie.huang@arm.com>, James Morse <james.morse@arm.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Pratyush Anand <panand@redhat.com>,
        Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
        Will Deacon <will.deacon@arm.com>, William Cohen <wcohen@redhat.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Steve Capper <steve.capper@linaro.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Li Bin <huawei.libin@huawei.com>, Jisheng Zhang <jszhang@marvell.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Petr Mladek <pmladek@suse.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Robin Murphy <robin.murphy@arm.com>, Mark Brown <broonie@kernel.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Dave P Martin <Dave.Martin@arm.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        yalin wang <yalin.wang2010@gmail.com>, Yang Shi <yang.shi@linaro.org>,
        Zi Shen Lim <zlim.lnx@gmail.com>,
        John Blackwood <john.blackwood@ccur.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
        Adam Buchbinder <adam.buchbinder@gmail.com>,
        Christoffer Dall <christoffer.dall@linaro.org>
From: David Long <dave.long@linaro.org>
Message-ID: <578D7A14.6070008@linaro.org>
Date: Mon, 18 Jul 2016 20:53:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20160715164720.GC14792@e104818-lin.cambridge.arm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/15/2016 12:47 PM, Catalin Marinas wrote:
> On Fri, Jul 08, 2016 at 12:35:50PM -0400, David Long wrote:
>> --- a/arch/arm64/kernel/entry.S
>> +++ b/arch/arm64/kernel/entry.S
>> @@ -243,6 +243,7 @@ tsk	.req	x28		// current thread_info
>>    * Exception vectors.
>>    */
>>
>> +	.pushsection ".entry.text", "ax"
>>   	.align	11
>>   ENTRY(vectors)
>>   	ventry	el1_sync_invalid		// Synchronous EL1t
>> @@ -781,3 +782,5 @@ ENTRY(sys_rt_sigreturn_wrapper)
>>   	mov	x0, sp
>>   	b	sys_rt_sigreturn
>>   ENDPROC(sys_rt_sigreturn_wrapper)
>> +
>> +	.popsection
>
> Does the above sigreturn wrapper need to be included in the .entry.text
> section?
>

Apparently not. It wouldn't make sense for that to be in entry.text when 
sys_rt_sigreturn() isn't. I'll put that in the list of changes.

Thanks,
-dl