Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

SF Markus Elfring
2015-01-31T21:48:13Z

>> +exit:
>> return err;
>> }
>
> Why do you use that exit label if it does nothing more than returning
> the error value? Also if nla_parse fails you dont use it but return the
> error directly. While using a label which is used only to return an
> error may be a matter of taste, its at least inconsistent to do both in
> a function, use such a label in one case and return immediately in
> another, isnt it?

I find that all these cases correspond to the current Linux coding
style documentation, doesn't it?

Regards,
Markus