Re: [PATCH] agp/intel-gtt: Deletion of unnecessary checks before the function call "pci_dev_put"

SF Markus Elfring
2015-06-27T16:38:51Z

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 19 Nov 2014 14:24:20 +0100
>
> The pci_dev_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/char/agp/intel-gtt.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
> index 9a024f8..db5877e 100644
> --- a/drivers/char/agp/intel-gtt.c
> +++ b/drivers/char/agp/intel-gtt.c
> @@ -1434,10 +1434,8 @@ void intel_gmch_remove(void)
> if (--intel_private.refcount)
> return;
>
> - if (intel_private.pcidev)
> - pci_dev_put(intel_private.pcidev);
> - if (intel_private.bridge_dev)
> - pci_dev_put(intel_private.bridge_dev);
> + pci_dev_put(intel_private.pcidev);
> + pci_dev_put(intel_private.bridge_dev);
> intel_private.driver = NULL;
> }
> EXPORT_SYMBOL(intel_gmch_remove);
>

Would you like to integrate this update suggestion
into a source code repository?

Regards,
Markus