Re: [PATCH] i2c-HID: Delete unnecessary checks before the function call "gpiod_put"

Jiri Kosina
2015-07-09T12:34:51Z

On Wed, 8 Jul 2015, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 8 Jul 2015 22:12:25 +0200
>
> The gpiod_put() function performs also input parameter validation
> by forwarding its single input pointer to the gpiod_free() function.
> Thus the test around the calls is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

As Dan correctly pointed out, this is not as straightforward as it might
seem on a firsr sight, because there is a WARN_ON() that might start
triggering in case of !ihid->desc.

Adding Benjamin. I am not applying this without his Ack.

--
Jiri Kosina
SUSE Labs