Re: [PATCH 1/3] SCSI-debug: Deletion of unnecessary checks before the function call "vfree"

Douglas Gilbert
2015-02-23T18:14:33Z

On 15-02-06 12:23 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 6 Feb 2015 16:56:57 +0100
>
> The vfree() function performs also input parameter validation.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Douglas Gilbert <dgilbert@interlog.com>

> ---
> drivers/scsi/scsi_debug.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 1132321..9e4add7 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -4969,12 +4969,9 @@ bus_unreg:
> dev_unreg:
> root_device_unregister(pseudo_primary);
> free_vm:
> - if (map_storep)
> - vfree(map_storep);
> - if (dif_storep)
> - vfree(dif_storep);
> + vfree(map_storep);
> + vfree(dif_storep);
> vfree(fake_storep);
> -
> return ret;
> }
>
> @@ -4989,10 +4986,7 @@ static void __exit scsi_debug_exit(void)
> driver_unregister(&sdebug_driverfs_driver);
> bus_unregister(&pseudo_lld_bus);
> root_device_unregister(pseudo_primary);
> -
> - if (dif_storep)
> - vfree(dif_storep);
> -
> + vfree(dif_storep);
> vfree(fake_storep);
> }
>
>