Re: [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_client_clunk"

SF Markus Elfring
2015-01-05T21:55:33Z

>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/net/9p/client.c?id=d8282ea05ad119247122de23db7d48ad6098cfa2#n1448
>> http://lxr.free-electrons.com/source/net/9p/client.c#L1448
>
> What do you mean by "work in principle"?

If I do not stumble on an unexpected name space issue from my static source
analysis again, then I would see the linked function as relevant here.
Its implementation provides a clear input parameter validation.

> But you don't want to do a dump_stack for no reason. That would at best
> be very misleading, and I would imagine be quite expensive.

The error response is clear. Are any software developments efforts expected
to clean-up the call stack for unwanted null pointers even more?

Regards,
Markus