From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753110AbcGSIxG (ORCPT ); Tue, 19 Jul 2016 04:53:06 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:65045 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753046AbcGSIw7 (ORCPT ); Tue, 19 Jul 2016 04:52:59 -0400 X-AuditID: cbfec7f4-f796c6d000001486-e2-578dea6985aa Message-id: <578DEA68.4050200@samsung.com> Date: Tue, 19 Jul 2016 10:52:56 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: "H. Nikolaus Schaller" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Richard Purdie , drivshin.allworx@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, kernel@pyra-handheld.com, marek@goldelico.com, letux-kernel@openphoenux.org, Andrey Utkin Subject: Re: [PATCH v4 2/2] Bindings documentation for ISSI is31fl319x driver References: In-reply-to: Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsVy+t/xy7qZr3rDDS7uF7b4/+0ai8X8I+dY LRZPnsVu0f9mIavFj21fmSzOvVrJaHHpa43F1j+X2Cwu75rDZrH1zTpGi39Lt7BZLL1+kcli wvS1LBate4+wW+ze9ZTVgd9jzbw1jB6X+3qZPBa9nM/usXPWXXaPNe9PMXusXP6FzWPTqk42 j5ZJu9g9vrQ0M3vsmf+D1ePzJrkA7igum5TUnMyy1CJ9uwSujPU357MX9IlUbPn3nLGBsV+g i5GTQ0LARKLnxWM2CFtM4sK99UA2F4eQwFJGiXdPF7FDOM8YJSa8mg1WxSugJXFsD4TNIqAq seLsMWYQm03AUOLni9dMILaoQITEn9P7WCHqBSV+TL7HAmKLCOhJdH7/wwIylFngGrNE15HJ 7CAJYQFficsXfkKtbmKU+DBvBtgkToEoiWMTJ4LZzALWEisnbWOEsOUlNq95yzyBUWAWkiWz kJTNQlK2gJF5FaNoamlyQXFSeq6hXnFibnFpXrpecn7uJkZI1H3Zwbj4mNUhRgEORiUe3gS2 3nAh1sSy4srcQ4wSHMxKIrxnXgKFeFMSK6tSi/Lji0pzUosPMUpzsCiJ887d9T5ESCA9sSQ1 OzW1ILUIJsvEwSnVwGgaGhYz59Dexy7lJ/R+rHt+y+ru1tUvG7L36JxZM+veRoGEpSd9+fTO /m/+N+vu3qr2wyJSibvfrjrDw3Set9K8efom45beZo4jPzvmShzIKd0QHG05cWfH88O8+U+Z DoodlhCyO/X/tdjsoOMv5KeqHj6z7uhXf4ltZ092ulXv5V932/6B4h82JZbijERDLeai4kQA zYVgv7YCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nikolaus, On 07/19/2016 10:03 AM, H. Nikolaus Schaller wrote: > Signed-off-by: H. Nikolaus Schaller > --- > .../devicetree/bindings/leds/is31fl319x.txt | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt > > diff --git a/Documentation/devicetree/bindings/leds/is31fl319x.txt b/Documentation/devicetree/bindings/leds/is31fl319x.txt > new file mode 100644 > index 0000000..c42c89c > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/is31fl319x.txt > @@ -0,0 +1,56 @@ > +LEDs connected to is31fl319x LED controller chip > + > +Required properties: > +- compatible : Should be any of > + "issi,is31fl3190" > + "issi,is31fl3191" > + "issi,is31fl3193" > + "issi,is31fl3196" > + "issi,is31fl3199" > + "si-en,sn3199". > +- #address-cells: Must be 1. > +- #size-cells: Must be 0. > +- reg: 0x64, 0x65, 0x66, 0x67. > + > +Optional properties: > +- audio-gain-db : audio gain selection for external analog modulation input. > + Valid values: 0 - 21, step by 3 (rounded down) > + Default: 0 > + > +Each led is represented as a sub-node of the issi,is31fl319x device. > +There can be less leds subnodes than the chip can support but not more. > + > +Required led sub-node properties: > +- reg : number of LED line > + Valid values: 1 - number of leds supported by the chip variant. > + > +Optional led sub-node properties: > +- label : see Documentation/devicetree/bindings/leds/common.txt. > +- linux,default-trigger : > + see Documentation/devicetree/bindings/leds/common.txt. > +- led-max-microamp : (optional) > + Valid values: 5000 - 40000, step by 5000 (rounded down) > + Default: 20000 (20 mA) > + Note: a driver will take the lowest of all led limits since the > + chip has a single global setting. I'd mention here that the lowest value will be chosen due to the PWM specificity, where lower brightness is achieved by reducing the frequency of pulses and not the current, which will always have its peak value equal to led-max-microamp. > + > +Examples: > + > +fancy_leds: leds@65 { > + compatible = "issi,is31fl3196"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x65>; > + > + red_aux: led@1 { > + label = "red:aux"; > + reg = <1>; > + led-max-microamp = <10000>; > + }; > + > + green_power: led@5 { > + label = "green:power"; > + reg = <5>; > + linux,default-trigger = "default-on"; > + }; > +}; > -- Best regards, Jacek Anaszewski