From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754135AbcGSPvJ (ORCPT ); Tue, 19 Jul 2016 11:51:09 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33735 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753993AbcGSPuS (ORCPT ); Tue, 19 Jul 2016 11:50:18 -0400 Subject: Re: [PATCH v1] ESIA : Dummy eisa_driver_register should return error code To: Christoph Hellwig References: <1468867501-19054-1-git-send-email-arvind.yadav.cs@gmail.com> <20160719043152.GA27579@infradead.org> Cc: linux-kernel@vger.kernel.org From: arvind Yadav Message-ID: <578E4C33.2070200@gmail.com> Date: Tue, 19 Jul 2016 21:20:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160719043152.GA27579@infradead.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SCSI_AHA1740 : This is support for a SCSI host adapter. If CONFIG_EISA is disable then we should not register eisa driver. static __init int aha1740_init (void) { return eisa_driver_register (&aha1740_driver); } static __exit void aha1740_exit (void) { eisa_driver_unregister (&aha1740_driver); } module_init (aha1740_init); module_exit (aha1740_exit); ---------------------------------------- -Shall we add check by using CONFIG_EISA. We can avoid to register a dummy driver. static __init int aha1740_init (void) { int err = 0; #ifdef CONFIG_EISA err = eisa_driver_register (&aha1740_driver); #endif return err; } static __exit void aha1740_exit (void) { #ifdef CONFIG_EISA eisa_driver_unregister (&aha1740_driver); #endif } On Tuesday 19 July 2016 10:01 AM, Christoph Hellwig wrote: > On Tue, Jul 19, 2016 at 12:15:01AM +0530, Arvind Yadav wrote: >> The inline eisa_driver_register stub simply allows compilation on >> systems with CONFIG_EISA disabled. the dummy eisa_driver_register >> does not register an *_eisa_driver at all. The inline >> eisa_driver_register should return to indicate lack of support >> when attempting to register an *_eisa_driver on such a system with >> CONFIG_EISA disabled. > Why? The idea is that you can simply leave the stub in if registering > say PCI / EISA. With your change such a driver will fail to load even > if it could serve PCI device in a !CONFIG_EISA config, which is the > behavior we want.